osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Answer a locale question in a comment. 

Change-Id: If2c287ed8d2a3b518ceff891f1e6d995d7a7daad
Reviewed-on: https://code.wireshark.org/review/17182
Reviewed-by: Gerald Combs <gerald@wireshark.org>
This commit is contained in:
Gerald Combs 2016-08-19 13:59:49 -07:00
parent f52ce40459
commit 7cfb8b81f9
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ws_version_info.c
View File

@ -334,13 +334,9 @@ get_runtime_version_info(void (*additional_info)(GString *))
* it doesn't happen to match the settings of any of the * it doesn't happen to match the settings of any of the
* locale environment variables. * locale environment variables.
* *
* XXX - what happens on Windows? If nobody's explicitly * On Windows get_locale returns the full language, country
* overridden any of the environment variables, does this * name, and code page, e.g. "English_United States.1252":
* reflect the locale settings in the OS? If so, does * https://msdn.microsoft.com/en-us/library/x99tb11d.aspx
* that include the code page? (We're not using UTF-16
* for output to files or the console; using code page
* 65001, i.e. UTF-8, as your system code page probably
* works best with Wireshark.)
*/ */
if ((lang = get_locale()) != NULL) { if ((lang = get_locale()) != NULL) {
g_string_append_printf(str, ", with locale %s", lang); g_string_append_printf(str, ", with locale %s", lang);