osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

woww: Change SMSG_AUTH_RESPONSE result field size from 4 to 1 

I somehow mistook the size of this field for a u32 instead of a u8
earlier.

vmangos clearly shows that it's a u8:
cd896d4371/src/game/World.cpp (L322)

and cmangos:
98a53ea30d/src/game/Server/WorldSession.cpp (L947)
This commit is contained in:
Gtker 2022-06-04 12:03:12 +02:00 committed by A Wireshark GitLab Utility
parent 9b08b02d8e
commit 60efc1a1c0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
epan/dissectors/packet-woww.c
View File

@ -4681,7 +4681,7 @@ add_body_fields(guint32 opcode,
break;
case SMSG_AUTH_RESPONSE:
ptvcursor_add(ptv, hf_woww_result, 4, ENC_LITTLE_ENDIAN);
ptvcursor_add(ptv, hf_woww_result, 1, ENC_NA);
// There might more fields depending on the value in login_result.
// Not implemented currently because they aren't that important.
break;
@ -5048,7 +5048,7 @@ proto_register_woww(void)
},
{ &hf_woww_result,
{ "Result", "woww.result",
FT_UINT32, BASE_HEX, VALS(account_result_strings), 0,
FT_UINT8, BASE_HEX, VALS(account_result_strings), 0,
NULL, HFILL }
},
{ &hf_woww_amount_of_characters,