osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Don't byte-swap an 1-byte value." 

This reverts commit 74a2ae4aba.

No, that's just Coverity not understanding macros *again*, and thinking a particular expanded instance of a macro is the result of some human being silly rather than of the arguments being such that some computations can be elided at compile time.

Change-Id: I40f2ad8bf018b0df02d90ed0e272505be68dae7e
Reviewed-on: https://code.wireshark.org/review/22693
Reviewed-by: Guy Harris <guy@alum.mit.edu>
This commit is contained in:
Guy Harris 2017-07-18 04:27:53 +00:00
parent e934fad638
commit 5fd255424f
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wiretap/erf.c
View File

@ -1065,7 +1065,6 @@ static void erf_write_wtap_option_to_interface_tag(wtap_block_t block _U_,
struct erf_meta_section *section_ptr = (struct erf_meta_section*) user_data;
struct erf_meta_tag *tag_ptr = NULL;
guint32 fcslen;
tag_ptr = (struct erf_meta_tag*) g_malloc0(sizeof(struct erf_meta_tag));
@ -1131,8 +1130,7 @@ static void erf_write_wtap_option_to_interface_tag(wtap_block_t block _U_,
tag_ptr->type = ERF_META_TAG_fcs_len;
tag_ptr->length = 4;
tag_ptr->value = (guint8*)g_malloc(tag_ptr->length);
fcslen = (guint32)optval->uint8val;
phtonl(tag_ptr->value, fcslen);
phtonl(tag_ptr->value, (guint32)optval->uint8val);
break;
/* TODO: Don't know what to do with these yet */
case OPT_IDB_EUIADDR: