osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

checkhf: Use colon as field separator for better readability 

Comma looks like a list when skimming quickly.

Change-Id: Ic0ac1bc8746c70724d2279e3d725c5c9449b79d8
Reviewed-on: https://code.wireshark.org/review/16260
Reviewed-by: João Valverde <j@v6e.pt>
Reviewed-by: Michael Mann <mmann78@netscape.net>
This commit is contained in:
João Valverde 2016-07-03 13:17:41 +01:00 committed by Michael Mann
parent ff7d0b31d0
commit 50614a95ba
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/checkhf.pl
View File

@ -135,8 +135,8 @@ while (my $filename = $ARGV[0]) {
$unused_ei = diff_hash(\%ei_static_defs, \%ei_usage);
print_list("Unused href entry: $filename, ", $unused_href);
print_list("Unused ei entry: $filename, ", $unused_ei);
print_list("Unused href entry: $filename: ", $unused_href);
print_list("Unused ei entry: $filename: ", $unused_ei);
# 2. Are all the hf_defs and ei_ entries (static and global) in [hf|ei]_array_entries ?
# (Note: if a static hf_def or ei is "unused", don't check for same in [hf|ei]_array_entries)
@ -150,8 +150,8 @@ while (my $filename = $ARGV[0]) {
$no_array_ei = diff_hash(\%ei_static_defs, \%ei_array_entries);
$no_array_ei = diff_hash($no_array_ei, $unused_ei); # Remove "unused" ei_... from no_array list
print_list("ERROR: NO ARRAY: $filename, ", $no_array_href);
print_list("ERROR: NO ARRAY: $filename, ", $no_array_ei);
print_list("ERROR: NO ARRAY: $filename: ", $no_array_href);
print_list("ERROR: NO ARRAY: $filename: ", $no_array_ei);
if ((keys %{$no_array_href}) != 0) {
$error += 1;