osmocom
/
wireshark
14
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Add a few comments and return with an error code if 

appropriate, that way the whole stuff gets scriptable.
right now warnings are error code 0 (like completely
fine code).

svn path=/trunk/; revision=34730
This commit is contained in:
Jörg Mayer 2010-10-31 09:05:11 +00:00
parent e52c685b2a
commit 462245ba9a
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tools/checkhf.pl
View File

@ -83,6 +83,8 @@ my $currfile = "";
my $comment = 0; my $comment = 0;
my $brace = 0; my $brace = 0;
my $error = 0;
sub printprevfile { sub printprevfile {
my $state; my $state;
@ -92,13 +94,20 @@ sub printprevfile {
if ($state eq "s_usedarray") { if ($state eq "s_usedarray") {
# Everything is fine # Everything is fine
} elsif ($state eq "s_used") { } elsif ($state eq "s_used") {
print "NO ARRAY: $currfile, $element\n" # A value is declared and used but the hf_ array
# entry is missing
print "ERROR: NO ARRAY: $currfile, $element\n";
$error = 1;
} elsif ($state eq "s_array") { } elsif ($state eq "s_array") {
print "Unused entry: $currfile, $element\n" # A value is declared, has an hf_ array entry
# but it is never used
print "Unused entry: $currfile, $element\n";
} elsif ($state eq "s_declared") { } elsif ($state eq "s_declared") {
# A value is declared but no error value exists.
# This doesn't matter as it isn't used either.
print "Declared only entry: $currfile, $element\n" print "Declared only entry: $currfile, $element\n"
} elsif ($state eq "s_unknown") { } elsif ($state eq "s_unknown") {
print "UNKNOWN: $currfile, $element\n" print "UNKNOWN: $currfile, $element\n";
} else { } else {
die "Impossible: State $state for $currfile, $element\n"; die "Impossible: State $state for $currfile, $element\n";
} }
@ -224,6 +233,6 @@ while (<>) {
} }
&printprevfile(); &printprevfile();
exit 0; exit $error;
__END__ __END__