osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Correct comments and examples on get_pdu_len(). 

svn path=/trunk/; revision=19949
This commit is contained in:
Jaap Keuter 2006-11-21 14:18:46 +00:00
parent c266084cdd
commit 45aa24f1ec
4 changed files with 25 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
doc/README.developer
View File

@ -3120,12 +3120,12 @@ The arguments to tcp_dissect_pdus are:
the number of bytes of PDU data required to determine the length
of the PDU;
a routine that takes as arguments a tvbuff pointer and an offset
value representing the offset into the tvbuff at which a PDU
begins and should return - *without* throwing an exception (it
is guaranteed that the number of bytes specified by the previous
argument to tcp_dissect_pdus is available, but more data might
not be available, so don't refer to any data past that) - the
a routine that takes as arguments a packet_info pointer, a tvbuff
pointer and an offset value representing the offset into the tvbuff
at which a PDU begins and should return - *without* throwing an
exception (it is guaranteed that the number of bytes specified by the
previous argument to tcp_dissect_pdus is available, but more data
might not be available, so don't refer to any data past that) - the
total length of the PDU, in bytes;
a routine that's passed a tvbuff pointer, packet_info pointer,

30
docbook/wsdg_src/WSDG_chapter_dissection.xml
View File

@ -536,9 +536,10 @@ static const value_string packettypenames[] = {
<programlisting>
<![CDATA[
{ &hf_foo_pdu_type,
{ "FOO PDU Type", "foo.type",
FT_UINT8, BASE_DEC, VALS(packettypenames), 0x0,
"", HFILL }
{ "FOO PDU Type", "foo.type",
FT_UINT8, BASE_DEC,
VALS(packettypenames), 0x0,
NULL, HFILL }
},
]]>
</programlisting></example>
@ -558,19 +559,22 @@ static int hf_foo_endflag = -1;
static int hf_foo_priorityflag = -1;
...
{ &hf_foo_startflag,
{ "FOO PDU Start Flags", "foo.flags.start",
FT_BOOLEAN, 8, NULL, FOO_START_FLAG,
"", HFILL }
{ "FOO PDU Start Flags", "foo.flags.start",
FT_BOOLEAN, 8,
NULL, FOO_START_FLAG,
NULL, HFILL }
},
{ &hf_foo_endflag,
{ "FOO PDU End Flags", "foo.flags.end",
FT_BOOLEAN, 8, NULL, FOO_END_FLAG,
"", HFILL }
{ "FOO PDU End Flags", "foo.flags.end",
FT_BOOLEAN, 8,
NULL, FOO_END_FLAG,
NULL, HFILL }
},
{ &hf_foo_priorityflag,
{ "FOO PDU Priority Flags", "foo.flags.priority",
FT_BOOLEAN, 8, NULL, FOO_PRIORITY_FLAG,
"", HFILL }
{ "FOO PDU Priority Flags", "foo.flags.priority",
FT_BOOLEAN, 8,
NULL, FOO_PRIORITY_FLAG,
NULL, HFILL }
},
...
proto_tree_add_item(foo_tree, hf_foo_flags, tvb, offset, 1, FALSE);
@ -1038,7 +1042,7 @@ static void dissect_foo_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *t
}
/* determine PDU length of protocol foo */
static guint get_foo_message_len(tvbuff_t *tvb, int offset)
static guint get_foo_message_len(packet_info *pinfo, tvbuff_t *tvb, int offset)
{
/* TODO: change this to your needs */
return (guint)tvb_get_ntohl(tvb, offset+4); /* e.g. length is at offset 4 */

2
epan/dissectors/packet-tcp.c
View File

@ -1462,7 +1462,7 @@ again:
* "fixed_len" is the length of the fixed-length part of the PDU.
*
* "get_pdu_len()" is a routine called to get the length of the PDU from
* the fixed-length part of the PDU; it's passed "tvb" and "offset".
* the fixed-length part of the PDU; it's passed "pinfo", "tvb" and "offset".
*
* "dissect_pdu()" is the routine to dissect a PDU.
*/

2
epan/dissectors/packet-tcp.h
View File

@ -76,7 +76,7 @@ struct tcpinfo {
* "fixed_len" is the length of the fixed-length part of the PDU.
*
* "get_pdu_len()" is a routine called to get the length of the PDU from
* the fixed-length part of the PDU; it's passed "tvb" and "offset".
* the fixed-length part of the PDU; it's passed "pinfo", "tvb" and "offset".
*
* "dissect_pdu()" is the routine to dissect a PDU.
*/