osmocom
/
wireshark
11
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Qt: Fix dangling delete for sequence diagramm" 

This reverts commit aa2145982f.

Each of the three delete calls added to the deconstructor
SequenceDialog::~SequenceDialog() results in Wireshark
crashing when the Flow dialog is closed.

Bug: 16260
Change-Id: Iecbd5dcc16be6eb451b8920b22ca2b9ccef7c7b0
Reviewed-on: https://code.wireshark.org/review/35521
Petri-Dish: Jim Young <jim.young.ws@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>
This commit is contained in:
Jim Young 2019-12-20 08:16:18 -05:00 committed by Roland Knall
parent 2a1d27bcbf
commit 31570163d1
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ui/qt/sequence_dialog.cpp
View File

@ -191,9 +191,6 @@ SequenceDialog::SequenceDialog(QWidget &parent, CaptureFile &cf, SequenceInfo *i
SequenceDialog::~SequenceDialog()
{
delete key_text_;
delete comment_text_;
delete seq_diagram_;
info_->unref();
delete ui;
}