osmocom
/
osmo-sysmon
mirror of https://gerrit.osmocom.org/osmo-sysmon
11
0
Fork 0
Code Releases Activity
osmo-sysmon/fd4b2708942ad315dba96bf5276...

477 lines
14 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "258045b4_82e4ab9e",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 68,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "get_authority memleak,",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "d25d3f0e_df033ac2",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 68,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Done",
"parentUuid": "258045b4_82e4ab9e",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "1f6d457b_a71323a7",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 74,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "get_authority memleak.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "dfcd324c_695a08aa",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 74,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Done",
"parentUuid": "1f6d457b_a71323a7",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "a076cdb9_12c2653e",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 79,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "if that\u0027s a string, then you can simply use osmo_strlcpy afaik.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "8d1d3ca5_82a4cde9",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 79,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Done",
"parentUuid": "a076cdb9_12c2653e",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "110eac2c_7a79481c",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 82,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "add missing {}, otherwise it\u0027s confusing. Only use conditionals without bracket for one-line sections.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "a813a1e9_2795946c",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 82,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Done",
"parentUuid": "110eac2c_7a79481c",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "24248852_9c975de9",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 83,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "if I understand correctly, first time switch is checked against i\u003d0 (because it\u0027s incremented afterwards), and I see no 0 case here.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "13758033_c0d7a105",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 83,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Done",
"parentUuid": "24248852_9c975de9",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "f6060a17_523f60e7",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 127,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "(!msg)",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "13b2802c_295a656c",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 127,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Done",
"parentUuid": "f6060a17_523f60e7",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "100aa712_7ac334ce",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 134,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "mem leak, get_authority allocates stuff.\n\nalso, msg is leaked.\n\nbetter use goto.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "fd7746eb_411ca999",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 134,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Done",
"parentUuid": "100aa712_7ac334ce",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "dcfa1b0a_010b67c6",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 149,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "that\u0027s weird from API point of view. You usually expect a \"create\" API to allocate and return newly-allocated struct. Otherwise you never know if a new struct was allocated (which needs to be freed at some point) or an already previously struct was returned (and then avoid double freeing).\n\nCalling it \"find_or_create\" would be more clear.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "1005b76f_d84edc4d",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 149,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Done",
"parentUuid": "dcfa1b0a_010b67c6",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "a8ee19d7_35d03560",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 159,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "Instead of talloc_free + return false in lots of places, use a goto to end of function.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "4f986776_74ec2a44",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 159,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Done",
"parentUuid": "a8ee19d7_35d03560",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "99442a59_6458f075",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 178,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "was this already fixed? otherwise please open a ticket and put the ticket number in the commit for later reference.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "f2287b81_e54b190b",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 178,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "libosmo-netif patches are under review ATM",
"parentUuid": "99442a59_6458f075",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "604c21b6_bd1ba45b",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 263,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "possible memleak of remote later on, to be checked.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "ce1d6860_c2cfd5b6",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 263,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "What makes you think that? It should be automatically cleaned by talloc on vty refresh.",
"parentUuid": "604c21b6_bd1ba45b",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "e6c6d040_90e8a4cc",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 263,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-07T17:29:06Z",
"side": 1,
"message": "Why keeping it until then if it\u0027s not longer needed? Do we believe on garbage collectors now?",
"parentUuid": "ce1d6860_c2cfd5b6",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "d5782a23_6afd719b",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 267,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "Not sure what is this for.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "737c0504_488d1c35",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 267,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Not what you\u0027re referring to:\n- msgb_printf is to print stuff into msgb, documented in libosmocore\n- osmo_stream_cli_send is to send msgb, documented in libosmo-netif",
"parentUuid": "d5782a23_6afd719b",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "8099dc70_fb66d9d5",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 287,
"author": {
"id": 1000074
},
"writtenOn": "2019-02-01T16:34:56Z",
"side": 1,
"message": "No need to count, just check if the list is not empty.",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "25b755d4_0d3bbdef",
"filename": "src/osysmon_openvpn.c",
"patchSetId": 5
},
"lineNbr": 287,
"author": {
"id": 1000006
},
"writtenOn": "2019-02-07T16:45:30Z",
"side": 1,
"message": "Done",
"parentUuid": "8099dc70_fb66d9d5",
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
}
]
}
View Git Blame Copy Permalink