mirror of https://gerrit.osmocom.org/osmo-sysmon
72 lines
2.1 KiB
Plaintext
72 lines
2.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "86b5f75e_f92167e6",
|
|
"filename": "src/osysmon_main.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 252,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2019-02-07T17:29:06Z",
|
|
"side": 1,
|
|
"message": "why not always polling osmocom event loop with a timeout of 1 second instead of instant polling + sleep?",
|
|
"revId": "9a852f2dd87b5c4ef0b1780928ff2844a071f8d8",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "56c73845_5a09f0a1",
|
|
"filename": "src/osysmon_openvpn.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 45,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2019-02-07T17:29:06Z",
|
|
"side": 1,
|
|
"message": "make_authority memleaks here, or at least unnecesarily delays its free.",
|
|
"revId": "9a852f2dd87b5c4ef0b1780928ff2844a071f8d8",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "beca4e56_ae6196b9",
|
|
"filename": "src/osysmon_openvpn.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 67,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2019-02-07T17:29:06Z",
|
|
"side": 1,
|
|
"message": "would be clearer to cast here already if we know it\u0027s a string:\nchar *m \u003d (char*) msgb_data(msg);\n\nthen you can remove the cast in line 80.",
|
|
"revId": "9a852f2dd87b5c4ef0b1780928ff2844a071f8d8",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "c92dd0b0_78da77d2",
|
|
"filename": "src/osysmon_openvpn.c",
|
|
"patchSetId": 7
|
|
},
|
|
"lineNbr": 104,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2019-02-07T17:29:06Z",
|
|
"side": 1,
|
|
"message": "that\u0027s not making aything, its only finding.",
|
|
"revId": "9a852f2dd87b5c4ef0b1780928ff2844a071f8d8",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |