mirror of https://gerrit.osmocom.org/osmo-sysmon
Update patch set 7
Patch Set 7: (13 comments) This change is ready for review. Patch-set: 7 Reviewer: Max <1000006@035e6965-6537-41bd-912c-053f3cf69326> Work-in-progress: false
This commit is contained in:
Max
Gerrit Code Review
parent
d954ccec83
commit
16e45740bd
|
|
@ -17,6 +17,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "d25d3f0e_df033ac2",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 68,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "258045b4_82e4ab9e",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1f6d457b_a71323a7",
|
||||
|
|
@ -34,6 +52,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "dfcd324c_695a08aa",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 74,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "1f6d457b_a71323a7",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "a076cdb9_12c2653e",
|
||||
|
|
@ -51,6 +87,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "8d1d3ca5_82a4cde9",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 79,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "a076cdb9_12c2653e",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "110eac2c_7a79481c",
|
||||
|
|
@ -68,6 +122,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "a813a1e9_2795946c",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 82,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "110eac2c_7a79481c",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "24248852_9c975de9",
|
||||
|
|
@ -85,6 +157,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "13758033_c0d7a105",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 83,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "24248852_9c975de9",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "f6060a17_523f60e7",
|
||||
|
|
@ -102,6 +192,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "13b2802c_295a656c",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 127,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "f6060a17_523f60e7",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "100aa712_7ac334ce",
|
||||
|
|
@ -119,6 +227,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fd7746eb_411ca999",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 134,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "100aa712_7ac334ce",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "dcfa1b0a_010b67c6",
|
||||
|
|
@ -136,6 +262,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1005b76f_d84edc4d",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 149,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "dcfa1b0a_010b67c6",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "a8ee19d7_35d03560",
|
||||
|
|
@ -153,6 +297,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "4f986776_74ec2a44",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 159,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "a8ee19d7_35d03560",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "99442a59_6458f075",
|
||||
|
|
@ -170,6 +332,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "f2287b81_e54b190b",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 178,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "libosmo-netif patches are under review ATM",
|
||||
"parentUuid": "99442a59_6458f075",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "604c21b6_bd1ba45b",
|
||||
|
|
@ -187,6 +367,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "ce1d6860_c2cfd5b6",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 263,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "What makes you think that? It should be automatically cleaned by talloc on vty refresh.",
|
||||
"parentUuid": "604c21b6_bd1ba45b",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "d5782a23_6afd719b",
|
||||
|
|
@ -204,6 +402,24 @@
|
|||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "737c0504_488d1c35",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 267,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Not what you\u0027re referring to:\n- msgb_printf is to print stuff into msgb, documented in libosmocore\n- osmo_stream_cli_send is to send msgb, documented in libosmo-netif",
|
||||
"parentUuid": "d5782a23_6afd719b",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "8099dc70_fb66d9d5",
|
||||
|
|
@ -220,6 +436,24 @@
|
|||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "25b755d4_0d3bbdef",
|
||||
"filename": "src/osysmon_openvpn.c",
|
||||
"patchSetId": 5
|
||||
},
|
||||
"lineNbr": 287,
|
||||
"author": {
|
||||
"id": 1000006
|
||||
},
|
||||
"writtenOn": "2019-02-07T16:45:30Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "8099dc70_fb66d9d5",
|
||||
"revId": "fd4b2708942ad315dba96bf52768839cf1614ca0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue