osmo-ci

Commit Graph

Author	SHA1	Message	Date
Oliver Smith	f560ce08ab	jenkins-gerrit: fix ambiguous use of review api Fix an error when the same Change-Id is used on multiple branches or in theory projects. This is actually allowed by gerrit, and we use this e.g. when backporting patches from master. Use the project, change number (e.g. 30147) and patchset number (e.g. 2) instead of the Change-Id. Fix for: + ssh -p 29418 -l jenkins gerrit.osmocom.org gerrit review 4835a62cd88f0d69db76fb3bfd2df02176a91a6d --json fatal: "4835a62cd88f0d69db76fb3bfd2df02176a91a6d" matches multiple patch sets Related: https://gerrit-review.googlesource.com/Documentation/cmd-review.html Change-Id: I2d627f8f3b400fa57a50a228d47df2194f60fd08	2022-11-15 11:38:08 +00:00
Oliver Smith	c4df55dcfd	jenkins-gerrit: send mail for V+1 for some users Add a list of users that do not only get a notification mail when the gerrit verification failed, but also on success. Change-Id: I603b8a911c8f17aa726d9e3d5d644ad3262b42dd	2022-10-27 16:43:14 +02:00
Oliver Smith	4e679c8f2e	jobs/gerrit-verifications: write summary comment Instead of having multiple mails from jenkins per submitted gerrit patch, only have one at the end of the pipeline that writes a summary with all relevant links and votes +1/-1 for verified. This also resolves the problem we had for a long time, that the link for the build job didn't directly point to the relevant console output. Instead it pointed to a matrix job that didn't have a direct link to the relevant job. The summary looks like this: 1 failed: [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bsc-nat-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit-debian9/11/consoleFull 3 passed: [rpm] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs-rpm/5/consoleFull [deb] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs-deb/5/consoleFull [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/11/consoleFull Build Failed Related: OS#2385 Change-Id: Idcab969e1b5ca4e0f1383bee8f36f2d1aac4f624	2022-10-11 12:07:40 +02:00

Author

SHA1

Message

Date

Oliver Smith

f560ce08ab

jenkins-gerrit: fix ambiguous use of review api

Fix an error when the same Change-Id is used on multiple branches or in
theory projects. This is actually allowed by gerrit, and we use this
e.g. when backporting patches from master.

Use the project, change number (e.g. 30147) and patchset number (e.g. 2)
instead of the Change-Id.

Fix for:
  + ssh -p 29418 -l jenkins gerrit.osmocom.org gerrit review 4835a62cd88f0d69db76fb3bfd2df02176a91a6d --json
  fatal: "4835a62cd88f0d69db76fb3bfd2df02176a91a6d" matches multiple patch sets

Related: https://gerrit-review.googlesource.com/Documentation/cmd-review.html
Change-Id: I2d627f8f3b400fa57a50a228d47df2194f60fd08

2022-11-15 11:38:08 +00:00

Oliver Smith

c4df55dcfd

jenkins-gerrit: send mail for V+1 for some users

Add a list of users that do not only get a notification mail when the
gerrit verification failed, but also on success.

Change-Id: I603b8a911c8f17aa726d9e3d5d644ad3262b42dd

2022-10-27 16:43:14 +02:00

Oliver Smith

4e679c8f2e

jobs/gerrit-verifications: write summary comment

Instead of having multiple mails from jenkins per submitted gerrit
patch, only have one at the end of the pipeline that writes a summary
with all relevant links and votes +1/-1 for verified.

This also resolves the problem we had for a long time, that the link for
the build job didn't directly point to the relevant console output.
Instead it pointed to a matrix job that didn't have a direct link to the
relevant job.

The summary looks like this:

1 failed:
  [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bsc-nat-build/a1=default,a2=default,a3=default,a4=default,label=osmocom-gerrit-debian9/11/consoleFull

3 passed:
  [rpm] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs-rpm/5/consoleFull
  [deb] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs-deb/5/consoleFull
  [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/11/consoleFull

Build Failed

Related: OS#2385
Change-Id: Idcab969e1b5ca4e0f1383bee8f36f2d1aac4f624

2022-10-11 12:07:40 +02:00

3 Commits