osmocom
/
osmo-ci
mirror of https://gerrit.osmocom.org/osmo-ci
10
0
Fork 1
Code Releases Activity
789 Commits 34 Branches 0 Tags 9.5 MiB
Commit Graph

18 Commits

Author SHA1 Message Date
Vadim Yanitskiy 5b72401b59 lint/checkpatch: ignore csn1_(enc|dec).c files in osmo-pcu.git 
Change-Id: I5f8c83e3a8b9f5280779d6a6cf0736b9d3f4e958
Related: I7d1b1f7e6d7f89b052b3fd73a960419bb2673020
 2021-10-20 21:25:31 +03:00
Oliver Smith b00eb7b012 lint: osmo-pcu: exclude imported wireshark code 
Related: OS#5087
Change-Id: I70814512bdba50363edd4195b5b073698ea6532c
 2021-10-08 14:15:40 +02:00
Oliver Smith b228c23e08 lint: support project-specific exclude paths 
While at it, put in the exact path to spelling.txt in osmo-ci.git.

Related: OS#5087
Change-Id: Ib23f9c65da1916ebf4654c5e641eaffe6c75315c
 2021-10-08 14:15:09 +02:00
Oliver Smith 477218474f lint: checkpatch_osmo.sh: ignore debian/changelog 
Auto-generated from commit log, may contain spelling errors.

Fixes: OS#5232
Change-Id: Id0ccfbff73464dac7f7f939c88a9e2677fa2a37f
 2021-09-15 16:41:18 +02:00
Oliver Smith 654cfb3192 lint: checkpatch_osmo.sh: ignore UNSPECIFIED_INT 
As suggested by Pau, let's remove this check because it isn't useful for us.

Related: OS#5087
Change-Id: I15345a154f490362093e46fc0df75e75bbb237fe
 2021-09-13 10:37:06 +02:00
Oliver Smith 94cf194666 lint: checkpatch_osmo.sh: ignore UNNECESSARY_INT 
Related: https://gerrit.osmocom.org/c/libosmocore/+/25345/4#message-8f6827dc90942698d23ebb909544bf60fa461b2d
Related: OS#5087
Change-Id: I5be890a296b37511affc17cb786f0709de822826
 2021-09-13 10:32:15 +02:00
Oliver Smith 4f75177e8c lint: checkpatch_osmo.sh: ignore LONG_LINE_* 
According to a comment in checkpatch.pl, these should automatically be
ignored when LONG_LINE is ignored. However I found that it's still
complaining about LONG_LINE_COMMENT, so explicitly disable it.

Related: OS#5087
Change-Id: I7aed3bfbfcb0b9e2f1d743b111e8418846f031d2
 2021-09-03 08:27:28 +00:00
Oliver Smith 8cbd4bf779 lint: ignore EMBEDDED_FILENAME 
Mentioning the file in itself is useful sometimes (e.g. when explaining
how to use a contrib script). So do not let the linter fail here.

Related: OS#5087
Change-Id: I151b97bc7f2fe83898c0598db54360807956993c
 2021-08-16 11:27:11 +02:00
Oliver Smith b70fede452 lint: ignore LONG_LINE 
With recent code reviews I've realized that in Osmocom we do often use
more than 120 characters per line for various reasons. So adjust the
linter to not fail anymore if that is the case.

Related: https://gerrit.osmocom.org/c/osmo-pcu/+/25056/4/src/tbf_ul_ass_fsm.h#32
Related: https://gerrit.osmocom.org/c/osmo-msc/+/25076/1/src/libmsc/msc_a.c#125
Related: OS#5087
Change-Id: I88fd86ac550fddb3017aeceb647c3d9e75367372
 2021-07-30 10:11:11 +02:00
Oliver Smith dc66e9a394 lint: exclude kdf, milenage for libosmocore 
Imported code that doesn't follow our guidelines (e.g. spaces used
instead of tabs).

Related: OS#5087
Change-Id: Iccf59d66f35ede9710258faf9d4257584214bb17
 2021-07-19 14:39:43 +02:00
Oliver Smith 7f0fdda23c lint: ignore PREFER_DEFINED_ATTRIBUTE_MACRO 
Don't complain that macros such as __packed should be used, which are
defined in the Linux kernel but not in libosmocore.

For example:
src/gsm/gsm0808.c:85: WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))

Related: OS#5087
Change-Id: I2bf3b7d60e99cf91f7b619af54167a11cdfae8c6
 2021-07-15 10:21:47 +02:00
Oliver Smith 7c3c0bdaa5 lint: ignore DEEP_INDENTATION 
Related: OS#5087
Change-Id: Iff29f0a97dbfed904705f543541441f761370602
 2021-07-15 10:21:47 +02:00
Oliver Smith 972e8bcbb0 lint: ignore PREFER_FALLTHROUGH 
Related: OS#5087
Change-Id: I373a231cf08fd23312ad9a85d8e2855a736e331a
 2021-07-15 10:21:47 +02:00
Oliver Smith 5409188d55 lint: ignore LINE_CONTINUATIONS 
Causes false positives, e.g. in tests/mgcp/mgcp_test.c in osmo-mgw:

  #define MDCX4_PT2 \
	"MDCX 18983218 1@mgw MGCP 1.0\r\n" \
	"M: sendrecv\r" \
	"C: 2\r\n" \
	"I: %s\r\n" \
	"L: p:20-20, a:AMR, nt:IN\r\n" \
	...

tests/mgcp/mgcp_test.c:189: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations

Related: OS#5087
Change-Id: I8d8004f2a8ef926588487187af7cdef8254c7248
 2021-07-07 11:28:38 +02:00
Oliver Smith 2cceff4535 lint: ignore COMPLEX_MACRO 
Complains about, for example:
  #define MDCX4 \
	"MDCX 18983217 1@mgw MGCP 1.0\r\n" \
	"M: sendrecv\r" \
	"C: 2\r\n" \
	"I: %s\r\n" \
	"L: p:20, a:AMR, nt:IN\r\n" \
	"\n" \
	"v=0\r\n" \
	"o=- %s 23 IN IP4 5.6.7.8\r\n" \
	"c=IN IP4 5.6.7.8\r\n" \
	"t=0 0\r\n" \
	"m=audio 4441 RTP/AVP 99\r\n" \
	"a=rtpmap:99 AMR/8000\r\n" \
	"a=ptime:40\r\n"

Related: OS#5087
Change-Id: Ic9d752ca841161a62e3631c84b4237a0d8594363
 2021-07-07 11:28:38 +02:00
Oliver Smith 497ce6743a lint: exclude *.ok, *.err 
Complains about e.g. \r\n in *.ok files.

Related: OS#5087
Change-Id: I79004cec3e2eb753951a7f886318ac0db4ea2c06
 2021-07-07 11:28:37 +02:00
Oliver Smith 57804faacc lint: checkpatch.pl: exclude pattern, not dir 
Allow to exclude files in a follow-up commit, not just directories.

Related: OS#5087
Change-Id: Ic3990fba60060c331c479174183924b9cdbdb4c8
 2021-07-07 11:28:16 +02:00
Oliver Smith 1e750ed6dc lint/checkpatch: add Osmocom specific wrapper 
Related: OS#5087
Change-Id: I0ec6a3bc57a4d31c821fa83370f05c6d4ac2a5b0
 2021-06-16 16:42:18 +02:00