mirror of https://gerrit.osmocom.org/osmo-ci
Update patch set 7
Patch Set 7: Code-Review-1 (12 comments) thanks for working on this! Here is some more review... Patch-set: 7 Label: Code-Review=-1
This commit is contained in:
Neels Hofmeyr
Gerrit Code Review
parent
73de7f5448
commit
a45b13f46c
|
|
@ -0,0 +1,208 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_2fc71e14",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 23,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "This is an example for building \u003cinsert project name\u003e which depends on \u003ca\u003e, \u003cb\u003e, \u003cc\u003e",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_4fcc6236",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 28,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "More and better docs. It is absolutely crucial that anyone who may take over jenkins maintenance can easily understand this. e.g.\n\n Pass all required dependencies to a command given in $1.\n Collect the output of these calls and concatenate, separated with underscores.\n The result is an artifact file name used to store in/retrieve from the artifact store.\n\n $1 may be one of these commands:\n\n - osmo-build-dep.sh: build a source tree\n - getFoo: frobnicate zagnomodes\n - getMoo: instacube labnitudes\n\n The arguments passed to these are:\n \n - PARALLEL_MAKE as environment variable, passed to \u0027make\u0027\n - arg 1: the git repository name, gets places in a git.osmocom.org URL.\n - arg 2: optional: ...\n - arg 3: optional: ...",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_ef4d16c6",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 43,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "(rather put this on top like above)",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_0f4b3ab1",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 49,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "like what. cd foo? ./configure \u0026\u0026 make install?",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_6fd126cd",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 55,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "let\u0027s have what this script needs right at the top",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_8fd64ac4",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 82,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "comment: \"jenkins should check out the git tree of the project to be built in the workspace root.\" (this probably near the top of this file) and here \"obtain the project name from the git clone found in the workspace root\"",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_afda2ee7",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 86,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "what does this do?",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_cfd772be",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 130,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "locally? remotely?",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_efe436ae",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 163,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "you\u0027re lacking the root reason: we want to atomically move an artifact into place avoiding half-written files.",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_0fe25a9f",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 171,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "hmm, we might still have a GC problem here. If another job tries to use this artifact and this job is removing it? -- that depends on whether we retrieve the artifact \"atomically\"...",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_6fe8467d",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 187,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "add comment:\n\n # extract the artifact directly from the artifact store.\n # If another job run were to remove the artifact while we\u0027re doing this,\n # we trust that \u0027tar\u0027 will keep the file open and thus we are allowed \n # to read to the end before the file is discarded by the OS.\n\nAnd about the GC problem above: the most waterproof way of avoiding is to probe whether the artifact exists *by* doing a copy/untar. If it succeeds, we have it. If not, rebuild. In case we first query and decide, then copy, some other job run may have removed in the meantime?\n\nHow likely is this to happen? What would it take? concurrent jenkins job builds of different versions of the same repos? (so far we have concurrent builds disabled mostly for cosmetic reasons)",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_4ff38273",
|
||||
"filename": "scripts/osmo-build.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 193,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-05-19T11:24:25Z",
|
||||
"side": 1,
|
||||
"message": "rename to \u0027logArtifactHashes\u0027",
|
||||
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue