mirror of https://gerrit.osmocom.org/osmo-ci
Update patch set 2
Patch Set 2: Code-Review+1 (1 comment) There is a benefit in avoiding code dup, but there is also a benefit in having a plain self-contained script and less code complexity. I would be fine with the minimal amount of copy-paste we have, but ok. What users do you have in mind? osmo-bts.git or others as well? Patch-set: 2 Label: Code-Review=+1
This commit is contained in:
parent
51587ea5e8
commit
5d7334bf3f
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa98f980_6f8d9b31",
|
||||
"filename": "scripts/osmo-layer1-headers.sh",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 28,
|
||||
"author": {
|
||||
"id": 1000005
|
||||
},
|
||||
"writtenOn": "2017-06-13T12:17:30Z",
|
||||
"side": 1,
|
||||
"message": "unless we already have such model that does not require headers, IMHO this should rather exit 1",
|
||||
"revId": "2cbd5370bf372d1232c3bad7624a8701d57ebf39",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue