osmocom
/
osmo-ci
mirror of https://gerrit.osmocom.org/osmo-ci
10
0
Fork 1
Code Releases Activity

Update patch set 7 

Patch Set 7:

(3 comments)

some replies...

Patch-set: 7
This commit is contained in:
Neels Hofmeyr 2017-05-23 11:54:30 +00:00 committed by Gerrit Code Review
parent c4059de5ef
commit 580f562780
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4
View File

@ -155,6 +155,24 @@
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "fa98f980_cd95ba89",
"filename": "scripts/osmo-build.sh",
"patchSetId": 7
},
"lineNbr": 86,
"author": {
"id": 1000005
},
"writtenOn": "2017-05-23T11:54:30Z",
"side": 1,
"message": "Ah, this is a bash-ism that I don\u0027t know. My personal preference would be to stay with /bin/sh bounds ... fine then.\n\nAren\u0027t \u0027#\u0027 in file names rather unusual, given that they are comment delimiters? how about underscores, double-underscores or maybe a comma?",
"parentUuid": "fa98f980_ef2ef6a4",
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "fa98f980_cfd772be",
@ -260,6 +278,24 @@
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "fa98f980_ed927e9e",
"filename": "scripts/osmo-build.sh",
"patchSetId": 7
},
"lineNbr": 171,
"author": {
"id": 1000005
},
"writtenOn": "2017-05-23T11:54:30Z",
"side": 1,
"message": "there\u0027s also the parallel matrix builds? do they each have a separate artifact store? If they share, builds of the same matrix may GC away artifacts the other has just built, or something in that line.",
"parentUuid": "fa98f980_3226a5bb",
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "fa98f980_6fe8467d",
@ -295,6 +331,24 @@
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "fa98f980_2d8d667c",
"filename": "scripts/osmo-build.sh",
"patchSetId": 7
},
"lineNbr": 187,
"author": {
"id": 1000005
},
"writtenOn": "2017-05-23T11:54:30Z",
"side": 1,
"message": "let\u0027s try to keep the algorithm completely timing-free, i.e. do not rely on x amount of time having passed. Atomicity should suffice, right?",
"parentUuid": "fa98f980_522b2982",
"revId": "1cffc0714cf1e807e7eb3f4923bb812b7fc97ba4",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326",
"unresolved": false
},
{
"key": {
"uuid": "fa98f980_4ff38273",