osmo-ci/scripts/obs/lib/rpm_spec.py

85 lines
2.9 KiB
Python
Raw Permalink Normal View History

scripts/obs: rewrite pushing source pkgs to OBS Harald requested that the OBS scripts should not stop if building one specific source package fails, instead it should keep going and report at the end a non-success exit code. Given that the shell script code has historically grown and became hard to maintain, I decided to rewrite the scripts for implementing this feature. This rewrite solves additional problems: * No full checkout of an OBS project like network:osmocom:latest anymore, with lots of packages that won't get updated (e.g. the uhd package has a uhd-images_3.14.1.1.tar.xz file that is 108 MB). With the old code, developers had to wait minutes during the checkout before the script reaches code that is currently being developed. Now only single packages get checked out right before they get updated. * No need to clone git repositories over and over. With the new code, git repos only get cloned if needed (for latest it is not needed if the remote git tag is the same as the version in OBS). During development, the cloned git repositories are cached. * Output from commands like "git tag -l" is not written to the log unless they failed. This makes the log more readable, which is especially important when a package fails to build, we keep going and need to spot the build error in the middle of the log later on. * No more duplicated code for nightly and latest scripts that worked similar but had slight differences. Also the list of packages is not duplicated for nightly and latest anymore; nightly uses all packages and latest uses packages that have at least one git tag. * Building source packages is decoupled from uploading them. A separate script build_srcpkg.py can be used to just build the deb + rpm spec source packages, without interacting with the OBS server. * The scripts can optionally run in docker with a command-line switch, and this is used by jenkins. This way we don't need to install more dependencies on the host such as rebar3 which is now needed for erlang/osmo_dia2gsup. * Add erlang/osmo_dia2gsup and run its generate_build_dep.sh (SYS#6006) I have done the new implementation in python to make use of argparse and to be able to use try/except and print a trace when building one package fails. Example output: * https://jenkins.osmocom.org/jenkins/job/Osmocom_OBS_nightly_obs.osmocom.org/48/console * https://jenkins.osmocom.org/jenkins/job/Osmocom_OBS_latest_obs.osmocom.org/46/console Change-Id: I45a555d05a9da808c0fe0145aae665f583cb80d9
2022-07-13 10:50:21 +00:00
#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-2.0-or-later
# Copyright 2022 sysmocom - s.f.m.c. GmbH <info@sysmocom.de>
import glob
import os
import shutil
import lib
import lib.git
def get_spec_in_path(project):
repo_path = lib.git.get_repo_path(project)
ret = glob.glob(f"{repo_path}/**/contrib/*.spec.in", recursive=True)
assert len(ret) < 2
return ret[0] if ret else None
def get_source_name(project):
""" Get the name to the .tar.xz file generated by dpkg-buildpackage, that
we also use in the rpm spec file. This requires
lib.debian.move_files_to_output() to run first."""
path_output = lib.get_output_path(project)
ret = glob.glob(f"{path_output}/*.tar.*")
assert len(ret) == 1
return os.path.basename(ret[0])
def add_depend(project, pkgname, version):
""" Add a 'Requires: ...' line below the 'Name:' and '%package' lines of
the .spec.in file.
:param pkgname: of the meta-package to depend on (e.g. osmocom-nightly)
:param version: of the meta-pkgname to depend on or None """
path = get_spec_in_path(project)
req_line = f"Requires: {pkgname}"
if version:
req_line += f" = {version}"
# Main package
lib.run_cmd(["sed", "-e", "/^Name:/a\\", "-e", req_line, "-i", path])
# Subpackages
lib.run_cmd(["sed", "-e", "/^%package/a\\", "-e", req_line, "-i", path])
def generate(project, version, epoch):
""" Update the version and source in the .spec.in file.
:param version: from get-version-gen script """
print(f"{project}: generating rpm spec file")
path = get_spec_in_path(project)
source = get_source_name(project)
# rpmbuild doesn't allow '-' in version
version = version.replace("-", ".")
# Version
lib.run_cmd(["sed", f"s/^Version:.*/Version: {version}/", "-i", path])
if epoch:
epoch_line = f"Epoch: {epoch}"
lib.run_cmd(["sed", "-e", "/^Version:/a\\", "-e", epoch_line, "-i",
path])
# Source: add the one generated by dpkg-buildpackage and another line with
# rpmlintrc
lib.run_cmd(["sed", f"s/^Source:.*/Source: {source}/", "-i", path])
rpmlint_line = "Source1: rpmlintrc"
lib.run_cmd(["sed", "-e", "/^Source:/a\\", "-e", rpmlint_line, "-i", path])
# rpmbuild assumes the directory inside the source tarball has the version
# at the end, but dpkg-buildpackage doesn't generate it that way. Set the
# directory with "%setup -n dirname".
lib.run_cmd(["sed", f"s/^%setup/%setup -n {os.path.basename(project)}/",
"-i", path])
def copy_to_output(project):
# rpm spec
path_spec_in = get_spec_in_path(project)
path_output = lib.get_output_path(project)
name_spec = os.path.basename(path_spec_in)[:-3] # remove '.in'
shutil.copy(path_spec_in, f"{path_output}/{name_spec}")
# rpmlintrc
shutil.copy(f"{lib.config.path_top}/data/rpmlintrc", path_output)