mirror of https://gerrit.osmocom.org/libosmocore
39 lines
1.3 KiB
Plaintext
39 lines
1.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "080a74c8_81648439",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-04-27T14:10:26Z",
|
|
"side": 1,
|
|
"message": "while I agree the function is now easier to read, the truth is you are adding 212 modulus operations (hence 212 division operations) every time this function is called.\nNot sure if this is really worth it, specially since this may be called lots of times. I\u0027d like others to comment on this.",
|
|
"revId": "663d36c62db79e5e8fd4505aacd60356167bd190",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "4c68e9d5_041ff04a",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000161
|
|
},
|
|
"writtenOn": "2022-04-27T14:20:45Z",
|
|
"side": 1,
|
|
"message": "You\u0027re doing a bit-wise comparison of 212 conescutive bits, instead of just memcmping a few bytes, the % isn\u0027t the issue here...",
|
|
"parentUuid": "080a74c8_81648439",
|
|
"revId": "663d36c62db79e5e8fd4505aacd60356167bd190",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |