osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity
libosmocore/tests
History
Pau Espin dab4db0217 gsm: kasumi: Fix dynamic-stack-buffer-overflow on out buffers not multiple of 64 bits 
Fixes following AddressSanitizer report during gea_test run with gcc
8.1.0:

==8899==ERROR: AddressSanitizer: dynamic-stack-buffer-overflow on address 0x7ffc5f1719bb at pc 0x7fe574adc5fe bp 0x7ffc5f171460 sp 0x7ffc5f171450
WRITE of size 1 at 0x7ffc5f1719bb thread T0
    #0 0x7fe574adc5fd in osmo_store64be_ext ../../include/osmocom/core/bit64gen.h:75
    #1 0x7fe574adc649 in osmo_store64be ../../include/osmocom/core/bit64gen.h:104
    #2 0x7fe574ade936 in _kasumi_kgcore libosmocore/src/gsm/kasumi.c:186
    #3 0x7fe574ae2532 in gea4 libosmocore/src/gsm/gea.c:44
    #4 0x7fe574ae266c in gea3 libosmocore/src/gsm/gea.c:60
    #5 0x7fe574a9b616 in gprs_cipher_run libosmocore/src/gsm/gprs_cipher_core.c:95
    #6 0x56422d3fb2ee in test_gea libosmocore/tests/gea/gea_test.c:29
    #7 0x56422d3fb506 in main libosmocore/tests/gea/gea_test.c:49
    #8 0x7fe5730f406a in __libc_start_main (/usr/lib/libc.so.6+0x2306a)
    #9 0x56422d3fadf9 in _start (libosmocore/tests/gea/.libs/lt-gea_test+0x1df9)

The kasumi_test is updated to calculate the entire array of bits
according to expected result. Before this commit it worked by writing
the entire last 64bit block, and addressSanitizer cannot catch it
because the allocated buffer is 64bit aligned too.

Change-Id: I7b2a0224a3b5527d5a3ad7e17efc73081b63eac1
 		2018-05-17 12:13:04 +02:00
..
a5 tests: a5_test: Print wrong buffer correctly on error 2018-05-16 21:13:58 +02:00
abis use osmo_init_logging2() with proper talloc ctx 2018-04-06 04:37:50 +02:00
auth milenage_test: cosmetic: verify AUTS in comments 2017-03-15 13:46:58 +00:00
bits tests: bitrev_test: Fix dynamic-stack-buffer-overflow 2018-05-16 17:10:33 +02:00
bitvec Add function to get uninterrupted bit run 2017-01-06 10:37:42 +00:00
codec libosmocodec: implement ECU (Error Concealment Unit) for FR 2018-01-15 20:12:03 +00:00
coding coding: Add BER-reporting RACH decode functions 2018-02-26 12:26:38 +01:00
comp128 tests: test actual support status for auth. algo 2016-06-29 16:33:40 +00:00
conv Add functions for extended RACH coding 2017-12-11 10:36:47 +00:00
ctrl fix ctrl_test sanitizer issues 2018-04-05 18:23:45 +02:00
endian introduce byteswap.h with osmo_{htonl,ntohl,htons,ntohs} 2017-05-15 13:42:00 +02:00
fr license: Fix the license to GPL 2017-12-09 13:03:29 +00:00
fsm add osmo_fsm_inst_update_id_f() 2018-04-09 17:57:15 +02:00
gb use osmo_init_logging2() with proper talloc ctx 2018-04-06 04:37:50 +02:00
gea tests: gea_test: Use correct max size for key in buffer 2018-05-16 20:09:39 +02:00
gprs use osmo_init_logging2() with proper talloc ctx 2018-04-06 04:37:50 +02:00
gsm0408 gsm0408_test: add test cases for MNC with leading zeros 2018-02-28 19:26:43 +01:00
gsm0808 gsm0808_test: silence deprecation: use gsm0808_create_layer3_2() 2018-04-23 08:42:00 +00:00
gsm23003 fix osmo_mnc_from_str(): don't try to parse NULL 2018-03-05 04:27:40 +01:00
gsup use osmo_init_logging2() with proper talloc ctx 2018-04-06 04:37:50 +02:00
kasumi gsm: kasumi: Fix dynamic-stack-buffer-overflow on out buffers not multiple of 64 bits 2018-05-17 12:13:04 +02:00
lapd RSL/LAPDm: Not all RLL message are "transparent" 2018-04-19 15:09:32 +00:00
logging license: Fix the license to GPL 2017-12-09 13:03:29 +00:00
loggingrb license: Fix the license to GPL 2017-12-09 13:03:29 +00:00
msgb use osmo_init_logging2() with proper talloc ctx 2018-04-06 04:37:50 +02:00
msgfile build: resolve compiler warning about implicit delcaration 2014-10-04 11:49:23 +02:00
oap use osmo_init_logging2() with proper talloc ctx 2018-04-06 04:37:50 +02:00
osmo-auc-gen umts aka: add sqn_ms out-param, print SQN.MS in osmo-auc-gen 2017-08-29 12:46:46 +00:00
prbs Add pseudo-random bit sequence generator to libosmcoore 2017-07-10 23:42:02 +02:00
sercomm Embedded: add sercomm stubs 2018-01-21 19:08:05 +00:00
sim sim: Fix compiler warning and by this fixing the test result 2016-03-21 11:29:16 +01:00
sms use osmo_init_logging2() with proper talloc ctx 2018-04-06 04:37:50 +02:00
smscb test: Fix compiler warnings on 64bit systems 2015-11-09 16:46:03 +00:00
socket use osmo_init_logging2() with proper talloc ctx 2018-04-06 04:37:50 +02:00
stats rate_ctr: fix osmo-sgsn DoS: don't return NULL on already used index 2017-12-20 01:29:59 +01:00
strrb Fix/Update copyright notices; Add SPDX annotation 2017-11-13 01:35:12 +09:00
timer timer: Introduce osmo_clock_gettime to override clock_gettime 2018-03-01 12:33:02 +00:00
tlv add tlv_parse2(), capable of multiple instances of the same IE 2018-04-13 05:28:09 +02:00
ussd use osmo_init_logging2() with proper talloc ctx 2018-04-06 04:37:50 +02:00
utils add osmo_quote_str(),osmo_quote_str_buf() and test 2018-04-09 15:56:14 +00:00
vty use osmo_init_logging2() with proper talloc ctx 2018-04-06 04:37:50 +02:00
write_queue wqueue: Reject messges if queue is considered full 2016-12-09 11:37:37 +01:00
Makefile.am configure: Check separately for lib implementing dlopen and dlsym 2018-05-04 19:25:16 +02:00
atlocal.in build: make check: disable sim_test when built with --disable-pcsc 2016-11-16 16:40:44 +00:00
libsercomstub.c Embedded: add sercomm stubs 2018-01-21 19:08:05 +00:00
testsuite.at timer: Introduce osmo_clock_gettime to override clock_gettime 2018-03-01 12:33:02 +00:00