mirror of https://gerrit.osmocom.org/libosmocore
Harald Welte
6176b6e092
This was actually discovered by the following compiler warning in gcc-6.2.0: CC gprs_bssgp_bss.lo gprs_bssgp_bss.c: In function ‘bssgp_rx_paging’: gprs_bssgp_bss.c:544:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if (TLVP_PRESENT(&tp, BSSGP_IE_TMSI) && ^~ gprs_bssgp_bss.c:548:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’ *(pinfo->ptmsi) = ntohl(*(uint32_t *) ^ This is an actual bug. If we recevied a BSSGP Paging Request without P-TMSI, we might crash or report some random memory as P-TMSI to the caller in the output data structure. Change-Id: Ib4f307827cd7cccc91c1415a6fb5428d7cf8416d |
||
---|---|---|
.. | ||
Makefile.am | ||
common_vty.c | ||
common_vty.h | ||
gprs_bssgp.c | ||
gprs_bssgp_bss.c | ||
gprs_bssgp_util.c | ||
gprs_bssgp_vty.c | ||
gprs_ns.c | ||
gprs_ns_frgre.c | ||
gprs_ns_vty.c | ||
libosmogb.map |