mirror of https://gerrit.osmocom.org/libosmocore
73 lines
2.5 KiB
Plaintext
73 lines
2.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "aba8b9ee_4bb094a1",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000028
|
|
},
|
|
"writtenOn": "2022-10-31T14:03:18Z",
|
|
"side": 1,
|
|
"message": "Its important to click \"done\" when an a comment is resolved.",
|
|
"revId": "0d9b6b0e31f2d608c9ac18a861a905a94b978702",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "3a5704ef_0cfeddb4",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000229
|
|
},
|
|
"writtenOn": "2022-11-01T11:13:15Z",
|
|
"side": 1,
|
|
"message": "Hmm I thought I had done that. Did I not? Edit: Ah I see now... I had, but it was stuck in draft mode.",
|
|
"parentUuid": "aba8b9ee_4bb094a1",
|
|
"revId": "0d9b6b0e31f2d608c9ac18a861a905a94b978702",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "da414e13_186d878d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2022-11-01T13:08:48Z",
|
|
"side": 1,
|
|
"message": "I tend to ignore the gerrit \"Done\" stuff as much as i can. it is possible to vote and merge a patch without clicking \"Done\" on all comments. I guess it is intended as a helpful feature but i\u0027m not feeling it.\n\n(Particularly, i find the UI to check-mark a number of N separate comments as \"Done\" really annoying.\nNot all comments mean that something needs to be done. The magic that implicitly marks things as done / undone is sometimes leading to wrong markings. Or a patch owner marks things as Done without actually having addressed the comment. So i do not let that tick mark UI hog my attention.)",
|
|
"revId": "0d9b6b0e31f2d608c9ac18a861a905a94b978702",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "19693a1e_e6e5fb73",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 4
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000229
|
|
},
|
|
"writtenOn": "2022-11-01T14:37:29Z",
|
|
"side": 1,
|
|
"message": "Two CR+1\u0027s",
|
|
"revId": "0d9b6b0e31f2d608c9ac18a861a905a94b978702",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |