mirror of https://gerrit.osmocom.org/libosmocore
110 lines
3.8 KiB
Plaintext
110 lines
3.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4a943b4d_d23c5bdb",
|
|
"filename": "include/osmocom/core/osmo_io.h",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 17,
|
|
"author": {
|
|
"id": 1000008
|
|
},
|
|
"writtenOn": "2023-11-20T14:02:56Z",
|
|
"side": 1,
|
|
"message": "Maybe only define it if it is not defined?\nI assume the definitions are identical?",
|
|
"revId": "effc3bad398e43220412258af2d9ae123d2e1257",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f5fce2a7_95092f31",
|
|
"filename": "include/osmocom/core/osmo_io.h",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 17,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2024-02-20T08:07:00Z",
|
|
"side": 1,
|
|
"message": "not sure it would help. both old and new definition would have to have an #ifndef block - and normally I\u0027d assume the lower level #include (osmo_io.h) to come before any higher-level #include (libosmo-netif) so we\u0027d be the first one.",
|
|
"parentUuid": "4a943b4d_d23c5bdb",
|
|
"revId": "effc3bad398e43220412258af2d9ae123d2e1257",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c5e72766_e3dd5ce1",
|
|
"filename": "src/core/osmo_io_internal.h",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 1000008
|
|
},
|
|
"writtenOn": "2023-11-20T14:02:56Z",
|
|
"side": 1,
|
|
"message": "Either `#ifdef HAVE_LIBSCTP` this and other code (we already have support in configure) or only include linux/sctp.h which contains `struct sctp_sndrcvinfo`.\nI guess for portability we should check for HAVE_LIBSCTP?",
|
|
"revId": "effc3bad398e43220412258af2d9ae123d2e1257",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8f12394c_9f18aa1a",
|
|
"filename": "src/core/osmo_io_internal.h",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2023-11-21T16:33:31Z",
|
|
"side": 1,
|
|
"message": "Ok, so this is where it becomes a bit ugly. Technically speaking, we do not use any libsctp API and do not need to link it, so I thought HAVE_LIBSCTP would be wrong. But then, *if* we need definitions from netinet/sctp.h, we still need to depend on that library as it actually is installed by libsctp-dev.. So I\u0027ll have to check if we can include some kernel headers directly (and not depend on libsctp presence) or I\u0027ll have to add the #ifdef...",
|
|
"parentUuid": "c5e72766_e3dd5ce1",
|
|
"revId": "effc3bad398e43220412258af2d9ae123d2e1257",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "eafa464a_9b8c3ef2",
|
|
"filename": "src/core/osmo_io_internal.h",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-11-27T16:47:28Z",
|
|
"side": 1,
|
|
"message": "Agree to do \"if HAVE_LIBSCTP\" here.",
|
|
"parentUuid": "8f12394c_9f18aa1a",
|
|
"revId": "effc3bad398e43220412258af2d9ae123d2e1257",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2cce0515_46f26155",
|
|
"filename": "src/core/osmo_io_internal.h",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 7,
|
|
"author": {
|
|
"id": 1000231
|
|
},
|
|
"writtenOn": "2024-02-22T15:04:16Z",
|
|
"side": 1,
|
|
"message": "I added #ifdef HAVE_LIBSCTP.",
|
|
"parentUuid": "eafa464a_9b8c3ef2",
|
|
"revId": "effc3bad398e43220412258af2d9ae123d2e1257",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |