mirror of https://gerrit.osmocom.org/libosmocore
74 lines
2.1 KiB
Plaintext
74 lines
2.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b05dfe78_4ee5ae36",
|
|
"filename": "include/osmocom/gsm/gsup.h",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 412,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-02-22T15:47:08Z",
|
|
"side": 1,
|
|
"message": "#define OSMO_GSUP_MAX_PCO_LEN 251\nuint8_t\t\t\tpco[OSMO_GSUP_MAX_PCO_LEN];",
|
|
"revId": "b07c086cab468531ca81b49b6bdf2eabcfb98605",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "e26cd044_1de27933",
|
|
"filename": "include/osmocom/gsm/gsup.h",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 412,
|
|
"author": {
|
|
"id": 1000015
|
|
},
|
|
"writtenOn": "2024-02-22T16:03:44Z",
|
|
"side": 1,
|
|
"message": "Should I check for the PCO lenght? I would keep the pointer+length as we do it in most cases in the gsup structure when handling with flexible optional data.",
|
|
"parentUuid": "b05dfe78_4ee5ae36",
|
|
"revId": "b07c086cab468531ca81b49b6bdf2eabcfb98605",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a89bfc8b_a32296d6",
|
|
"filename": "include/osmocom/gsm/gsup.h",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 412,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-02-27T12:33:26Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "e26cd044_1de27933",
|
|
"revId": "b07c086cab468531ca81b49b6bdf2eabcfb98605",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "1843b3cc_d3377d8c",
|
|
"filename": "src/gsm/gsup.c",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 881,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2024-02-27T12:33:26Z",
|
|
"side": 1,
|
|
"message": "Yeah I think we can check for pco_len \u003c\u003d 251 here.",
|
|
"revId": "b07c086cab468531ca81b49b6bdf2eabcfb98605",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |