mirror of https://gerrit.osmocom.org/libosmocore
57 lines
1.9 KiB
Plaintext
57 lines
1.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e9e47478_fd291340",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2022-10-19T21:02:57Z",
|
|
"side": 1,
|
|
"message": "looks awfully specific and I don\u0027t think this exists in upstream (linux kernel) but if you think there are sufficient number of users for it, go ahead.",
|
|
"revId": "8f23dfa9148967b232ac46318f981aaad01d0d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "fc6c523c_918379fa",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-20T12:21:44Z",
|
|
"side": 1,
|
|
"message": "I agree with Harald. Not sure if adding this one will make us shoot on our own foot.",
|
|
"parentUuid": "e9e47478_fd291340",
|
|
"revId": "8f23dfa9148967b232ac46318f981aaad01d0d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8c72f3f5_7140b7cf",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000015
|
|
},
|
|
"writtenOn": "2022-10-27T20:35:58Z",
|
|
"side": 1,
|
|
"message": "Ok. Any ideas how to improve?\n\nI dislike initializing llist \"entries\" by pointing it to itself. This should be only done for llist \"heads\".\nWhat is the correct value for an llist \"entry\" which isn\u0027t part of a queue?\nShould it be NULL? Should it be POISON1/2? Should it be something else?",
|
|
"parentUuid": "fc6c523c_918379fa",
|
|
"revId": "8f23dfa9148967b232ac46318f981aaad01d0d84",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |