mirror of https://gerrit.osmocom.org/libosmocore
125 lines
3.7 KiB
Plaintext
125 lines
3.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "8f28a2f7_8f218681",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 17,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-09-27T09:11:56Z",
|
|
"side": 1,
|
|
"message": "\"gsm0808_sc_cfg_amr_modes\" or \"gsm0808_sc_cfg_mr_modes\" would be far more descriptive.",
|
|
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "520d94d2_9b90c19d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2022-09-26T10:39:54Z",
|
|
"side": 1,
|
|
"message": "(only pushed again to resolve the bogus \"merge conflict\" that gerrit indicated)",
|
|
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "4372a7cb_f8e4a287",
|
|
"filename": "include/osmocom/gsm/protocol/gsm_04_08.h",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 627,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-09-27T09:11:56Z",
|
|
"side": 1,
|
|
"message": "can you better add a union with a field containing the whole octet in the struct gsm48_multi_rate_conf?",
|
|
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a93337f0_892ab592",
|
|
"filename": "src/gsm/gsm0808_utils.c",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 1612,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-09-27T09:11:56Z",
|
|
"side": 1,
|
|
"message": "can it happen that s_modes is 0 here?",
|
|
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "fffb715d_f470169e",
|
|
"filename": "src/gsm/gsm0808_utils.c",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 1612,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2022-10-26T22:31:53Z",
|
|
"side": 1,
|
|
"message": "it is possible, for example some modes are disabled for HR,\nand some are completely disabled for GSM.\nThis check makes sure we don\u0027t set an S bit when s_modes is empty.",
|
|
"parentUuid": "a93337f0_892ab592",
|
|
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "32e5b546_7f94f885",
|
|
"filename": "src/gsm/gsm0808_utils.c",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 1635,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-09-27T09:11:56Z",
|
|
"side": 1,
|
|
"message": "don\u0027t you need to \"s15_s0 \u0026 (1\u003c\u003cs_bit)\" here?",
|
|
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3706a808_7492bb4c",
|
|
"filename": "src/gsm/gsm0808_utils.c",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 1635,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2022-10-26T22:31:53Z",
|
|
"side": 1,
|
|
"message": "thanks, nice catch.",
|
|
"parentUuid": "32e5b546_7f94f885",
|
|
"revId": "24ec86496b5089567798bd3bdeb698fbfd726bee",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |