mirror of https://gerrit.osmocom.org/libosmocore
72 lines
2.1 KiB
Plaintext
72 lines
2.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f7429ff9_33d45a66",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2022-09-27T14:25:19Z",
|
|
"side": 1,
|
|
"message": "agreeing with pau on the value_string. It may sound expensive, but then string-formatting is not our main task, and we can avoid any out-of-bounds array overflows when going the value_string route.",
|
|
"revId": "16afb9eca8dc05a0b2c34b90b1c1d54cf9d56e7d",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "653a74c0_ad86fdbc",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2022-10-27T10:45:32Z",
|
|
"side": 1,
|
|
"message": "ping? would be great to get the review incorporated to get the patch merged",
|
|
"revId": "16afb9eca8dc05a0b2c34b90b1c1d54cf9d56e7d",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "7fb075fb_b6ea3b10",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000005
|
|
},
|
|
"writtenOn": "2022-10-28T19:08:50Z",
|
|
"side": 1,
|
|
"message": "pong, my focus is currently on osmo-msc\u0027s side of codecs.\nThis patch closely relates to that \"[RFC]\" patch, would make sense to submit them together.",
|
|
"revId": "16afb9eca8dc05a0b2c34b90b1c1d54cf9d56e7d",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2ed6b2a5_0183f265",
|
|
"filename": "src/gsm/gsm0808.c",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 2056,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-09-27T08:58:34Z",
|
|
"side": 1,
|
|
"message": "value_string?",
|
|
"revId": "16afb9eca8dc05a0b2c34b90b1c1d54cf9d56e7d",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |