libosmocore/21c7c59d02398b7d7b25c4fe46c...

127 lines
3.5 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "463735eb_d6ed06e0",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2024-02-20T08:07:40Z",
"side": 1,
"message": "HAVE_LIBSCTP still missing",
"revId": "21c7c59d02398b7d7b25c4fe46c56fc2551e9224",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "59ac1aa7_65250aff",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 1000231
},
"writtenOn": "2024-02-22T15:04:16Z",
"side": 1,
"message": "Done",
"parentUuid": "463735eb_d6ed06e0",
"revId": "21c7c59d02398b7d7b25c4fe46c56fc2551e9224",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "6dc045ca_618bbad1",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 7
},
"lineNbr": 0,
"author": {
"id": 1000231
},
"writtenOn": "2024-02-22T15:05:37Z",
"side": 1,
"message": "This will be fixed in a different patch for easier review.",
"parentUuid": "59ac1aa7_65250aff",
"revId": "21c7c59d02398b7d7b25c4fe46c56fc2551e9224",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "02a2f193_7dc49848",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 7
},
"lineNbr": 340,
"author": {
"id": 1000008
},
"writtenOn": "2024-02-20T08:49:44Z",
"side": 1,
"message": "If I understand correctly in https://gerrit.osmocom.org/c/libosmocore/+/35910\n\nYou don\u0027t use this code path (for SCTP) anymore, because it doesn\u0027t work? In that case just remove the code here.",
"revId": "21c7c59d02398b7d7b25c4fe46c56fc2551e9224",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "44a62e95_9a8dead4",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 7
},
"lineNbr": 340,
"author": {
"id": 1000231
},
"writtenOn": "2024-02-22T15:04:16Z",
"side": 1,
"message": "Yes, it is not required, so I removed it.",
"parentUuid": "02a2f193_7dc49848",
"revId": "21c7c59d02398b7d7b25c4fe46c56fc2551e9224",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "c54ecc94_d9e617ef",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 7
},
"lineNbr": 369,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-20T10:11:33Z",
"side": 1,
"message": "else {}",
"revId": "21c7c59d02398b7d7b25c4fe46c56fc2551e9224",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "35ef9dc6_68f87ed7",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 7
},
"lineNbr": 369,
"author": {
"id": 1000231
},
"writtenOn": "2024-02-22T15:04:16Z",
"side": 1,
"message": "Done",
"parentUuid": "c54ecc94_d9e617ef",
"revId": "21c7c59d02398b7d7b25c4fe46c56fc2551e9224",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}