mirror of https://gerrit.osmocom.org/libosmocore
57 lines
2.1 KiB
Plaintext
57 lines
2.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "796ca169_1064e352",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2024-02-09T15:39:35Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t understand why this is needed. Isn\u0027t it actually the case that both the io_uring and the poll backend are going to use the same mechanism (poll based) for non-blocking connect, rather than differnt ones?\n\nSo IMHO it should be the opposite way: the handling should be in the common layer and no new callbacks (breaking API/ABI) needed.",
|
|
"revId": "968e17b46a0c2702385e778bb5b1e6d6007cb6bc",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a273dc8d_7161e722",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000231
|
|
},
|
|
"writtenOn": "2024-02-16T16:15:58Z",
|
|
"side": 1,
|
|
"message": "osmo_io_uring.c handles the connect notification request differently: (in a later patch)\n\nIt need to check that write or read is not enabled yet.\n\nIt registers a special callback function that detects write (socket connected) or read (socket failed). This special function will then enable pending read/write.\n\nYes, it breaks the API/ABI, but in\u0027t that API used only internally within libosmocore?",
|
|
"parentUuid": "796ca169_1064e352",
|
|
"revId": "968e17b46a0c2702385e778bb5b1e6d6007cb6bc",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ef889122_de921dfb",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000004
|
|
},
|
|
"writtenOn": "2024-02-20T07:59:34Z",
|
|
"side": 1,
|
|
"message": "Ack",
|
|
"parentUuid": "a273dc8d_7161e722",
|
|
"revId": "968e17b46a0c2702385e778bb5b1e6d6007cb6bc",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |