mirror of https://gerrit.osmocom.org/libosmocore
57 lines
2.2 KiB
Plaintext
57 lines
2.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "521d4da5_2329b463",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-12T13:27:21Z",
|
|
"side": 1,
|
|
"message": "I wonder why do we need an extra API for that. Cannot we improve the implementation of the existing API?",
|
|
"revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2cfb0f8d_9aefe3c1",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000159
|
|
},
|
|
"writtenOn": "2022-10-13T17:59:10Z",
|
|
"side": 1,
|
|
"message": "It\u0027s more consistent with existing multiaddr API: we already have separate functions like osmo_sock_init2_multiaddr() instead of trying to bundle everything into osmo_sock_init*(). Also I think proper place for \"universal\" API is libosmo-netif which will use the added function as a buildiing block. I\u0027ll update https://gerrit.osmocom.org/c/libosmo-netif/+/29079 once this one is merged.",
|
|
"parentUuid": "521d4da5_2329b463",
|
|
"revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "c69ed5fd_b4b969c3",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 14
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2022-10-13T18:34:09Z",
|
|
"side": 1,
|
|
"message": "osmo_sock_init2_multiaddr was needed because the previous API didn\u0027t allow for passing such parameters, so it could not be reused.\nI don\u0027t see why it is the case for this API.\nIf you reuse the same API the caller, usch as libosmo-netif patch you shared, doesn\u0027t need to care and we don\u0027t need to update it.",
|
|
"parentUuid": "2cfb0f8d_9aefe3c1",
|
|
"revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |