libosmocore/f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "521d4da5_2329b463",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 14
      },
      "lineNbr": 0,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2022-10-12T13:27:21Z",
      "side": 1,
      "message": "I wonder why do we need an extra API for that. Cannot we improve the implementation of the existing API?",
      "revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "2cfb0f8d_9aefe3c1",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 14
      },
      "lineNbr": 0,
      "author": {
        "id": 1000159
      },
      "writtenOn": "2022-10-13T17:59:10Z",
      "side": 1,
      "message": "It\u0027s more consistent with existing multiaddr API: we already have separate functions like osmo_sock_init2_multiaddr() instead of trying to bundle everything into osmo_sock_init*(). Also I think proper place for \"universal\" API is libosmo-netif which will use the added function as a buildiing block. I\u0027ll update https://gerrit.osmocom.org/c/libosmo-netif/+/29079 once this one is merged.",
      "parentUuid": "521d4da5_2329b463",
      "revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "c69ed5fd_b4b969c3",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 14
      },
      "lineNbr": 0,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2022-10-13T18:34:09Z",
      "side": 1,
      "message": "osmo_sock_init2_multiaddr was needed because the previous API didn\u0027t allow for passing such parameters, so it could not be reused.\nI don\u0027t see why it is the case for this API.\nIf you reuse the same API the caller, usch as libosmo-netif patch you shared, doesn\u0027t need to care and we don\u0027t need to update it.",
      "parentUuid": "2cfb0f8d_9aefe3c1",
      "revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "7ade0721_656d0b97",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 14
      },
      "lineNbr": 0,
      "author": {
        "id": 1000159
      },
      "writtenOn": "2022-10-14T12:10:57Z",
      "side": 1,
      "message": "I don\u0027t see any advantage in stuffing everything in a single function - just unnecessary code complications. I find current approach to be easier to understand and maintain.",
      "parentUuid": "c69ed5fd_b4b969c3",
      "revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "35f6057d_3e8873e8",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 14
      },
      "lineNbr": 0,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2022-10-14T12:21:04Z",
      "side": 1,
      "message": "That\u0027s precisely the point. You want to spare difficulties for you while implenting this feature at the expense of having others having to look at which API to use based on the type of socket.\nI disagree with the approach, unless proper reasonings are provided.",
      "parentUuid": "7ade0721_656d0b97",
      "revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "5de7f148_0a6a01a3",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 14
      },
      "lineNbr": 0,
      "author": {
        "id": 1000159
      },
      "writtenOn": "2022-10-14T12:34:52Z",
      "side": 1,
      "message": "No, having clearly separated parts reduces overall complexity and makes code easier to follow and use. Your approach implies piling up unrelated code together which makes it more complex - which I think requires justification which I hadn\u0027t seen so far.",
      "parentUuid": "35f6057d_3e8873e8",
      "revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "2bde2e6f_279c45de",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 14
      },
      "lineNbr": 0,
      "author": {
        "id": 1000074
      },
      "writtenOn": "2022-10-14T13:48:08Z",
      "side": 1,
      "message": "Let\u0027s see what others thing about it.",
      "parentUuid": "5de7f148_0a6a01a3",
      "revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
    }
  ]
}