Sylvain Munaut
71fd42fede
gsm/gsm48_ie: Fix Range 256 format decoding
...
From the mail:
---
appended is another patch for fixing a bug in the calculation of the
frequency lists. This time the patch is for the "Range 256 format".
The problem is that the operand for the "smod" operation might be
negative, in this case the simplified version won't work as expected.
In the patch I introduced a separate function for "smod" which takes
care of the sign. I have not yet checked if the other formats are also
affected, this would be the case if the "smod" operand can be negative.
There might be other solutions to fix the problem without the need
for a separate function, however I have not thought further about it.
A test vector is the following frequency list ("Range 256 format",
first byte is the length):
09 8b 1c 83 8c 15 ef 02 2d 30
The correct ARFCNs are
569 571 576 578 586 608 712 715 719
The uncorrected version would instead return:
444 457 460 464 569 576 578 586 608
This means four ARFCNs are wrong which will cause problems if for
example the frequency list contains the ARFCNs for hopping.
----
Written-by: Dieter Spaar <spaar@mirider.augusta.de>
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2011-09-01 22:05:29 +02:00
Christoph Fritz
ab7c9c766b
logging: include stdarg.h for va_list
...
fixes tiny compile error:
CC socket.lo
In file included from socket.c:13:
../include/osmocom/core/logging.h:31: error: expected declaration
specifiers or ‘...’ before ‘va_list’
make[3]: *** [socket.lo] Error 1
2011-09-01 17:44:35 +02:00
Harald Welte
712691d8d8
add functions for bit-reversal
...
Sometimes we need stuff like reversing every bit in each byte (but not
the byte-order).
2011-09-01 14:47:31 +02:00
Harald Welte
36c5a3e285
logging: add osmo_vlogp() as vararg / va_list compatible function
2011-08-31 19:40:03 +02:00
Harald Welte
d38c8b88d7
doxygen: Add main page for all three libraries
2011-08-30 11:32:56 +02:00
Holger Hans Peter Freyther
c2c0ad7832
signal: Fix compiler warning about signedness of constant
...
Use the u suffix to mark the constant as unsiged integer.
This fixes:
warning: this decimal constant is unsigned only in ISO C90
2011-08-22 15:31:17 +02:00
Harald Welte
924b04072f
update .gitignore with Doxyfile.core
2011-08-20 17:40:13 +02:00
Harald Welte
429d2e454d
add script to generate http://www.osmocom.org/doc tree structure
2011-08-20 17:40:08 +02:00
Harald Welte
47945f0a8b
Make sure 'make distclean' works for doxygen
2011-08-20 17:40:04 +02:00
Harald Welte
c7859edf51
consistent Doxyfile naming
2011-08-20 17:39:58 +02:00
Harald Welte
09b4c2275e
update makefile.am to support out-of-tree builds
...
Conflicts:
Makefile.am
2011-08-20 17:39:45 +02:00
Harald Welte
086fe32234
bssgp: make comments more explicit, include 'Rx' in received messages
2011-08-19 16:45:19 +02:00
Harald Welte
cbf443ca72
Merge branch 'master' of git.osmocom.org:openbsc
2011-08-19 16:44:00 +02:00
Harald Welte
be145198df
doxygen: document some more structure members for RSL
2011-08-18 11:45:18 +02:00
Harald Welte
02624d2743
doxygen automake integration: make sure the 'doc' directory exists
2011-08-17 19:41:49 +02:00
Harald Welte
7992af0180
doxygen: fix correct use of doc/core subdirectory
2011-08-17 19:37:26 +02:00
Harald Welte
01dfad85f8
update .gitignore
2011-08-17 19:35:25 +02:00
Harald Welte
21e73c2597
Integrate doxygen documentation building into autoconf/automake process
2011-08-17 19:33:06 +02:00
Harald Welte
500c7ceffd
don't keep autotools-generated Doxyfiles around
2011-08-17 19:32:46 +02:00
Harald Welte
49e1056cca
Auto-generate the version information of Doxygen documentation
2011-08-17 19:22:12 +02:00
Harald Welte
4e777c300f
doxygen: Add documentation for Abis OML
2011-08-17 19:15:24 +02:00
Harald Welte
e881b1b9eb
doxygen: split VTY configuration in multiple files
2011-08-17 18:52:30 +02:00
Harald Welte
8f2c7e5b2b
RSL: add doxygen documentation
2011-08-17 18:52:21 +02:00
Harald Welte
789f02e158
Add doxygen configuration for libosmocodec
2011-08-17 18:35:05 +02:00
Harald Welte
fa9fbe77ba
doxygen: make sure the right C source files are included
2011-08-17 18:34:45 +02:00
Harald Welte
2272589fef
Split doxygen configuration to create separate gsm/vty/core docs
2011-08-17 18:26:51 +02:00
Harald Welte
6bdf0b158c
doxygen: Add documentation for LAPDm code
2011-08-17 18:22:08 +02:00
Harald Welte
57c7d37059
doxygen: Add documentation about TLV parser
2011-08-17 17:50:55 +02:00
Harald Welte
f416c097db
Fix version number in Doxyfile (0.3.5)
...
We need a way to automatically generate this from git tags in the
future...
2011-08-17 17:15:02 +02:00
Harald Welte
7acb30c69b
doxygen: Add (partial) VTY API documentation
2011-08-17 17:14:12 +02:00
Harald Welte
47379ca95b
doxygen: Add documentation for gsmtap_util.[ch]
2011-08-17 17:14:12 +02:00
Harald Welte
af8e4352b5
doxygen: Add documentation to signal.[ch]
2011-08-17 17:14:12 +02:00
Harald Welte
eee3790d24
doxygen: Add documentation for prim.h
2011-08-17 17:14:12 +02:00
Harald Welte
a523d14096
doxygen: document panic.[ch]
2011-08-17 17:14:12 +02:00
Harald Welte
9327c6dc0f
doxygen: Add docs for rate_ctr
2011-08-17 17:14:12 +02:00
Harald Welte
2777ecd987
doxygen: Add 'write_queue' module
2011-08-17 17:14:12 +02:00
Harald Welte
8598f1866e
doxygen: add doxygen module 'utils'
2011-08-17 17:14:12 +02:00
Harald Welte
18fc465b7f
doxygen documentation for logging framework
2011-08-17 17:14:12 +02:00
Harald Welte
ba6988bd89
some more doxygen work (include the notion of modules)
2011-08-17 17:14:11 +02:00
Harald Welte
03bba4313f
start to add doxygen documentation to libosmocore headers
2011-08-17 17:14:11 +02:00
Harald Welte
bd598e3c5e
start to add doxygen documentation to libosmocore headers
2011-08-16 23:26:52 +02:00
Pablo Neira Ayuso
300e78d3e5
logging: fix parsing of logging mask (-d DMI case)
...
Without this patch, `-d DMI' enables logging for DMI and DMIB.
Signed-off-by: Pablo Neira Ayuso <pablo@gnumonks.org>
2011-08-11 14:33:16 +02:00
Harald Welte
e581516b26
Merge branch 'master' of git.osmocom.org:libosmocore
2011-08-02 14:22:30 +02:00
Harald Welte
eeb78dde9b
add new 'osmo-arfcn' program to compute frequency based on arfcn
...
The freq -> arfcn side still needs to be implemented.
2011-08-02 13:44:54 +02:00
Andreas.Eversberg
1a99df84e1
gsm/gsm48_ie: Fix frequency list decoding
...
Fix-by: Andreas.Eversberg <jolly@eversberg.eu>
Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2011-07-30 20:27:40 +02:00
Harald Welte
2af435986f
fix off-by-one error in OSMO_NUM_DLIB
...
This bug was introduced in 95f7eb288c
and
it caused a segfault on 'write terminal'
2011-07-29 15:12:41 +02:00
Harald Welte
bf21a4fef5
Merge branch 'master' of git.osmocom.org:openbsc
2011-07-29 11:44:28 +02:00
Harald Welte
087e1136eb
use the 'L' prefix in debug names (DLINP instead of DINP)
2011-07-29 11:43:39 +02:00
Harald Welte
430be84994
add definition of OSMO_MIN macro, similar to OSMO_MAX
2011-07-27 23:28:41 +02:00
Holger Hans Peter Freyther
7e1a622124
sms: Fix style issues with the code, add spaces after keywords
2011-07-24 20:17:00 +02:00