osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1: Code-Review+1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, f79387a28c65c06f4f4643c9a41dd7fa986f50f3
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000074 2024-02-23 19:55:18 +00:00 committed by Gerrit Code Review
parent 77b67d95d4
commit faa12cea27
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
a12d625353f09c445539536b21ed01c3cdecae38 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "3c07305a_ad1f92bd",
"filename": "include/osmocom/core/osmo_io.h",
"patchSetId": 1
},
"lineNbr": 112,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-23T19:55:18Z",
"side": 1,
"message": "It may make more sense to return a \"const struct osmo_io_ops*\" so that no copy is needed by default. This also means the struct is not allocated by the user, which may be an advantage if the struct size changes?\nNot a strong opinion though, just raising the topic.",
"revId": "a12d625353f09c445539536b21ed01c3cdecae38",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}