osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity

Update patch set 4 

Patch Set 4:

(3 comments)

Patch-set: 4
CC: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Attention: {"person_ident":"Gerrit User 1000231 \u003c1000231@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000074\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000074 2024-02-20 10:27:53 +00:00 committed by Gerrit Code Review
parent e1e5c2ff2b
commit f95a08f47a
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
23b1158bf17c25485b5425743d5948b8ae9c9779 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "6e1903f0_dfe8c37c",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 4
},
"lineNbr": 199,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-20T10:27:53Z",
"side": 1,
"message": "to send",
"revId": "23b1158bf17c25485b5425743d5948b8ae9c9779",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "cd22fe2e_01046fff",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 4
},
"lineNbr": 201,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-20T10:27:53Z",
"side": 1,
"message": "\"(which in turn frees this msghdr, if still attached) and frees the msghdr\".\nyou are repeating yourself here?",
"revId": "23b1158bf17c25485b5425743d5948b8ae9c9779",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "4f084d16_4f109c36",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 4
},
"lineNbr": 210,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-20T10:27:53Z",
"side": 1,
"message": "where does the second free happen? in iofd_uring_submit_tx?",
"revId": "23b1158bf17c25485b5425743d5948b8ae9c9779",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}