mirror of https://gerrit.osmocom.org/libosmocore
Update patch set 3
Patch Set 3: (1 comment) Patch-set: 3 CC: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
This commit is contained in:
parent
adf9926e3c
commit
f67bcfa039
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "8247f8a8_a7130cfc",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1000074
|
||||
},
|
||||
"writtenOn": "2022-10-28T10:32:02Z",
|
||||
"side": 1,
|
||||
"message": "IMHO this causes even more difficulties to understand FSM code (both the FSM implementation and users of the FSM) by having to look at yet another place for flow of events.\n\nI think it\u0027s totally fine having to add the possible events on each state, it helps understanding what may be possible by readers who look at it.\nLogging incorrect events sent at a given point is also good, because it allows learning that some scenarios are also possible and need to be taken into account.\n\nSo my opinion right now is that I see no need for this change. Other feel free to provide their own opinion on the topic.",
|
||||
"revId": "80a6e351e5f15d81ad00682c0a862c02bc223bc0",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue