osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000015\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000015 \u003c1000015@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000015\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000015 2024-02-22 16:03:44 +00:00 committed by Gerrit Code Review
parent 92acd3a767
commit efdd151ab7
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
b07c086cab468531ca81b49b6bdf2eabcfb98605
View File

@ -16,6 +16,24 @@
"message": "#define OSMO_GSUP_MAX_PCO_LEN 251\nuint8_t\t\t\tpco[OSMO_GSUP_MAX_PCO_LEN];",
"revId": "b07c086cab468531ca81b49b6bdf2eabcfb98605",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "e26cd044_1de27933",
"filename": "include/osmocom/gsm/gsup.h",
"patchSetId": 3
},
"lineNbr": 412,
"author": {
"id": 1000015
},
"writtenOn": "2024-02-22T16:03:44Z",
"side": 1,
"message": "Should I check for the PCO lenght? I would keep the pointer+length as we do it in most cases in the gsup structure when handling with flexible optional data.",
"parentUuid": "b05dfe78_4ee5ae36",
"revId": "b07c086cab468531ca81b49b6bdf2eabcfb98605",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}