osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000161 \u003c1000161@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000161\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000161\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000161 2024-01-11 18:27:54 +00:00 committed by Gerrit Code Review
parent 01d039943d
commit ec589b1c91
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
320471ca85f752f99344656a6ff90b665da8a2cb
View File

@ -70,6 +70,30 @@
},
"revId": "320471ca85f752f99344656a6ff90b665da8a2cb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "6f5c6ff1_033c8328",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 11,
"author": {
"id": 1000161
},
"writtenOn": "2024-01-11T18:27:54Z",
"side": 1,
"message": "But that promise is impossible to keep because that means 11 year old test code that checks the number of talloc chunks makes it impossible to change any related code because our memory layout is fixed forever and it would stop building any time the chunk number changes...\n\nTest code can\u0027t be part of that promise and I am surprised to hear that this is apparently the case.",
"parentUuid": "764b4dc6_4d9edc4b",
"range": {
"startLine": 11,
"startChar": 19,
"endLine": 11,
"endChar": 40
},
"revId": "320471ca85f752f99344656a6ff90b665da8a2cb",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}