osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity

Update patch set 2 

Patch Set 2: Code-Review-1

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=-1, 15e08657355045eb4f58c926d05502e3328434c5
This commit is contained in:
Gerrit User 1000074 2024-02-20 10:07:36 +00:00 committed by Gerrit Code Review
parent 027ece1795
commit d42cbd1036
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
03ea3d206cb4fee39d3b64558037e2ac26123561 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "8648f276_ad8ac1e3",
"filename": "src/core/osmo_io_poll.c",
"patchSetId": 2
},
"lineNbr": 115,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-20T10:07:36Z",
"side": 1,
"message": "This is expensive!!!\nSee how osmo_fd_register() doesn\u0027t call osmo_fd_is_registered unless \"--enable-ofd-check\" is passed for debugging purposes.",
"revId": "03ea3d206cb4fee39d3b64558037e2ac26123561",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "fc25a509_79b0d19f",
"filename": "src/core/osmo_io_poll.c",
"patchSetId": 2
},
"lineNbr": 125,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-20T10:07:36Z",
"side": 1,
"message": "This is expensive!!!\nSee how osmo_fd_register() doesn\u0027t call osmo_fd_is_registered unless \"--enable-ofd-check\" is passed for debugging purposes.",
"revId": "03ea3d206cb4fee39d3b64558037e2ac26123561",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}