osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
14
0
Fork 1
Code Issues Releases Wiki Activity

Update patch set 4 

Patch Set 4: Code-Review+1

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 1000161 <1000161@035e6965-6537-41bd-912c-053f3cf69326>
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Reviewer: Gerrit User 1000011 <1000011@035e6965-6537-41bd-912c-053f3cf69326>
Reviewer: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 1000161 \u003c1000161@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
Attention: {"person_ident":"Gerrit User 1000011 \u003c1000011@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"pespin replied on the change"}
This commit is contained in:
Gerrit User 1000074 2022-04-27 14:10:26 +00:00 committed by Gerrit Code Review
parent 28db862082
commit d0eb4449e7
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
663d36c62db79e5e8fd4505aacd60356167bd190 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "080a74c8_81648439",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 1000074
},
"writtenOn": "2022-04-27T14:10:26Z",
"side": 1,
"message": "while I agree the function is now easier to read, the truth is you are adding 212 modulus operations (hence 212 division operations) every time this function is called.\nNot sure if this is really worth it, specially since this may be called lots of times. I\u0027d like others to comment on this.",
"revId": "663d36c62db79e5e8fd4505aacd60356167bd190",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}