osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity

Update patch set 4 

Patch Set 4:

(4 comments)

Patch-set: 4
CC: Gerrit User 1000074 <1000074@035e6965-6537-41bd-912c-053f3cf69326>
This commit is contained in:
Gerrit User 1000074 2024-02-20 10:19:45 +00:00 committed by Gerrit Code Review
parent e1a642ee0a
commit c25437627a
1 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
57eba3bfbc4ff52bc08b657d79137be99e3f7a79
View File

@ -1,5 +1,56 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "62900f2c_f007201e",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 4
},
"lineNbr": 327,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-20T10:19:45Z",
"side": 1,
"message": "Again this is expensive! Should be removed (or conditionally enabled through ifdef).",
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "0b38f7db_8c1db15b",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 4
},
"lineNbr": 341,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-20T10:19:45Z",
"side": 1,
"message": "Again this is expensive! Should be removed (or conditionally enabled through ifdef).",
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "6ebeb0dc_70109e55",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 4
},
"lineNbr": 398,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-20T10:19:45Z",
"side": 1,
"message": "Again this is expensive! Should be removed (or conditionally enabled through ifdef).",
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
@ -16,6 +67,23 @@
"message": "Couldn\u0027t this also contain the first actual data read after connecting (e.g. the socket is both readable and writable)?\nIf so the comment should reflect that.",
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "cd75808a_4abffff4",
"filename": "src/core/osmo_io_uring.c",
"patchSetId": 4
},
"lineNbr": 498,
"author": {
"id": 1000074
},
"writtenOn": "2024-02-20T10:19:45Z",
"side": 1,
"message": "I am not sure this is correct. According to man2 connect, the way to go is:\n\"\"\"\n The socket is nonblocking and the connection cannot be completed immediately. (UNIX domain sockets failed with EAGAIN instead.) It is pos‐\n sible to select(2) or poll(2) for completion by selecting the socket for writing. After select(2) indicates writability, use getsockopt(2)\n to read the SO_ERROR option at level SOL_SOCKET to determine whether connect() completed successfully (SO_ERROR is zero) or unsuccessfully\n (SO_ERROR is one of the usual error codes listed here, explaining the reason for the failure).\n\"\"\"\n\nI don\u0027t see anywhere the mention of \"fd becoming readable\" as you said.\nSeems you should be checking the SO_ERROR instead?",
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}