mirror of https://gerrit.osmocom.org/libosmocore
Update patch set 5
Patch Set 5:
(5 comments)
Patch-set: 5
Attention: {"person_ident":"Gerrit User 1000231 \u003c1000231@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000231\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000231\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000008 \u003c1000008@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000231\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000231
Gerrit Code Review
parent
9a200db4b2
commit
bb0693c2c2
|
|
@ -17,6 +17,24 @@
|
|||
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e20d8aba_b6f8e318",
|
||||
"filename": "src/core/osmo_io_uring.c",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 327,
|
||||
"author": {
|
||||
"id": 1000231
|
||||
},
|
||||
"writtenOn": "2024-02-22T10:00:14Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "62900f2c_f007201e",
|
||||
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -34,6 +52,24 @@
|
|||
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "55d39734_396ee78c",
|
||||
"filename": "src/core/osmo_io_uring.c",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 341,
|
||||
"author": {
|
||||
"id": 1000231
|
||||
},
|
||||
"writtenOn": "2024-02-22T10:00:14Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "0b38f7db_8c1db15b",
|
||||
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -51,6 +87,24 @@
|
|||
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e133d13d_9d2543aa",
|
||||
"filename": "src/core/osmo_io_uring.c",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 398,
|
||||
"author": {
|
||||
"id": 1000231
|
||||
},
|
||||
"writtenOn": "2024-02-22T10:00:14Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "6ebeb0dc_70109e55",
|
||||
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -68,6 +122,24 @@
|
|||
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "e4c73d86_6c93f43f",
|
||||
"filename": "src/core/osmo_io_uring.c",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 437,
|
||||
"author": {
|
||||
"id": 1000231
|
||||
},
|
||||
"writtenOn": "2024-02-22T10:00:14Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "083278b8_b5c2f696",
|
||||
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -84,6 +156,24 @@
|
|||
"message": "I am not sure this is correct. According to man2 connect, the way to go is:\n\"\"\"\n The socket is nonblocking and the connection cannot be completed immediately. (UNIX domain sockets failed with EAGAIN instead.) It is pos‐\n sible to select(2) or poll(2) for completion by selecting the socket for writing. After select(2) indicates writability, use getsockopt(2)\n to read the SO_ERROR option at level SOL_SOCKET to determine whether connect() completed successfully (SO_ERROR is zero) or unsuccessfully\n (SO_ERROR is one of the usual error codes listed here, explaining the reason for the failure).\n\"\"\"\n\nI don\u0027t see anywhere the mention of \"fd becoming readable\" as you said.\nSeems you should be checking the SO_ERROR instead?",
|
||||
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "7147d84f_75708d2f",
|
||||
"filename": "src/core/osmo_io_uring.c",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 498,
|
||||
"author": {
|
||||
"id": 1000231
|
||||
},
|
||||
"writtenOn": "2024-02-22T10:00:14Z",
|
||||
"side": 1,
|
||||
"message": "In case of an error (connection failed), both read and write events become available. I did some tests that showed that clearly. Now I removed the read event from the patch. An additional getsockopt() is not required here. This is done by stream_cli already and should be done by any other user.",
|
||||
"parentUuid": "cd75808a_4abffff4",
|
||||
"revId": "57eba3bfbc4ff52bc08b657d79137be99e3f7a79",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue