osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity

Update patch set 4 

Patch Set 4:

(2 comments)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000008\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000008 \u003c1000008@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000008\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000008 2023-12-01 10:05:01 +00:00 committed by Gerrit Code Review
parent 304e122fdb
commit 5dcb76280c
2 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
1e977e90302919fccbacace5cf155f9c75e06c00
View File

@ -140,6 +140,24 @@
"message": "this code should also work with the union present?",
"revId": "1e977e90302919fccbacace5cf155f9c75e06c00",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "813d11cc_3e337a84",
"filename": "src/core/osmo_io.c",
"patchSetId": 4
},
"lineNbr": 391,
"author": {
"id": 1000008
},
"writtenOn": "2023-12-01T10:05:01Z",
"side": 1,
"message": "It \"works\" in the sense that it even returns true if mode \u003d\u003d *_READ_WRITE and .recvfrom_cb (or the other way around) is set since both function pointers are sharing the same memory location.",
"parentUuid": "2d9f5f19_5048d303",
"revId": "1e977e90302919fccbacace5cf155f9c75e06c00",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}

18
ce0501bf2be08c91721f1428bd613402915dbca8
View File

@ -52,6 +52,24 @@
"parentUuid": "504ea742_ce7737fb",
"revId": "ce0501bf2be08c91721f1428bd613402915dbca8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "1bcca390_cafaad48",
"filename": "src/core/osmo_io.c",
"patchSetId": 3
},
"lineNbr": 546,
"author": {
"id": 1000008
},
"writtenOn": "2023-12-01T10:05:01Z",
"side": 0,
"message": "This fix is only necessary after removing the union. I don\u0027t see how you could realize checking the exact member with the union in place. I can basically stick an \n```c\nOSMO_ASSERT(\u0026iofd-\u003eio_ops.read_cb \u003d\u003d \u0026iofd-\u003eio_ops.recvfrom_cb)\n```\nin here. Unless I\u0027m missing something this is exactly the feature of the union, afterwards you can\u0027t know whether this memory location was set as read_cb or recvfrom_cb.",
"parentUuid": "4be00890_58bf8718",
"revId": "ce0501bf2be08c91721f1428bd613402915dbca8",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}