osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

coding: Always initialize bit counters in gsm0503_pdtch_egprs_decode(). 

Previsouly there were a lot of valid code paths which returned from the function
before setting bit counters which led to bogus BER output in osmo-bts-trx logs
when those code paths were hit.

Change-Id: I4722cae3794ccbb12001113c991d9cf345a52a96
This commit is contained in:
Alexander Chemeris 2018-07-14 21:07:27 +02:00 committed by Ivan Kluchnikov
parent 9444326158
commit 50f7d74fca
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/coding/gsm0503_coding.c
View File

@ -938,6 +938,11 @@ int gsm0503_pdtch_egprs_decode(uint8_t *l2_data, const sbit_t *bursts, uint16_t
struct egprs_cps cps;
union gprs_rlc_ul_hdr_egprs *hdr;
if (n_errors)
*n_errors = 0;
if (n_bits_total)
*n_bits_total = 0;
if ((nbits != GSM0503_GPRS_BURSTS_NBITS) &&
(nbits != GSM0503_EGPRS_BURSTS_NBITS)) {
/* Invalid EGPRS bit length */