osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity

Update patch set 7 

Patch Set 7: Code-Review+1

(1 comment)

This change is ready for review.

Patch-set: 7
Reviewer: Gerrit User 1000004 <1000004@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 0fb39eba1fc38433a8524024b7c47269af0b049b
Work-in-progress: false
Attention: {"person_ident":"Gerrit User 1000231 \u003c1000231@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000229 \u003c1000229@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000008 \u003c1000008@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000004 2024-02-20 08:07:00 +00:00 committed by Gerrit Code Review
parent 7a4a038b0f
commit 2ea1ba5f3c
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
effc3bad398e43220412258af2d9ae123d2e1257
View File

@ -17,6 +17,24 @@
"revId": "effc3bad398e43220412258af2d9ae123d2e1257",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "f5fce2a7_95092f31",
"filename": "include/osmocom/core/osmo_io.h",
"patchSetId": 1
},
"lineNbr": 17,
"author": {
"id": 1000004
},
"writtenOn": "2024-02-20T08:07:00Z",
"side": 1,
"message": "not sure it would help. both old and new definition would have to have an #ifndef block - and normally I\u0027d assume the lower level #include (osmo_io.h) to come before any higher-level #include (libosmo-netif) so we\u0027d be the first one.",
"parentUuid": "4a943b4d_d23c5bdb",
"revId": "effc3bad398e43220412258af2d9ae123d2e1257",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {