osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 14 

Patch Set 14:

(1 comment)

Patch-set: 14
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"Max replied on the change"}
Attention: {"person_ident":"Gerrit User 1000159 \u003c1000159@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"Max replied on the change"}
This commit is contained in:
Gerrit User 1000159 2022-10-14 12:34:52 +00:00 committed by Gerrit Code Review
parent 7a4e50f1a1
commit 28c91b8e04
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043
View File

@ -88,6 +88,24 @@
"parentUuid": "7ade0721_656d0b97",
"revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "5de7f148_0a6a01a3",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 14
},
"lineNbr": 0,
"author": {
"id": 1000159
},
"writtenOn": "2022-10-14T12:34:52Z",
"side": 1,
"message": "No, having clearly separated parts reduces overall complexity and makes code easier to follow and use. Your approach implies piling up unrelated code together which makes it more complex - which I think requires justification which I hadn\u0027t seen so far.",
"parentUuid": "35f6057d_3e8873e8",
"revId": "f953abdda3a8fae0ffd1e96f7dd9c2bc1ec08043",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}