osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 1000004 \u003c1000004@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000004 2024-02-23 17:07:24 +00:00 committed by Gerrit Code Review
parent c38ee09873
commit 25a9f3da62
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
fd51d62ce603a5fdac87b84b33a951d689b18056
View File

@ -16,6 +16,24 @@
"message": "I think I already provided my opinion on this previously, I see no need to change it to struct, but if others feel more secure doing that, I won\u0027t oppose.",
"revId": "fd51d62ce603a5fdac87b84b33a951d689b18056",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "520c8169_77ddc131",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000004
},
"writtenOn": "2024-02-23T17:07:24Z",
"side": 1,
"message": "I would say over half of the problems in this patchset I saw the last few days were related to this being a union. Now those have been resolved, but I see potential for more of those problems in the future. So better be safe than to optimize for 4-5 * sizeof(unsigned long). If we really need to conserve memory, struct osmo_io_fd should simply point to the io_ops, rather than copying it into each and every osmo_fd.",
"parentUuid": "dc6b2fe1_98a45532",
"revId": "fd51d62ce603a5fdac87b84b33a951d689b18056",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}