Update patch set 1

Patch Set 1:

(2 comments)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 1000005 \u003c1000005@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000005\u003e replied on the change"}

7a34a27d707c1357aa7a70d1d90d2c59d4a23fa4

@@ -40,6 +40,30 @@
       "revId": "7a34a27d707c1357aa7a70d1d90d2c59d4a23fa4",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "abd53216_0a83c47e",
+        "filename": "src/core/logging.c",
+        "patchSetId": 1
+      },
+      "lineNbr": 432,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2024-04-10T02:44:35Z",
+      "side": 1,
+      "message": "TL;DR: I\u0027ll move it to a private header.\n\nrambling on in case you\u0027re interested:\n\nit ended up this way because\n- intended for private API use only, i\u0027d have liked it to be static, as the commit log explains.\n- at the very heart of the logging subsystem and should rather be lean.\n- When looking at the callers, it is clear that it\u0027s correct.\n\nYet I did think about it quite a bit:\n\nwe actually do have negative categories, the DL* ones.\nso i did ask myself, should it convert from one to the other?\n\nBut:\nIt is called only in places where the idx is already checked,\nand the local variable at all the callers is an int...\n\nSo maybe in future it should be able to convert a negative category?\nConsidering these back and forth I ended up at \"good enough compromise, not important enough to bother\"...\n\nBut your remark makes me reconsider, I guess it should be less public?",
+      "parentUuid": "6194be9b_913cbcc2",
+      "range": {
+        "startLine": 432,
+        "startChar": 61,
+        "endLine": 432,
+        "endChar": 72
+      },
+      "revId": "7a34a27d707c1357aa7a70d1d90d2c59d4a23fa4",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
     {
       "unresolved": true,
       "key": {
@@ -56,6 +80,24 @@
       "message": "add `OSMO_ASSERT(cat_idx \u003c log_info-\u003enum_cat)`?",
       "revId": "7a34a27d707c1357aa7a70d1d90d2c59d4a23fa4",
       "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "eb8fbfce_23f8762d",
+        "filename": "src/core/logging.c",
+        "patchSetId": 1
+      },
+      "lineNbr": 434,
+      "author": {
+        "id": 1000005
+      },
+      "writtenOn": "2024-04-10T02:44:35Z",
+      "side": 1,
+      "message": "(as above)",
+      "parentUuid": "2b5f6379_831a452e",
+      "revId": "7a34a27d707c1357aa7a70d1d90d2c59d4a23fa4",
+      "serverId": "035e6965-6537-41bd-912c-053f3cf69326"
     }
   ]
 }