osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 4 

Patch Set 4: Code-Review+1

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 1000028 <1000028@035e6965-6537-41bd-912c-053f3cf69326>
Label: Code-Review=+1, 2e5e23cb52e923398818deb31ea3712cedcffd71
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000028\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000028 2024-02-27 15:01:03 +00:00 committed by Gerrit Code Review
parent a2ad57ac0f
commit 0acdcd79d7
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
b07c086cab468531ca81b49b6bdf2eabcfb98605
View File

@ -69,6 +69,24 @@
"message": "Yeah I think we can check for pco_len \u003c\u003d 251 here.",
"revId": "b07c086cab468531ca81b49b6bdf2eabcfb98605",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "1d3519b6_217b34ec",
"filename": "src/gsm/gsup.c",
"patchSetId": 3
},
"lineNbr": 881,
"author": {
"id": 1000028
},
"writtenOn": "2024-02-27T15:01:03Z",
"side": 1,
"message": "I think also that this makes sense. (I am not aware of this, in case the length is something the API user has to set consciously, then an OSMO_ASSERT might also make sense.)",
"parentUuid": "1843b3cc_d3377d8c",
"revId": "b07c086cab468531ca81b49b6bdf2eabcfb98605",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}