osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity
libosmocore/src/gb/gprs_bssgp.c

1440 lines
43 KiB
C
Raw Normal View History

doxygen: unify use of \file across the board Considering the various styles and implications found in the sources, edit scores of files to follow the same API doc guidelines around the doxygen grouping and the \file tag. Many files now show a short description in the generated API doc that was so far only available as C comment. The guidelines and reasoning behind it is documented at https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_API_documentation In some instances, remove file comments and add to the corresponding group instead, to be shared among several files (e.g. bitvec). Change-Id: Ifa70e77e90462b5eb2b0457c70fd25275910c72b
2017-06-20 02:35:06 +00:00
/*! \file gprs_bssgp.c
* GPRS BSSGP protocol implementation as per 3GPP TS 08.18. */
/*
* (C) 2009-2017 by Harald Welte <laforge@gnumonks.org>
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
*
* All Rights Reserved
*
Fix/Update copyright notices; Add SPDX annotation Let's fix some erroneous/accidential references to wrong license, update copyright information where applicable and introduce a SPDX-License-Identifier to all files. Change-Id: I39af26c6aaaf5c926966391f6565fc5936be21af
2017-11-12 16:00:26 +00:00
* SPDX-License-Identifier: GPL-2.0+
*
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
* This program is free software; you can redistribute it and/or modify
Change license of libosmogb from AGPLv3+ to GPLv2+ The copyright holders Harald Welte, Holger Freyther, Andreas Eversberg and sysmocom - s.f.m.c. GmbH (represented by Holger and Harald) agree that the license of libosmogb should be GPLv2+ and not AGPLv3+. The reason the source files stated AGPLv3+ is due to the history, as they were moved from OpenBSC to libosmocore at the time we needed to use them from osmo-pcu. It was an oversight back then to not re-license them accordingly.
2014-10-26 19:33:09 +00:00
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
Change license of libosmogb from AGPLv3+ to GPLv2+ The copyright holders Harald Welte, Holger Freyther, Andreas Eversberg and sysmocom - s.f.m.c. GmbH (represented by Holger and Harald) agree that the license of libosmogb should be GPLv2+ and not AGPLv3+. The reason the source files stated AGPLv3+ is due to the history, as they were moved from OpenBSC to libosmocore at the time we needed to use them from osmo-pcu. It was an oversight back then to not re-license them accordingly.
2014-10-26 19:33:09 +00:00
* GNU General Public License for more details.
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
*
Change license of libosmogb from AGPLv3+ to GPLv2+ The copyright holders Harald Welte, Holger Freyther, Andreas Eversberg and sysmocom - s.f.m.c. GmbH (represented by Holger and Harald) agree that the license of libosmogb should be GPLv2+ and not AGPLv3+. The reason the source files stated AGPLv3+ is due to the history, as they were moved from OpenBSC to libosmocore at the time we needed to use them from osmo-pcu. It was an oversight back then to not re-license them accordingly.
2014-10-26 19:33:09 +00:00
* You should have received a copy of the GNU General Public License
License change: We are now AGPLv3+ instead of GPLv2+ The reason for this is quite simple: We want to make sure anyone running a customized version of OpenBSC to operate a network will have to release all custom modifiations to the source code.
2011-01-01 14:25:50 +00:00
* along with this program. If not, see <http://www.gnu.org/licenses/>.
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
*
[GPRS] BSSGP: Add VTY for configuration and inpection This also includes log filtering based on NSEI/BVCI tuple
2010-05-17 21:41:43 +00:00
* TODO:
* o properly count incoming BVC-RESET packets in counter group
* o set log context as early as possible for outgoing packets
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
*/
#include <errno.h>
[gprs] Use stdint.h types (uintXX_t instead of u_intXX_t) libosmocore already uses them, it's time (at least for new code) in openbsc to do the same.
2010-05-02 09:26:34 +00:00
#include <stdint.h>
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
src: use new library libosmogsm and new path to headers in libosmocore libosmogsm is a new library that is distributed in the libosmocore. Now, openbsc depends on it. This patch gets openbsc with this change. This patch also rewrites all include path to the new osmocom/[gsm|core] Signed-off-by: Pablo Neira Ayuso <pablo@gnumonks.org>
2011-03-22 15:47:59 +00:00
#include <osmocom/core/msgb.h>
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
#include <osmocom/core/byteswap.h>
#include <osmocom/core/bit16gen.h>
src: use new library libosmogsm and new path to headers in libosmocore libosmogsm is a new library that is distributed in the libosmocore. Now, openbsc depends on it. This patch gets openbsc with this change. This patch also rewrites all include path to the new osmocom/[gsm|core] Signed-off-by: Pablo Neira Ayuso <pablo@gnumonks.org>
2011-03-22 15:47:59 +00:00
#include <osmocom/gsm/tlv.h>
#include <osmocom/core/talloc.h>
#include <osmocom/core/rate_ctr.h>
stats: Limit reporting by class id This commit adds class_id fields to the rate_ctr and stat_item group descriptions. The stats reporter code is extended to only process groups whose class_id does not exceed a per reporter max_class level. If the class_id is not set, the code assumes 'global' for groups with idx == 0 and 'subscriber' otherwise. The following vty command is added to config-stats: level (global|peer|subscriber) Set the maximum group level Sponsored-by: On-Waves ehf
2015-11-02 13:49:35 +00:00
#include <osmocom/core/stats.h>
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
split libgb into a separate library for outside use This also removes the dependency to osmo_sock() inside libcommon and replaces it with osmo_sock_* from libosmocore
2012-06-16 06:59:56 +00:00
#include <osmocom/gprs/gprs_bssgp.h>
BSSGP: add function to reset all PTP BVC Change-Id: I9bf8f4dd784ccddbb9926492a85fff3293a0e913 Related: OS#1638
2017-06-29 17:48:29 +00:00
#include <osmocom/gprs/gprs_bssgp_bss.h>
split libgb into a separate library for outside use This also removes the dependency to osmo_sock() inside libcommon and replaces it with osmo_sock_* from libosmocore
2012-06-16 06:59:56 +00:00
#include <osmocom/gprs/gprs_ns.h>
libosmogb: Add a function to tx BVC RESET by nsei/bvci This is needed for osmo-gbproxy where we need more control over BSSGP. Related: SYS#4998 Change-Id: Ifa769bce920a08cf93553dcb164a3fcf50162517
2020-09-26 07:11:05 +00:00
#include "osmocom/gsm/gsm48.h"
gprs_bssgp: agregate RIM related code in gprs_bssgp_rim.c gprs_bssgp and gprs_bssgp_util.c also contains code related to send and receive RIM PDUs via BSSGP and also code to encode and decode RAN INFORMATION PDUs. Lets move this to gprs_bssgp_rim.c Change-Id: Icda279452962b06e552cb1361d2a27b7dc8a6b04 Related: SYS#5103
2021-01-26 11:57:13 +00:00
#include "gprs_bssgp_internal.h"
libgb: Remove dependency to openbsc/debug.h
2012-06-16 09:45:59 +00:00
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
void *bssgp_tall_ctx = NULL;
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
static int _gprs_ns_sendmsg(void *ctx, struct msgb *msg);
bssgp_bvc_send bssgp_ns_send = _gprs_ns_sendmsg;
void *bssgp_ns_send_data = NULL;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
static const struct rate_ctr_desc bssgp_ctr_description[] = {
Convert lib-internal rate_ctr from '.' separator to ':' separator The rate_ctr.c code would do this mangling automatically, but let's avoid using this from new versions of our code for simplicity/explicitness. Change-Id: I24a556f447cfac25efb6e83cac2d0c2972d98fe3
2017-10-03 09:49:21 +00:00
{ "packets:in", "Packets at BSSGP Level ( In)" },
{ "packets:out","Packets at BSSGP Level (Out)" },
{ "bytes:in", "Bytes at BSSGP Level ( In)" },
{ "bytes:out", "Bytes at BSSGP Level (Out)" },
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
{ "blocked", "BVC Blocking count" },
{ "discarded", "BVC LLC Discarded count" },
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
{ "status", "BVC Status count" },
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
};
static const struct rate_ctr_group_desc bssgp_ctrg_desc = {
Convert lib-internal rate_ctr from '.' separator to ':' separator The rate_ctr.c code would do this mangling automatically, but let's avoid using this from new versions of our code for simplicity/explicitness. Change-Id: I24a556f447cfac25efb6e83cac2d0c2972d98fe3
2017-10-03 09:49:21 +00:00
.group_name_prefix = "bssgp:bss_ctx",
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
.group_description = "BSSGP Peer Statistics",
.num_ctr = ARRAY_SIZE(bssgp_ctr_description),
.ctr_desc = bssgp_ctr_description,
stats: Limit reporting by class id This commit adds class_id fields to the rate_ctr and stat_item group descriptions. The stats reporter code is extended to only process groups whose class_id does not exceed a per reporter max_class level. If the class_id is not set, the code assumes 'global' for groups with idx == 0 and 'subscriber' otherwise. The following vty command is added to config-stats: level (global|peer|subscriber) Set the maximum group level Sponsored-by: On-Waves ehf
2015-11-02 13:49:35 +00:00
.class_id = OSMO_STATS_CLASS_PEER,
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
};
[GPRS] BSSGP: expose more internal structures / API
2010-05-17 21:02:42 +00:00
LLIST_HEAD(bssgp_bvc_ctxts);
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
static int _bssgp_tx_dl_ud(struct bssgp_flow_control *fc, struct msgb *msg,
uint32_t llc_pdu_len, void *priv);
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
gb/gprs_bssgp: remove superfluous whitespace Change-Id: Ic66f7e640cd473fa2c8473a3e91f57332ae9bf6a
2020-09-03 17:30:08 +00:00
/* callback to be backward compatible with old users which do not set the bssgp_ns_send function */
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
static int _gprs_ns_sendmsg(void *ctx, struct msgb *msg)
{
gb/bssgp: Abort clearly if backward-compat API is used in wrong way Some tests under osmo-pcu (TbfTest) were caught accessning NULL pointer bssgp_nsi in bssgp_tx_llc_discarded triggered by timeout while stepping slowly with the debugger. It seems that test is not properly using neither the old nor the new API. Let's catch such cases easily. Change-Id: I3ea42755c4bfd29e4a01ad57f186f28d58ab466a
2021-07-26 12:37:39 +00:00
OSMO_ASSERT(bssgp_nsi);
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
return gprs_ns_sendmsg(bssgp_nsi, msg);
}
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
/* Find a BTS Context based on parsed RA ID and Cell ID */
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *btsctx_by_raid_cid(const struct gprs_ra_id *raid, uint16_t cid)
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
{
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *bctx;
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
[GPRS] BSSGP: expose more internal structures / API
2010-05-17 21:02:42 +00:00
llist_for_each_entry(bctx, &bssgp_bvc_ctxts, list) {
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
if (!memcmp(&bctx->ra_id, raid, sizeof(bctx->ra_id)) &&
bctx->cell_id == cid)
return bctx;
}
return NULL;
}
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
/* Transmit a BVC-RESET or BVC-RESET-ACK with a given nsei and bvci (Chapter 10.4.12)
* \param[in] pdu Either BSSGP_PDUT_BVC_RESET or BSSGP_PDUT_BVC_RESET_ACK
libosmogb: Add a function to tx BVC RESET by nsei/bvci This is needed for osmo-gbproxy where we need more control over BSSGP. Related: SYS#4998 Change-Id: Ifa769bce920a08cf93553dcb164a3fcf50162517
2020-09-26 07:11:05 +00:00
* \param[in] nsei The NSEI to transmit over
* \param[in] bvci BVCI of the BVC to reset
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
* \param[in] cause The cause of the reset only valid for BSSGP_PDUT_BVC_RESET.
libosmogb: Add a function to tx BVC RESET by nsei/bvci This is needed for osmo-gbproxy where we need more control over BSSGP. Related: SYS#4998 Change-Id: Ifa769bce920a08cf93553dcb164a3fcf50162517
2020-09-26 07:11:05 +00:00
* \param[in] ra_id Pointer to the ra_id to include. If NULL no cell information will be included
* \param[in] cell_id The cell_id to include (if ra_id is not NULL)
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
* returns >= 0 on success, on error < 0.
libosmogb: Add a function to tx BVC RESET by nsei/bvci This is needed for osmo-gbproxy where we need more control over BSSGP. Related: SYS#4998 Change-Id: Ifa769bce920a08cf93553dcb164a3fcf50162517
2020-09-26 07:11:05 +00:00
*/
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
static int tx_bvc_reset_nsei_bvci(enum bssgp_pdu_type pdu, uint16_t nsei, uint16_t bvci,
enum gprs_bssgp_cause cause, const struct gprs_ra_id *ra_id, uint16_t cell_id)
libosmogb: Add a function to tx BVC RESET by nsei/bvci This is needed for osmo-gbproxy where we need more control over BSSGP. Related: SYS#4998 Change-Id: Ifa769bce920a08cf93553dcb164a3fcf50162517
2020-09-26 07:11:05 +00:00
{
struct msgb *msg = bssgp_msgb_alloc();
struct bssgp_normal_hdr *bgph =
(struct bssgp_normal_hdr *) msgb_put(msg, sizeof(*bgph));
uint16_t _bvci = osmo_htons(bvci);
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
OSMO_ASSERT(pdu == BSSGP_PDUT_BVC_RESET || pdu == BSSGP_PDUT_BVC_RESET_ACK);
libosmogb: Add a function to tx BVC RESET by nsei/bvci This is needed for osmo-gbproxy where we need more control over BSSGP. Related: SYS#4998 Change-Id: Ifa769bce920a08cf93553dcb164a3fcf50162517
2020-09-26 07:11:05 +00:00
msgb_nsei(msg) = nsei;
gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1 Makes more understandable and clear what's meant in the code. Related: OS#3879 Change-Id: I9d0545fac0af0dcc1783040a376a9b8e65a92699
2021-02-19 18:29:04 +00:00
msgb_bvci(msg) = BVCI_SIGNALLING;
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
bgph->pdu_type = pdu;
libosmogb: Add a function to tx BVC RESET by nsei/bvci This is needed for osmo-gbproxy where we need more control over BSSGP. Related: SYS#4998 Change-Id: Ifa769bce920a08cf93553dcb164a3fcf50162517
2020-09-26 07:11:05 +00:00
msgb_tvlv_put(msg, BSSGP_IE_BVCI, 2, (uint8_t *) &_bvci);
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
if (pdu == BSSGP_PDUT_BVC_RESET) {
msgb_tvlv_put(msg, BSSGP_IE_CAUSE, 1, (uint8_t *) &cause);
LOGP(DLBSSGP, LOGL_NOTICE, "BSSGP (BVCI=%u) Tx BVC-RESET "
"CAUSE=%s\n", bvci, bssgp_cause_str(cause));
} else {
LOGP(DLBSSGP, LOGL_NOTICE, "BSSGP (BVCI=%u) Tx BVC-RESET-ACK\n", bvci);
}
libosmogb: Add a function to tx BVC RESET by nsei/bvci This is needed for osmo-gbproxy where we need more control over BSSGP. Related: SYS#4998 Change-Id: Ifa769bce920a08cf93553dcb164a3fcf50162517
2020-09-26 07:11:05 +00:00
if (ra_id) {
uint8_t bssgp_cid[8];
bssgp_create_cell_id(bssgp_cid, ra_id, cell_id);
msgb_tvlv_put(msg, BSSGP_IE_CELL_ID, sizeof(bssgp_cid), bssgp_cid);
}
/* Optional: Feature Bitmap */
return bssgp_ns_send(bssgp_ns_send_data, msg);
}
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
/*! Transmit a BVC-RESET message with a given nsei and bvci (Chapter 10.4.12)
* \param[in] nsei The NSEI to transmit over
* \param[in] bvci BVCI of the BVC to reset
* \param[in] cause The cause of the reset
* \param[in] ra_id Pointer to the ra_id to include. If NULL no cell information will be included
* \param[in] cell_id The cell_id to include (if ra_id is not NULL)
* returns >= 0 on success, on error < 0.
*/
int bssgp_tx_bvc_reset_nsei_bvci(uint16_t nsei, uint16_t bvci, enum gprs_bssgp_cause cause, const struct gprs_ra_id *ra_id, uint16_t cell_id)
{
return tx_bvc_reset_nsei_bvci(BSSGP_PDUT_BVC_RESET, nsei, bvci, cause, ra_id, cell_id);
}
/*! Transmit a BVC-RESET-ACK message with a given nsei and bvci (Chapter 10.4.12)
* \param[in] nsei The NSEI to transmit over
* \param[in] bvci BVCI of the BVC to reset
* \param[in] ra_id Pointer to the ra_id to include. If NULL no cell information will be included
* \param[in] cell_id The cell_id to include (if ra_id is not NULL)
* returns >= 0 on success, on error < 0.
*/
int bssgp_tx_bvc_reset_ack_nsei_bvci(uint16_t nsei, uint16_t bvci, const struct gprs_ra_id *ra_id, uint16_t cell_id)
{
return tx_bvc_reset_nsei_bvci(BSSGP_PDUT_BVC_RESET_ACK, nsei, bvci, 0, ra_id, cell_id);
}
BSSGP: add function to reset all PTP BVC Change-Id: I9bf8f4dd784ccddbb9926492a85fff3293a0e913 Related: OS#1638
2017-06-29 17:48:29 +00:00
/*! Initiate reset procedure for all PTP BVC on a given NSEI.
*
* This function initiates reset procedure for all PTP BVC with a given cause.
* \param[in] nsei NSEI to which PTP BVC should belong to
* \param[in] cause Cause of BVC RESET
* \returns 0 on success, negative error code otherwise
*/
int bssgp_tx_bvc_ptp_reset(uint16_t nsei, enum gprs_bssgp_cause cause)
{
int rc;
struct bssgp_bvc_ctx *bctx;
llist_for_each_entry(bctx, &bssgp_bvc_ctxts, list) {
if (bctx->nsei == nsei && bctx->bvci != BVCI_SIGNALLING) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_DEBUG, "NSEI=%u/BVCI=%u RESET due to %s\n",
BSSGP: add function to reset all PTP BVC Change-Id: I9bf8f4dd784ccddbb9926492a85fff3293a0e913 Related: OS#1638
2017-06-29 17:48:29 +00:00
nsei, bctx->bvci, bssgp_cause_str(cause));
rc = bssgp_tx_bvc_reset(bctx, bctx->bvci, cause);
if (rc < 0)
return rc;
}
}
return 0;
}
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
/* Find a BTS context based on BVCI+NSEI tuple */
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *btsctx_by_bvci_nsei(uint16_t bvci, uint16_t nsei)
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
{
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *bctx;
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
[GPRS] BSSGP: expose more internal structures / API
2010-05-17 21:02:42 +00:00
llist_for_each_entry(bctx, &bssgp_bvc_ctxts, list) {
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
if (bctx->nsei == nsei && bctx->bvci == bvci)
return bctx;
}
return NULL;
}
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
void bssgp_set_bssgp_callback(bssgp_bvc_send ns_send, void *data)
{
bssgp_ns_send = ns_send;
bssgp_ns_send_data = data;
}
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *btsctx_alloc(uint16_t bvci, uint16_t nsei)
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
{
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *ctx;
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
ctx = talloc_zero(bssgp_tall_ctx, struct bssgp_bvc_ctx);
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
if (!ctx)
return NULL;
ctx->bvci = bvci;
ctx->nsei = nsei;
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
ctx->is_sgsn = true;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
/* FIXME: BVCI is not unique, only BVCI+NSEI ?!? */
ctx->ctrg = rate_ctr_group_alloc(ctx, &bssgp_ctrg_desc, bvci);
gb/gprs_bssgb: check if talloc failed on btsctx->fc Change-Id: I1cfccc2cb696d9e95f590b99559d0a987031adfe
2020-09-16 21:09:24 +00:00
if (!ctx->ctrg)
goto err_ctrg;
BSSGP: make bvc_ctx->fc a dynamic talloc allocation this ensures that we can talloc the flow-control queue entries as siblings off the bvc_ctx.
2012-09-07 09:29:32 +00:00
ctx->fc = talloc_zero(ctx, struct bssgp_flow_control);
gb/gprs_bssgb: check if talloc failed on btsctx->fc Change-Id: I1cfccc2cb696d9e95f590b99559d0a987031adfe
2020-09-16 21:09:24 +00:00
if (!ctx->fc)
goto err_fc;
BSSGP: make bvc_ctx->fc a dynamic talloc allocation this ensures that we can talloc the flow-control queue entries as siblings off the bvc_ctx.
2012-09-07 09:29:32 +00:00
/* cofigure for 2Mbit, 30 packets in queue */
bssgp_fc_init(ctx->fc, 100000, 2*1024*1024/8, 30, &_bssgp_tx_dl_ud);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
[GPRS] BSSGP: expose more internal structures / API
2010-05-17 21:02:42 +00:00
llist_add(&ctx->list, &bssgp_bvc_ctxts);
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
return ctx;
gb/gprs_bssgb: check if talloc failed on btsctx->fc Change-Id: I1cfccc2cb696d9e95f590b99559d0a987031adfe
2020-09-16 21:09:24 +00:00
err_fc:
rate_ctr_group_free(ctx->ctrg);
err_ctrg:
talloc_free(ctx);
return NULL;
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
}
GPRS/BSSGP: introduce bssgp_bvc_ctx_free() So far we had a function to allocate a new bssgp_bvc_ctx, but not the opposite one. Let's finally introduce it, so it will be used at least in OsmoPCU. Please note that the new symbol has 'bssgp_' prefix, not 'btsctx_'. Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172
2019-11-08 18:45:11 +00:00
void bssgp_bvc_ctx_free(struct bssgp_bvc_ctx *ctx)
{
if (!ctx)
return;
gb/gprs_bssgb: ensure the fc timer has been stopped when freeing bssgp_bvc Change-Id: Id03ebef31bb513e2b3b5bc709a91e9352ebbbc79
2020-09-16 21:10:03 +00:00
osmo_timer_del(&ctx->fc->timer);
GPRS/BSSGP: introduce bssgp_bvc_ctx_free() So far we had a function to allocate a new bssgp_bvc_ctx, but not the opposite one. Let's finally introduce it, so it will be used at least in OsmoPCU. Please note that the new symbol has 'bssgp_' prefix, not 'btsctx_'. Change-Id: Ia78979379dbdccd6e4628c16f00d0c06d9212172
2019-11-08 18:45:11 +00:00
rate_ctr_group_free(ctx->ctrg);
llist_del(&ctx->list);
talloc_free(ctx);
}
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
/* Chapter 10.4.5: Flow Control BVC ACK */
[gprs] Use stdint.h types (uintXX_t instead of u_intXX_t) libosmocore already uses them, it's time (at least for new code) in openbsc to do the same.
2010-05-02 09:26:34 +00:00
static int bssgp_tx_fc_bvc_ack(uint16_t nsei, uint8_t tag, uint16_t ns_bvci)
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
{
struct msgb *msg = bssgp_msgb_alloc();
struct bssgp_normal_hdr *bgph =
(struct bssgp_normal_hdr *) msgb_put(msg, sizeof(*bgph));
gprs: remove msgb->nsvc pointer and replace it with NSEI and BVCI According to TS 08.16, the BSSGP layer needs to specify NSEI and BVCI when executing the NS UNITDATA REQUEST primitive of the underlying NS layer. Rather than passing around a pointer to the 'struct gprs_nsvc', we now have NSEI and BVCI as members of 'struct obsc_msgb_cb' and set them when BSSGP hands a message down to NS. NS then does a lookup of the 'gprs_nsvc' based on the NSEI parameter.
2010-04-30 17:54:29 +00:00
msgb_nsei(msg) = nsei;
msgb_bvci(msg) = ns_bvci;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
bgph->pdu_type = BSSGP_PDUT_FLOW_CONTROL_BVC_ACK;
msgb_tvlv_put(msg, BSSGP_IE_TAG, 1, &tag);
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
return bssgp_ns_send(bssgp_ns_send_data, msg);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
}
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
/* 10.3.7 SUSPEND-ACK PDU */
int bssgp_tx_suspend_ack(uint16_t nsei, uint32_t tlli,
const struct gprs_ra_id *ra_id, uint8_t suspend_ref)
{
struct msgb *msg = bssgp_msgb_alloc();
struct bssgp_normal_hdr *bgph =
(struct bssgp_normal_hdr *) msgb_put(msg, sizeof(*bgph));
msgb_nsei(msg) = nsei;
msgb_bvci(msg) = 0; /* Signalling */
bgph->pdu_type = BSSGP_PDUT_SUSPEND_ACK;
Use existing function for TLLI encoding Use bssgp_msgb_tlli_put() instead of copy-pasted code. Change-Id: I06d60566a19dcae701f8648c19fbd8db6d586f77
2018-01-05 13:30:22 +00:00
bssgp_msgb_tlli_put(msg, tlli);
Add function to properly encode RAI Add gsm48_encode_ra() which takes appropriate struct as [out] parameter instead of generic buffer. Using uint8_t buffer instead of proper struct type prooved to be error-prone - see Coverity CID57877, CID57876. Old gsm48_construct_ra() is made into tiny wrapper around new function. The test output is adjusted because of the change in function return value which was constant and hence ignored anyway. Related: OS#1640 Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
2018-01-05 13:19:33 +00:00
bssgp_msgb_ra_put(msg, ra_id);
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
msgb_tvlv_put(msg, BSSGP_IE_SUSPEND_REF_NR, 1, &suspend_ref);
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
return bssgp_ns_send(bssgp_ns_send_data, msg);
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
}
/* 10.3.8 SUSPEND-NACK PDU */
int bssgp_tx_suspend_nack(uint16_t nsei, uint32_t tlli,
Add mandatory routeing area IE to SUSPEND-NACK
2010-12-12 11:45:08 +00:00
const struct gprs_ra_id *ra_id,
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
uint8_t *cause)
{
struct msgb *msg = bssgp_msgb_alloc();
struct bssgp_normal_hdr *bgph =
(struct bssgp_normal_hdr *) msgb_put(msg, sizeof(*bgph));
msgb_nsei(msg) = nsei;
msgb_bvci(msg) = 0; /* Signalling */
bgph->pdu_type = BSSGP_PDUT_SUSPEND_NACK;
Use existing function for TLLI encoding Use bssgp_msgb_tlli_put() instead of copy-pasted code. Change-Id: I06d60566a19dcae701f8648c19fbd8db6d586f77
2018-01-05 13:30:22 +00:00
bssgp_msgb_tlli_put(msg, tlli);
Add function to properly encode RAI Add gsm48_encode_ra() which takes appropriate struct as [out] parameter instead of generic buffer. Using uint8_t buffer instead of proper struct type prooved to be error-prone - see Coverity CID57877, CID57876. Old gsm48_construct_ra() is made into tiny wrapper around new function. The test output is adjusted because of the change in function return value which was constant and hence ignored anyway. Related: OS#1640 Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
2018-01-05 13:19:33 +00:00
bssgp_msgb_ra_put(msg, ra_id);
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
if (cause)
msgb_tvlv_put(msg, BSSGP_IE_CAUSE, 1, cause);
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
return bssgp_ns_send(bssgp_ns_send_data, msg);
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
}
/* 10.3.10 RESUME-ACK PDU */
int bssgp_tx_resume_ack(uint16_t nsei, uint32_t tlli,
const struct gprs_ra_id *ra_id)
{
struct msgb *msg = bssgp_msgb_alloc();
struct bssgp_normal_hdr *bgph =
(struct bssgp_normal_hdr *) msgb_put(msg, sizeof(*bgph));
msgb_nsei(msg) = nsei;
msgb_bvci(msg) = 0; /* Signalling */
bgph->pdu_type = BSSGP_PDUT_RESUME_ACK;
Use existing function for TLLI encoding Use bssgp_msgb_tlli_put() instead of copy-pasted code. Change-Id: I06d60566a19dcae701f8648c19fbd8db6d586f77
2018-01-05 13:30:22 +00:00
bssgp_msgb_tlli_put(msg, tlli);
Add function to properly encode RAI Add gsm48_encode_ra() which takes appropriate struct as [out] parameter instead of generic buffer. Using uint8_t buffer instead of proper struct type prooved to be error-prone - see Coverity CID57877, CID57876. Old gsm48_construct_ra() is made into tiny wrapper around new function. The test output is adjusted because of the change in function return value which was constant and hence ignored anyway. Related: OS#1640 Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
2018-01-05 13:19:33 +00:00
bssgp_msgb_ra_put(msg, ra_id);
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
return bssgp_ns_send(bssgp_ns_send_data, msg);
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
}
/* 10.3.11 RESUME-NACK PDU */
int bssgp_tx_resume_nack(uint16_t nsei, uint32_t tlli,
const struct gprs_ra_id *ra_id, uint8_t *cause)
{
struct msgb *msg = bssgp_msgb_alloc();
struct bssgp_normal_hdr *bgph =
(struct bssgp_normal_hdr *) msgb_put(msg, sizeof(*bgph));
msgb_nsei(msg) = nsei;
msgb_bvci(msg) = 0; /* Signalling */
bgph->pdu_type = BSSGP_PDUT_SUSPEND_NACK;
Use existing function for TLLI encoding Use bssgp_msgb_tlli_put() instead of copy-pasted code. Change-Id: I06d60566a19dcae701f8648c19fbd8db6d586f77
2018-01-05 13:30:22 +00:00
bssgp_msgb_tlli_put(msg, tlli);
Add function to properly encode RAI Add gsm48_encode_ra() which takes appropriate struct as [out] parameter instead of generic buffer. Using uint8_t buffer instead of proper struct type prooved to be error-prone - see Coverity CID57877, CID57876. Old gsm48_construct_ra() is made into tiny wrapper around new function. The test output is adjusted because of the change in function return value which was constant and hence ignored anyway. Related: OS#1640 Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
2018-01-05 13:19:33 +00:00
bssgp_msgb_ra_put(msg, ra_id);
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
if (cause)
msgb_tvlv_put(msg, BSSGP_IE_CAUSE, 1, cause);
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
return bssgp_ns_send(bssgp_ns_send_data, msg);
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
}
[gprs] pass BSSGP UL-UNITDATA Cell ID up into GMM layer BSSGP stores a pointer to the Cell Identifier IE in msgb->cb, which is later used by the GMM layer to identify the cell that has sent a given message. This now also means that the gsm_04_08_gprs.c code is free of any legacy references to msg->trx or struct gsm_bts.
2010-05-02 09:54:55 +00:00
uint16_t bssgp_parse_cell_id(struct gprs_ra_id *raid, const uint8_t *buf)
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
{
/* 6 octets RAC */
gsm48_parse_ra(raid, buf);
/* 2 octets CID */
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
return osmo_load16be(buf+6);
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
}
GPRS: add new bssgp_create_cell_id(), opposite of bssgp_parse_cell_id()
2011-11-24 20:32:07 +00:00
int bssgp_create_cell_id(uint8_t *buf, const struct gprs_ra_id *raid,
uint16_t cid)
{
/* 6 octets RAC */
Add function to properly encode RAI Add gsm48_encode_ra() which takes appropriate struct as [out] parameter instead of generic buffer. Using uint8_t buffer instead of proper struct type prooved to be error-prone - see Coverity CID57877, CID57876. Old gsm48_construct_ra() is made into tiny wrapper around new function. The test output is adjusted because of the change in function return value which was constant and hence ignored anyway. Related: OS#1640 Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
2018-01-05 13:19:33 +00:00
gsm48_encode_ra((struct gsm48_ra_id *)buf, raid);
GPRS: add new bssgp_create_cell_id(), opposite of bssgp_parse_cell_id()
2011-11-24 20:32:07 +00:00
/* 2 octets CID */
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
osmo_store16be(cid, buf+6);
GPRS: add new bssgp_create_cell_id(), opposite of bssgp_parse_cell_id()
2011-11-24 20:32:07 +00:00
return 8;
}
[gprs] Build the SGSN stand-alone and not as part of bsc_hack Instead of continuing to add more and more functionality to the bsc_hack binary, we should have the new SGSN code run as a separate executable. After this commit we now build a 'osmo_sgsn' executable, using its own osmo_sgsn.cfg config file. However, the SGSN is not yet functional, mainly due to the fact that the BSSGP and GMM code are written with the assumption that there is a msgb->trx->bts and the according 'sturct gsm_bts' data model around - which clearly is no longer the case outside of bsc_hack.
2010-05-01 14:48:27 +00:00
/* Chapter 8.4 BVC-Reset Procedure */
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
static int bssgp_rx_bvc_reset(struct msgb *msg, struct tlv_parsed *tp,
[gprs] Build the SGSN stand-alone and not as part of bsc_hack Instead of continuing to add more and more functionality to the bsc_hack binary, we should have the new SGSN code run as a separate executable. After this commit we now build a 'osmo_sgsn' executable, using its own osmo_sgsn.cfg config file. However, the SGSN is not yet functional, mainly due to the fact that the BSSGP and GMM code are written with the assumption that there is a msgb->trx->bts and the according 'sturct gsm_bts' data model around - which clearly is no longer the case outside of bsc_hack.
2010-05-01 14:48:27 +00:00
uint16_t ns_bvci)
{
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
struct osmo_bssgp_prim nmp;
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *bctx;
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
uint16_t nsei = msgb_nsei(msg);
uint16_t bvci;
[gprs] Build the SGSN stand-alone and not as part of bsc_hack Instead of continuing to add more and more functionality to the bsc_hack binary, we should have the new SGSN code run as a separate executable. After this commit we now build a 'osmo_sgsn' executable, using its own osmo_sgsn.cfg config file. However, the SGSN is not yet functional, mainly due to the fact that the BSSGP and GMM code are written with the assumption that there is a msgb->trx->bts and the according 'sturct gsm_bts' data model around - which clearly is no longer the case outside of bsc_hack.
2010-05-01 14:48:27 +00:00
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
bvci = tlvp_val16be(tp, BSSGP_IE_BVCI);
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx RESET cause=%s\n", bvci,
[gprs] Build the SGSN stand-alone and not as part of bsc_hack Instead of continuing to add more and more functionality to the bsc_hack binary, we should have the new SGSN code run as a separate executable. After this commit we now build a 'osmo_sgsn' executable, using its own osmo_sgsn.cfg config file. However, the SGSN is not yet functional, mainly due to the fact that the BSSGP and GMM code are written with the assumption that there is a msgb->trx->bts and the according 'sturct gsm_bts' data model around - which clearly is no longer the case outside of bsc_hack.
2010-05-01 14:48:27 +00:00
bssgp_cause_str(*TLVP_VAL(tp, BSSGP_IE_CAUSE)));
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
/* look-up or create the BTS context for this BVC */
bctx = btsctx_by_bvci_nsei(bvci, nsei);
if (!bctx)
bctx = btsctx_alloc(bvci, nsei);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
/* As opposed to NS-VCs, BVCs are NOT blocked after RESET */
bctx->state &= ~BVC_S_BLOCKED;
[gprs] Build the SGSN stand-alone and not as part of bsc_hack Instead of continuing to add more and more functionality to the bsc_hack binary, we should have the new SGSN code run as a separate executable. After this commit we now build a 'osmo_sgsn' executable, using its own osmo_sgsn.cfg config file. However, the SGSN is not yet functional, mainly due to the fact that the BSSGP and GMM code are written with the assumption that there is a msgb->trx->bts and the according 'sturct gsm_bts' data model around - which clearly is no longer the case outside of bsc_hack.
2010-05-01 14:48:27 +00:00
/* When we receive a BVC-RESET PDU (at least of a PTP BVCI), the BSS
* informs us about its RAC + Cell ID, so we can create a mapping */
gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1 Makes more understandable and clear what's meant in the code. Related: OS#3879 Change-Id: I9d0545fac0af0dcc1783040a376a9b8e65a92699
2021-02-19 18:29:04 +00:00
if (bctx->is_sgsn && bvci != BVCI_SIGNALLING && bvci != BVCI_PTM) {
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_CELL_ID, 8)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP BVCI=%u Rx RESET "
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
"missing mandatory IE\n", bvci);
return -EINVAL;
}
/* actually extract RAC / CID */
[gprs] pass BSSGP UL-UNITDATA Cell ID up into GMM layer BSSGP stores a pointer to the Cell Identifier IE in msgb->cb, which is later used by the GMM layer to identify the cell that has sent a given message. This now also means that the gsm_04_08_gprs.c code is free of any legacy references to msg->trx or struct gsm_bts.
2010-05-02 09:54:55 +00:00
bctx->cell_id = bssgp_parse_cell_id(&bctx->ra_id,
TLVP_VAL(tp, BSSGP_IE_CELL_ID));
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_NOTICE, "Cell %s CI %u on BVCI %u\n",
implement support for 3-digit MNC with leading zeros Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are actually different; so far we treated both as 23. Re-encode an incoming BCD or string of 023 as it were, i.e. not dropping the leading zero as 23. Break ABI compatibility by changing the size and ordering of structs gprs_ra_id, osmo_plmn_id, osmo_cell_global_id, ... by adding an mnc_3_digits flag. Change ordering in gprs_ra_id because the canonical oder is {Mobile Country Code, Mobile Network Code}, so have the mcc member first. ABI compatibility cannot be maintained for struct gprs_ra_id, since it is a direct member of structs bssgp_bvc_ctx and bssgp_paging_info, and even just adding a flag to the end would cause ABI changes of those structs. Similarly, osmo_plmn_id is a direct member of osmo_location_area_id, and so forth. Add new API to set and read this additional flag to preserve leading zeros: - osmo_plmn_to_bcd(), osmo_plmn_from_bcd() after gsm48_mcc_mnc_to_bcd() and gsm48_mcc_mnc_from_bcd(). - gsm48_decode_lai2(), gsm48_generate_lai2() after gsm48_decode_lai(), gsm48_generate_lai(). - gsm0808_create_layer3_2() after gsm0808_create_layer3() and gsm0808_create_layer3_aoip(). - various osmo_*_name() functions in gsm23003.h (osmo_rai_name() still in gsm48.h close to struct gprs_ra_id definition). The amount and duplication of these may seem a bit overboard, but IMO they do make sense in this way. Though most code will soon see patches unifying the data structures used, in some cases (vty, ctrl) they are required singled out. Without these functions, the formatting ("%0*u", mnc_3_digits ? 3 : 2, mnc) would be duplicated all over our diverse repositories. In various log output, include the leading MNC zeros. Mark one TODO in card_fs_sim.c, I am not sure how to communicate a leading zero to/from a SIM card FS. The focus here is on the core network / BSS. To indicate ABI incompatibility, bump libosmogsm and libosmogb LIBVERSIONs; adjust debian files accordingly. Implementation choices: - The default behavior upon zero-initialization will be the mnc_3_digits flag set to false, which yields exactly the previous behavior. - I decided against packing the mnc with the mnc_3_digits field into a sub-struct because it would immediately break all builds of dependent projects: it would require immediate merging of numerous patches in other repositories, and it would make compiling older code against a newer libosmocore unneccessarily hard. Change-Id: Id2240f7f518494c9df6c8bda52c0d5092f90f221
2018-02-20 12:47:08 +00:00
osmo_rai_name(&bctx->ra_id), bctx->cell_id, bvci);
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
}
[gprs] Build the SGSN stand-alone and not as part of bsc_hack Instead of continuing to add more and more functionality to the bsc_hack binary, we should have the new SGSN code run as a separate executable. After this commit we now build a 'osmo_sgsn' executable, using its own osmo_sgsn.cfg config file. However, the SGSN is not yet functional, mainly due to the fact that the BSSGP and GMM code are written with the assumption that there is a msgb->trx->bts and the according 'sturct gsm_bts' data model around - which clearly is no longer the case outside of bsc_hack.
2010-05-01 14:48:27 +00:00
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
/* Acknowledge the RESET to the BTS */
gprs_bssgp: use BVCI_SIGNALLING/BVCI_PTM instead of 0/1 Makes more understandable and clear what's meant in the code. Related: OS#3879 Change-Id: I9d0545fac0af0dcc1783040a376a9b8e65a92699
2021-02-19 18:29:04 +00:00
if (bvci == BVCI_SIGNALLING || bvci == BVCI_PTM || bctx->is_sgsn)
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
bssgp_tx_simple_bvci(BSSGP_PDUT_BVC_RESET_ACK,
nsei, bvci, ns_bvci);
else
bssgp_tx_bvc_reset_ack_nsei_bvci(nsei, bvci, &bctx->ra_id, bctx->cell_id);
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
/* Send NM_BVC_RESET.ind to NM */
memset(&nmp, 0, sizeof(nmp));
nmp.nsei = nsei;
nmp.bvci = bvci;
nmp.tp = tp;
nmp.ra_id = &bctx->ra_id;
osmo_prim_init(&nmp.oph, SAP_BSSGP_NM, PRIM_NM_BVC_RESET,
PRIM_OP_INDICATION, msg);
bssgp_prim_cb(&nmp.oph, NULL);
[gprs] Build the SGSN stand-alone and not as part of bsc_hack Instead of continuing to add more and more functionality to the bsc_hack binary, we should have the new SGSN code run as a separate executable. After this commit we now build a 'osmo_sgsn' executable, using its own osmo_sgsn.cfg config file. However, the SGSN is not yet functional, mainly due to the fact that the BSSGP and GMM code are written with the assumption that there is a msgb->trx->bts and the according 'sturct gsm_bts' data model around - which clearly is no longer the case outside of bsc_hack.
2010-05-01 14:48:27 +00:00
return 0;
}
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
static int bssgp_rx_bvc_block(struct msgb *msg, struct tlv_parsed *tp)
{
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
struct osmo_bssgp_prim nmp;
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
uint16_t bvci, nsei = msgb_nsei(msg);
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *ptp_ctx;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
bvci = tlvp_val16be(tp, BSSGP_IE_BVCI);
[GPRS] BSSGP: Use correct values for SIGNALLING and PTM BVCI
2010-05-18 09:57:08 +00:00
if (bvci == BVCI_SIGNALLING) {
[GPRS] BSSGP: Refuse blocking of signalling BVC; Ignore traffic on blocked BVC
2010-05-13 19:45:23 +00:00
/* 8.3.2: Signalling BVC shall never be blocked */
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "NSEI=%u/BVCI=%u "
[GPRS] BSSGP: Refuse blocking of signalling BVC; Ignore traffic on blocked BVC
2010-05-13 19:45:23 +00:00
"received block for signalling BVC!?!\n",
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
nsei, msgb_bvci(msg));
[GPRS] BSSGP: Refuse blocking of signalling BVC; Ignore traffic on blocked BVC
2010-05-13 19:45:23 +00:00
return 0;
}
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_INFO, "BSSGP Rx BVCI=%u BVC-BLOCK\n", bvci);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
ptp_ctx = btsctx_by_bvci_nsei(bvci, nsei);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
if (!ptp_ctx)
return bssgp_tx_status(BSSGP_CAUSE_UNKNOWN_BVCI, &bvci, msg);
ptp_ctx->state |= BVC_S_BLOCKED;
Use new stat item/ctr getter APIs Generated with spatch: """ @@ expression E1, E2; @@ - &E2->ctr[E1] + rate_ctr_group_get_ctr(E2, E1) """ """ @@ expression E1, E2, E3; @@ - E2->items[E1] + osmo_stat_item_group_get_item(E2, E1) """ Change-Id: I41297a8df68e28dfc6016330ac82b0ed5dd0ebc1
2021-06-04 16:17:12 +00:00
rate_ctr_inc(rate_ctr_group_get_ctr(ptp_ctx->ctrg, BSSGP_CTR_BLOCKED));
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
/* Send NM_BVC_BLOCK.ind to NM */
memset(&nmp, 0, sizeof(nmp));
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
nmp.nsei = nsei;
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
nmp.bvci = bvci;
nmp.tp = tp;
osmo_prim_init(&nmp.oph, SAP_BSSGP_NM, PRIM_NM_BVC_BLOCK,
PRIM_OP_INDICATION, msg);
bssgp_prim_cb(&nmp.oph, NULL);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
/* We always acknowledge the BLOCKing */
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
return bssgp_tx_simple_bvci(BSSGP_PDUT_BVC_BLOCK_ACK, nsei,
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
bvci, msgb_bvci(msg));
};
static int bssgp_rx_bvc_unblock(struct msgb *msg, struct tlv_parsed *tp)
{
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
struct osmo_bssgp_prim nmp;
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
uint16_t bvci, nsei = msgb_nsei(msg);
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *ptp_ctx;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
bvci = tlvp_val16be(tp, BSSGP_IE_BVCI);
[GPRS] BSSGP: Use correct values for SIGNALLING and PTM BVCI
2010-05-18 09:57:08 +00:00
if (bvci == BVCI_SIGNALLING) {
[GPRS] BSSGP: Refuse blocking of signalling BVC; Ignore traffic on blocked BVC
2010-05-13 19:45:23 +00:00
/* 8.3.2: Signalling BVC shall never be blocked */
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "NSEI=%u/BVCI=%u "
[GPRS] BSSGP: Refuse blocking of signalling BVC; Ignore traffic on blocked BVC
2010-05-13 19:45:23 +00:00
"received unblock for signalling BVC!?!\n",
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
nsei, msgb_bvci(msg));
[GPRS] BSSGP: Refuse blocking of signalling BVC; Ignore traffic on blocked BVC
2010-05-13 19:45:23 +00:00
return 0;
}
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx BVC-UNBLOCK\n", bvci);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
ptp_ctx = btsctx_by_bvci_nsei(bvci, nsei);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
if (!ptp_ctx)
return bssgp_tx_status(BSSGP_CAUSE_UNKNOWN_BVCI, &bvci, msg);
ptp_ctx->state &= ~BVC_S_BLOCKED;
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
/* Send NM_BVC_UNBLOCK.ind to NM */
memset(&nmp, 0, sizeof(nmp));
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
nmp.nsei = nsei;
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
nmp.bvci = bvci;
nmp.tp = tp;
osmo_prim_init(&nmp.oph, SAP_BSSGP_NM, PRIM_NM_BVC_UNBLOCK,
PRIM_OP_INDICATION, msg);
bssgp_prim_cb(&nmp.oph, NULL);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
/* We always acknowledge the unBLOCKing */
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
return bssgp_tx_simple_bvci(BSSGP_PDUT_BVC_UNBLOCK_ACK, nsei,
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
bvci, msgb_bvci(msg));
};
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
/* Uplink unit-data */
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
static int bssgp_rx_ul_ud(struct msgb *msg, struct tlv_parsed *tp,
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *ctx)
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
{
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
struct osmo_bssgp_prim gbp;
[gprs] Ensure msgb->l3h points to Layer3 (04.08) In the old code l3h = BSSGP, l4h = LLC, cb[gmmh] = 04.08 Now, this has been changed to cb[bssgph] = BSSGP, cb[llch] = LLC, l3h = 04.08 This way, GSM general 04.08 and GPRS 04.08 code can expect a GSM 04.08 header at msgb->l3h
2010-05-02 07:50:42 +00:00
struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) msgb_bssgph(msg);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
[gprs] introduce BSSGP concept of BTS contextx A BTS context represents the mapping betewen (RA-ID, Cell-ID) and (BVCI, NSEI) as well as the per-BVC local state.
2010-05-02 07:23:16 +00:00
/* extract TLLI and parse TLV IEs */
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
msgb_tlli(msg) = osmo_ntohl(budh->tlli);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP TLLI=0x%08x Rx UPLINK-UNITDATA\n", msgb_tlli(msg));
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
/* Cell ID and LLC_PDU are the only mandatory IE */
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_CELL_ID, 8) ||
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
!TLVP_PRESENT(tp, BSSGP_IE_LLC_PDU)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP TLLI=0x%08x Rx UL-UD "
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
"missing mandatory IE\n", msgb_tlli(msg));
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
}
[gprs] SGSN: Expect all Identifiers to be stored at highest level We now expect the highest level (actual SGSN GMM code) to know all identifiers for every element in the protocol stack, i.e. TLLI, SAPI, BVCI and NSEI. The layer-inetrnal state is looked up based on those identifiers. The reason for this is to ensure only the highest level state needs to be persistent, while everything else can be regenerated dynamically (e.g. in a SGSN restart)
2010-05-02 09:19:37 +00:00
[gprs] pass BSSGP UL-UNITDATA Cell ID up into GMM layer BSSGP stores a pointer to the Cell Identifier IE in msgb->cb, which is later used by the GMM layer to identify the cell that has sent a given message. This now also means that the gsm_04_08_gprs.c code is free of any legacy references to msg->trx or struct gsm_bts.
2010-05-02 09:54:55 +00:00
/* store pointer to LLC header and CELL ID in msgb->cb */
gprs_bssgp.c: Cast const of TLVP_VAL away. Fix a compiler warning, we cast the const away at various other parts in the code as well. We should consider removing the const from the TLV struct..
2010-05-23 13:11:19 +00:00
msgb_llch(msg) = (uint8_t *) TLVP_VAL(tp, BSSGP_IE_LLC_PDU);
msgb_bcid(msg) = (uint8_t *) TLVP_VAL(tp, BSSGP_IE_CELL_ID);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
/* Send BSSGP_UL_UD.ind to NM */
memset(&gbp, 0, sizeof(gbp));
gbp.nsei = ctx->nsei;
gbp.bvci = ctx->bvci;
gbp.tlli = msgb_tlli(msg);
gbp.tp = tp;
osmo_prim_init(&gbp.oph, SAP_BSSGP_LL, PRIM_BSSGP_UL_UD,
PRIM_OP_INDICATION, msg);
return bssgp_prim_cb(&gbp.oph, NULL);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
}
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
static int bssgp_rx_suspend(struct msgb *msg, struct tlv_parsed *tp)
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
{
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
struct osmo_bssgp_prim gbp;
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
struct gprs_ra_id raid;
uint32_t tlli;
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
uint16_t ns_bvci = msgb_bvci(msg), nsei = msgb_nsei(msg);
[GPRS] SGSN: Pass BSSGP SUSPEND/RESUME up to GMM and alter MMCTX state
2010-06-09 09:22:47 +00:00
int rc;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_TLLI, 4) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_ROUTEING_AREA, 6)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP BVCI=%u Rx SUSPEND "
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
"missing mandatory IE\n", ns_bvci);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
}
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
tlli = tlvp_val32be(tp, BSSGP_IE_TLLI);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u TLLI=0x%08x Rx SUSPEND\n",
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
ns_bvci, tlli);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
gsm48_parse_ra(&raid, TLVP_VAL(tp, BSSGP_IE_ROUTEING_AREA));
[GPRS] SGSN: Pass BSSGP SUSPEND/RESUME up to GMM and alter MMCTX state
2010-06-09 09:22:47 +00:00
/* Inform GMM about the SUSPEND request */
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
memset(&gbp, 0, sizeof(gbp));
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
gbp.nsei = nsei;
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
gbp.bvci = ns_bvci;
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
gbp.tlli = tlli;
gbp.ra_id = &raid;
osmo_prim_init(&gbp.oph, SAP_BSSGP_GMM, PRIM_BSSGP_GMM_SUSPEND,
PRIM_OP_REQUEST, msg);
rc = bssgp_prim_cb(&gbp.oph, NULL);
[GPRS] SGSN: Pass BSSGP SUSPEND/RESUME up to GMM and alter MMCTX state
2010-06-09 09:22:47 +00:00
if (rc < 0)
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
return bssgp_tx_suspend_nack(nsei, tlli, &raid, NULL);
[GPRS] SGSN: Pass BSSGP SUSPEND/RESUME up to GMM and alter MMCTX state
2010-06-09 09:22:47 +00:00
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
bssgp_tx_suspend_ack(nsei, tlli, &raid, 0);
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
gprs_bssgp.c: Return something from non void methods. In one use the rc variable we are assigning to, in the others return 0 even if we have a FIXME there.
2010-05-23 13:12:15 +00:00
return 0;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
}
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
static int bssgp_rx_resume(struct msgb *msg, struct tlv_parsed *tp)
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
{
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
struct osmo_bssgp_prim gbp;
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
struct gprs_ra_id raid;
uint32_t tlli;
[GPRS] SGSN: Pass BSSGP SUSPEND/RESUME up to GMM and alter MMCTX state
2010-06-09 09:22:47 +00:00
uint8_t suspend_ref;
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
uint16_t ns_bvci = msgb_bvci(msg), nsei = msgb_nsei(msg);
[GPRS] SGSN: Pass BSSGP SUSPEND/RESUME up to GMM and alter MMCTX state
2010-06-09 09:22:47 +00:00
int rc;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_TLLI, 4 ) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_ROUTEING_AREA, 6) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_SUSPEND_REF_NR, 1)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP BVCI=%u Rx RESUME "
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
"missing mandatory IE\n", ns_bvci);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
}
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
tlli = tlvp_val32be(tp, BSSGP_IE_TLLI);
[GPRS] SGSN: Pass BSSGP SUSPEND/RESUME up to GMM and alter MMCTX state
2010-06-09 09:22:47 +00:00
suspend_ref = *TLVP_VAL(tp, BSSGP_IE_SUSPEND_REF_NR);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u TLLI=0x%08x Rx RESUME\n", ns_bvci, tlli);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
[GPRS] BSSGP: Acknowledge all SUSPEND and RESUME requests This is of course not the correct way of dealing with it, but for now it should make the Ericsson Mobile Plafrom based phones happy (they insist to do a suspend/resume cycle before pdp ctx act)
2010-05-30 20:00:53 +00:00
gsm48_parse_ra(&raid, TLVP_VAL(tp, BSSGP_IE_ROUTEING_AREA));
[GPRS] SGSN: Pass BSSGP SUSPEND/RESUME up to GMM and alter MMCTX state
2010-06-09 09:22:47 +00:00
/* Inform GMM about the RESUME request */
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
memset(&gbp, 0, sizeof(gbp));
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
gbp.nsei = nsei;
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
gbp.bvci = ns_bvci;
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
gbp.tlli = tlli;
gbp.ra_id = &raid;
gbp.u.resume.suspend_ref = suspend_ref;
osmo_prim_init(&gbp.oph, SAP_BSSGP_GMM, PRIM_BSSGP_GMM_RESUME,
PRIM_OP_REQUEST, msg);
rc = bssgp_prim_cb(&gbp.oph, NULL);
[GPRS] SGSN: Pass BSSGP SUSPEND/RESUME up to GMM and alter MMCTX state
2010-06-09 09:22:47 +00:00
if (rc < 0)
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
return bssgp_tx_resume_nack(nsei, tlli, &raid,
[GPRS] SGSN: Pass BSSGP SUSPEND/RESUME up to GMM and alter MMCTX state
2010-06-09 09:22:47 +00:00
NULL);
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
bssgp_tx_resume_ack(nsei, tlli, &raid);
gprs_bssgp.c: Return something from non void methods. In one use the rc variable we are assigning to, in the others return 0 even if we have a FIXME there.
2010-05-23 13:12:15 +00:00
return 0;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
}
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
static int bssgp_rx_llc_disc(struct msgb *msg, struct tlv_parsed *tp,
struct bssgp_bvc_ctx *ctx)
{
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
struct osmo_bssgp_prim nmp;
[gprs] BSSGP: Fix null pointer dereference Zecke has found this using "make CC="clang --analyze"
2010-07-23 19:59:29 +00:00
uint32_t tlli = 0;
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
uint16_t nsei = msgb_nsei(msg);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_TLLI, 4) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_LLC_FRAMES_DISCARDED, 1) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_BVCI, 2) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_NUM_OCT_AFF, 3)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP BVCI=%u Rx LLC DISCARDED "
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
"missing mandatory IE\n", ctx->bvci);
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
}
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
tlli = tlvp_val32be(tp, BSSGP_IE_TLLI);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u TLLI=%08x Rx LLC DISCARDED\n",
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
ctx->bvci, tlli);
Use new stat item/ctr getter APIs Generated with spatch: """ @@ expression E1, E2; @@ - &E2->ctr[E1] + rate_ctr_group_get_ctr(E2, E1) """ """ @@ expression E1, E2, E3; @@ - E2->items[E1] + osmo_stat_item_group_get_item(E2, E1) """ Change-Id: I41297a8df68e28dfc6016330ac82b0ed5dd0ebc1
2021-06-04 16:17:12 +00:00
rate_ctr_inc(rate_ctr_group_get_ctr(ctx->ctrg, BSSGP_CTR_DISCARDED));
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
/* send NM_LLC_DISCARDED to NM */
memset(&nmp, 0, sizeof(nmp));
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
nmp.nsei = nsei;
libgb: don't call directly into GMM / LLC layer Instead of direct function calls to individual functions, we now generate primitives (osmo_prim) and send them to one application-provided function "bssgp_prim_cb()"
2012-06-17 04:16:31 +00:00
nmp.bvci = ctx->bvci;
nmp.tlli = tlli;
nmp.tp = tp;
osmo_prim_init(&nmp.oph, SAP_BSSGP_NM, PRIM_NM_LLC_DISCARDED,
PRIM_OP_INDICATION, msg);
return bssgp_prim_cb(&nmp.oph, NULL);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
}
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
int bssgp_rx_status(struct msgb *msg, struct tlv_parsed *tp,
uint16_t bvci, struct bssgp_bvc_ctx *bctx)
{
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
uint16_t nsei = msgb_nsei(msg);
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
struct osmo_bssgp_prim nmp;
enum gprs_bssgp_cause cause;
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_CAUSE, 1)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP BVCI=%u Rx STATUS "
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
"missing mandatory IE\n", bvci);
cause = BSSGP_CAUSE_PROTO_ERR_UNSPEC;
} else {
cause = *TLVP_VAL(tp, BSSGP_IE_CAUSE);
}
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_NOTICE, "BSSGP BVCI=%u Rx BVC STATUS, cause=%s\n",
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
bvci, bssgp_cause_str(cause));
if (cause == BSSGP_CAUSE_BVCI_BLOCKED || cause == BSSGP_CAUSE_UNKNOWN_BVCI) {
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_BVCI, 2))
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR,
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
"BSSGP BVCI=%u Rx STATUS cause=%s "
"missing conditional BVCI IE\n",
bvci, bssgp_cause_str(cause));
}
if (bctx)
Use new stat item/ctr getter APIs Generated with spatch: """ @@ expression E1, E2; @@ - &E2->ctr[E1] + rate_ctr_group_get_ctr(E2, E1) """ """ @@ expression E1, E2, E3; @@ - E2->items[E1] + osmo_stat_item_group_get_item(E2, E1) """ Change-Id: I41297a8df68e28dfc6016330ac82b0ed5dd0ebc1
2021-06-04 16:17:12 +00:00
rate_ctr_inc(rate_ctr_group_get_ctr(bctx->ctrg, BSSGP_CTR_STATUS));
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
/* send NM_STATUS to NM */
memset(&nmp, 0, sizeof(nmp));
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
nmp.nsei = nsei;
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
nmp.bvci = bvci;
nmp.tp = tp;
osmo_prim_init(&nmp.oph, SAP_BSSGP_NM, PRIM_NM_STATUS,
PRIM_OP_INDICATION, msg);
return bssgp_prim_cb(&nmp.oph, NULL);
}
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
/* One element (msgb) in a BSSGP Flow Control queue */
struct bssgp_fc_queue_element {
/* linked list of queue elements */
struct llist_head list;
/* The message that we have enqueued */
struct msgb *msg;
/* Length of the LLC PDU part of the contained message */
uint32_t llc_pdu_len;
/* private pointer passed to the flow control out_cb function */
void *priv;
};
static int fc_queue_timer_cfg(struct bssgp_flow_control *fc);
static int bssgp_fc_needs_queueing(struct bssgp_flow_control *fc, uint32_t pdu_len);
static void fc_timer_cb(void *data)
{
struct bssgp_flow_control *fc = data;
struct bssgp_fc_queue_element *fcqe;
struct timeval time_now;
/* if the queue is empty, we return without sending something
* and without re-starting the timer */
if (llist_empty(&fc->queue))
return;
/* get the first entry from the queue */
fcqe = llist_entry(fc->queue.next, struct bssgp_fc_queue_element,
list);
if (bssgp_fc_needs_queueing(fc, fcqe->llc_pdu_len)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_NOTICE, "BSSGP-FC: fc_timer_cb() but still "
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
"not able to send PDU of %u bytes\n", fcqe->llc_pdu_len);
/* make sure we re-start the timer */
fc_queue_timer_cfg(fc);
return;
}
/* remove from the queue */
llist_del(&fcqe->list);
fc->queue_depth--;
/* record the time we transmitted this PDU */
add osmo_gettimeofday as a shim around gettimeofday This allows feeding a custom time for unit tests by overriding osmo_gettimeofday. Change-Id: Ic7a81a6eb51f27fe452962b91f2eae2070d87089
2016-09-22 01:58:13 +00:00
osmo_gettimeofday(&time_now, NULL);
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
fc->time_last_pdu = time_now;
/* call the output callback for this FC instance */
fc->out_cb(fcqe->priv, fcqe->msg, fcqe->llc_pdu_len, NULL);
/* we expect that out_cb will in the end free the msgb once
* it is no longer needed */
/* but we have to free the queue element ourselves */
talloc_free(fcqe);
/* re-configure the timer for the next PDU */
fc_queue_timer_cfg(fc);
}
/* configure/schedule the flow control timer to expire once the bucket
* will have leaked a sufficient number of bytes to transmit the next
* PDU in the queue */
static int fc_queue_timer_cfg(struct bssgp_flow_control *fc)
{
struct bssgp_fc_queue_element *fcqe;
uint32_t msecs;
if (llist_empty(&fc->queue))
return 0;
bssgp: Fix call to llist_entry in fc_queue_timer_cfg Currently the DL sometimes hangs and sometimes a lot of messages (still not able to send PDU) are logged. This is caused by an invalid timer delay computation, setting msecs either to 0 or to some big value. This is due to an '&' operator at the wrong place, accessing some parts in fc instead of the first element of the list. This commit fixes that issue. Sponsored-by: On-Waves ehf
2015-04-30 17:28:03 +00:00
fcqe = llist_entry(fc->queue.next, struct bssgp_fc_queue_element,
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
list);
BSSGP: prevent divide-by-zero in flow control If the BTS tells us to not send any data at all anymore (bucket leak rate of 0 bits per second), then we should respect this and not run into a divide-by-zero. However, as this indicates complete overload, we print a log message to that regard.
2013-06-22 07:44:00 +00:00
if (fc->bucket_leak_rate != 0) {
/* Calculate the point in time at which we will have leaked
* a sufficient number of bytes from the bucket to transmit
* the first PDU in the queue */
msecs = (fcqe->llc_pdu_len * 1000) / fc->bucket_leak_rate;
/* FIXME: add that time to fc->time_last_pdu and subtract it from
* current time */
timer: add osmo_timer_setup() Add a new function timer function to set up the timer, similar to what we have in the Linux kernel. This patch also converts existing opencoded timer setup in the libosmocore tree as initial client of this new function. This patch implicitly removes function callback passed by reference that defeat compile time type validation. Compile-tested only, but I ran make check that reports success when testing timer infrastructure. Change-Id: I2fa49972ecaab3748b25168b26d92034e9145666
2017-05-08 16:00:28 +00:00
osmo_timer_setup(&fc->timer, fc_timer_cb, fc);
BSSGP: prevent divide-by-zero in flow control If the BTS tells us to not send any data at all anymore (bucket leak rate of 0 bits per second), then we should respect this and not run into a divide-by-zero. However, as this indicates complete overload, we print a log message to that regard.
2013-06-22 07:44:00 +00:00
osmo_timer_schedule(&fc->timer, msecs / 1000, (msecs % 1000) * 1000);
} else {
/* If the PCU is telling us to not send any more data at all,
* there's no point starting a timer. */
}
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
return 0;
}
/* Enqueue a PDU in the flow control queue for delayed transmission */
static int fc_enqueue(struct bssgp_flow_control *fc, struct msgb *msg,
uint32_t llc_pdu_len, void *priv)
{
struct bssgp_fc_queue_element *fcqe;
if (fc->queue_depth >= fc->max_queue_depth)
return -ENOSPC;
fcqe = talloc_zero(fc, struct bssgp_fc_queue_element);
if (!fcqe)
return -ENOMEM;
fcqe->msg = msg;
fcqe->llc_pdu_len = llc_pdu_len;
fcqe->priv = priv;
llist_add_tail(&fcqe->list, &fc->queue);
fc->queue_depth++;
/* re-configure the timer for dequeueing the pdu */
fc_queue_timer_cfg(fc);
return 0;
}
/* According to Section 8.2 */
static int bssgp_fc_needs_queueing(struct bssgp_flow_control *fc, uint32_t pdu_len)
{
struct timeval time_now, time_diff;
int64_t bucket_predicted;
uint32_t csecs_elapsed, leaked;
/* B' = B + L(p) - (Tc - Tp)*R */
/* compute number of centi-seconds that have elapsed since transmitting
* the last PDU (Tc - Tp) */
add osmo_gettimeofday as a shim around gettimeofday This allows feeding a custom time for unit tests by overriding osmo_gettimeofday. Change-Id: Ic7a81a6eb51f27fe452962b91f2eae2070d87089
2016-09-22 01:58:13 +00:00
osmo_gettimeofday(&time_now, NULL);
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
timersub(&time_now, &fc->time_last_pdu, &time_diff);
csecs_elapsed = time_diff.tv_sec*100 + time_diff.tv_usec/10000;
/* compute number of bytes that have leaked in the elapsed number
* of centi-seconds */
leaked = csecs_elapsed * (fc->bucket_leak_rate / 100);
/* add the current PDU length to the last bucket level */
bucket_predicted = fc->bucket_counter + pdu_len;
/* ... and subtract the number of leaked bytes */
bucket_predicted -= leaked;
gb/gprs_bssgp.c: avoid valueless goto usage Change-Id: I0c2aaf1ab462c923d62232f1a63fae1e4eb18b4d
2017-06-11 20:41:35 +00:00
if (bucket_predicted < pdu_len)
return 0;
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
if (bucket_predicted <= fc->bucket_size_max) {
/* the bucket is not full yet, we can pass the packet */
fc->bucket_counter = bucket_predicted;
gb/gprs_bssgp.c: avoid valueless goto usage Change-Id: I0c2aaf1ab462c923d62232f1a63fae1e4eb18b4d
2017-06-11 20:41:35 +00:00
return 0;
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
}
/* bucket is full, PDU needs to be delayed */
return 1;
}
/* output callback for BVC flow control */
static int _bssgp_tx_dl_ud(struct bssgp_flow_control *fc, struct msgb *msg,
uint32_t llc_pdu_len, void *priv)
{
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
return bssgp_ns_send(bssgp_ns_send_data, msg);
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
}
/* input function of the flow control implementation, called first
* for the MM flow control, and then as the MM flow control output
* callback in order to perform BVC flow control */
int bssgp_fc_in(struct bssgp_flow_control *fc, struct msgb *msg,
uint32_t llc_pdu_len, void *priv)
{
struct timeval time_now;
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
if (llc_pdu_len > fc->bucket_size_max) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_NOTICE, "Single PDU (size=%u) is larger "
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
"than maximum bucket size (%u)!\n", llc_pdu_len,
fc->bucket_size_max);
bssgp: Free msgb in case of error when calling into gprs_ns_sendmsg In the OsmoSGSN we have a crash with a DEAD/BLOCKED GPRS-NS and segmented SN-UNITDATA. For the caller it is not easy to know if the passed msg buffer has been freed or not. The most easy solution is to always take the ownership and either pass it on or free it in case of an error. Adjust indirect and direct callers of gprs_ns_sendmsg. I found the following call-chains with an external msgb parameter. gprs_ns_sendmsg <- _bssgp_tx_dl_ud <- bssgp_fc_in <- bssgp_tx_dl_ud Update the test to allocate a real msgb because for the test with '1000' we will msgb_free it right away. Sponsored-by: On-Waves ehf
2014-10-10 15:24:34 +00:00
msgb_free(msg);
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
return -EIO;
}
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
if (bssgp_fc_needs_queueing(fc, llc_pdu_len)) {
gprs_bssgp: bssgp_fc_in(): fix mem leak on queue overflow All successful and all error code paths of bssgp_fc_in() free the msgb, except the code path calling fc_enqueue() when the msg is dropped (due to queue being full, or failure to allocate). Callers could theoretically catch the -ENOSPC return value and discard the msgb. However, in other code paths, a callback's return value is returned, which is expected to free the msgb, so such callback would have to never return -ENOSPC when it freed the msgb. Much simpler semantics would be to free the msgb in every code path, no matter which kind of error occurred. Who is currently calling bssgp_fc_in and how do they handle the return value? - bssgp_fc_test.c ignores the return value (and hits a mem leak aka sanitizer build failure if the queue is full). - fc_timer_cb() ignores the return value. - bssgp_tx_dl_ud() returns the bssgp_fc_in() rc. - which is returned by a cascade of functions leading up to being returned, for example, by gprs_llgmm_reset(), which is usually called with ignored return code. At this point it is already fairly clear that bssgp_fc_in() should always free the msgb, since the callers don't seem to distinguish even between error or success, let alone between -ENOSPC or other errors. bssgp_fc_test: assert that no msgbs remain unfreed after the tests. Adjust expected results. Helps fix sanitizer build on debian 9. Change-Id: I00c62a104baeaad6a85883c380259c469aebf0df
2017-11-16 21:32:36 +00:00
int rc;
rc = fc_enqueue(fc, msg, llc_pdu_len, priv);
if (rc)
msgb_free(msg);
return rc;
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
} else {
/* record the time we transmitted this PDU */
add osmo_gettimeofday as a shim around gettimeofday This allows feeding a custom time for unit tests by overriding osmo_gettimeofday. Change-Id: Ic7a81a6eb51f27fe452962b91f2eae2070d87089
2016-09-22 01:58:13 +00:00
osmo_gettimeofday(&time_now, NULL);
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
fc->time_last_pdu = time_now;
return fc->out_cb(priv, msg, llc_pdu_len, NULL);
}
}
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
/* Initialize the Flow Control structure */
void bssgp_fc_init(struct bssgp_flow_control *fc,
uint32_t bucket_size_max, uint32_t bucket_leak_rate,
uint32_t max_queue_depth,
int (*out_cb)(struct bssgp_flow_control *fc, struct msgb *msg,
uint32_t llc_pdu_len, void *priv))
{
fc->out_cb = out_cb;
fc->bucket_size_max = bucket_size_max;
fc->bucket_leak_rate = bucket_leak_rate;
fc->max_queue_depth = max_queue_depth;
INIT_LLIST_HEAD(&fc->queue);
add osmo_gettimeofday as a shim around gettimeofday This allows feeding a custom time for unit tests by overriding osmo_gettimeofday. Change-Id: Ic7a81a6eb51f27fe452962b91f2eae2070d87089
2016-09-22 01:58:13 +00:00
osmo_gettimeofday(&fc->time_last_pdu, NULL);
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
}
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
/* Initialize the Flow Control parameters for a new MS according to
* default values for the BVC specified by BVCI and NSEI */
int bssgp_fc_ms_init(struct bssgp_flow_control *fc_ms, uint16_t bvci,
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
uint16_t nsei, uint32_t max_queue_depth)
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
{
struct bssgp_bvc_ctx *ctx;
ctx = btsctx_by_bvci_nsei(bvci, nsei);
if (!ctx)
return -ENODEV;
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
/* output call-back of per-MS FC is per-CTX FC */
bssgp_fc_init(fc_ms, ctx->bmax_default_ms, ctx->r_default_ms,
max_queue_depth, bssgp_fc_in);
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
return 0;
}
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
static int bssgp_rx_fc_bvc(struct msgb *msg, struct tlv_parsed *tp,
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *bctx)
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
{
BSSGP: prevent divide-by-zero in flow control If the BTS tells us to not send any data at all anymore (bucket leak rate of 0 bits per second), then we should respect this and not run into a divide-by-zero. However, as this indicates complete overload, we print a log message to that regard.
2013-06-22 07:44:00 +00:00
uint32_t old_leak_rate = bctx->fc->bucket_leak_rate;
uint32_t old_r_def_ms = bctx->r_default_ms;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx Flow Control BVC\n",
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
bctx->bvci);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_TAG, 1) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_BVC_BUCKET_SIZE, 2) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_BUCKET_LEAK_RATE, 2) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_BMAX_DEFAULT_MS, 2) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_R_DEFAULT_MS,2)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP BVCI=%u Rx FC BVC "
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
"missing mandatory IE\n", bctx->bvci);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
}
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
/* 11.3.5 Bucket Size in 100 octets unit */
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
bctx->fc->bucket_size_max = 100 * tlvp_val16be(tp, BSSGP_IE_BVC_BUCKET_SIZE);
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
/* 11.3.4 Bucket Leak Rate in 100 bits/sec unit */
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
bctx->fc->bucket_leak_rate = 100 * tlvp_val16be(tp, BSSGP_IE_BUCKET_LEAK_RATE) / 8;
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
/* 11.3.2 in octets */
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
bctx->bmax_default_ms = tlvp_val16be(tp, BSSGP_IE_BMAX_DEFAULT_MS);
BSSGP flow-control: various fixes * add more comments on units of struct members * make sure to parsre FC-BVC message correctly * add error message in case user passes PDU larger than bucket size * add new function to initialize flow control struct
2012-09-07 08:22:01 +00:00
/* 11.3.32 Bucket Leak rate in 100bits/sec unit */
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
bctx->r_default_ms = 100 * tlvp_val16be(tp, BSSGP_IE_R_DEFAULT_MS) / 8;
[gprs] SGSN: Expect all Identifiers to be stored at highest level We now expect the highest level (actual SGSN GMM code) to know all identifiers for every element in the protocol stack, i.e. TLLI, SAPI, BVCI and NSEI. The layer-inetrnal state is looked up based on those identifiers. The reason for this is to ensure only the highest level state needs to be persistent, while everything else can be regenerated dynamically (e.g. in a SGSN restart)
2010-05-02 09:19:37 +00:00
BSSGP: prevent divide-by-zero in flow control If the BTS tells us to not send any data at all anymore (bucket leak rate of 0 bits per second), then we should respect this and not run into a divide-by-zero. However, as this indicates complete overload, we print a log message to that regard.
2013-06-22 07:44:00 +00:00
if (old_leak_rate != 0 && bctx->fc->bucket_leak_rate == 0)
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_NOTICE, "BSS instructs us to bucket leak "
BSSGP: prevent divide-by-zero in flow control If the BTS tells us to not send any data at all anymore (bucket leak rate of 0 bits per second), then we should respect this and not run into a divide-by-zero. However, as this indicates complete overload, we print a log message to that regard.
2013-06-22 07:44:00 +00:00
"rate of 0, stopping all DL GPRS!\n");
else if (old_leak_rate == 0 && bctx->fc->bucket_leak_rate != 0)
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_NOTICE, "BSS instructs us to bucket leak "
BSSGP: prevent divide-by-zero in flow control If the BTS tells us to not send any data at all anymore (bucket leak rate of 0 bits per second), then we should respect this and not run into a divide-by-zero. However, as this indicates complete overload, we print a log message to that regard.
2013-06-22 07:44:00 +00:00
"rate of != 0, restarting all DL GPRS!\n");
if (old_r_def_ms != 0 && bctx->r_default_ms == 0)
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_NOTICE, "BSS instructs us to MS default "
BSSGP: prevent divide-by-zero in flow control If the BTS tells us to not send any data at all anymore (bucket leak rate of 0 bits per second), then we should respect this and not run into a divide-by-zero. However, as this indicates complete overload, we print a log message to that regard.
2013-06-22 07:44:00 +00:00
"bucket leak rate of 0, stopping DL GPRS!\n");
else if (old_r_def_ms == 0 && bctx->r_default_ms != 0)
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_NOTICE, "BSS instructs us to MS default "
BSSGP: prevent divide-by-zero in flow control If the BTS tells us to not send any data at all anymore (bucket leak rate of 0 bits per second), then we should respect this and not run into a divide-by-zero. However, as this indicates complete overload, we print a log message to that regard.
2013-06-22 07:44:00 +00:00
"bucket leak rate != 0, restarting DL GPRS!\n");
/* reconfigure the timer for flow control based on new values */
fc_queue_timer_cfg(bctx->fc);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
/* Send FLOW_CONTROL_BVC_ACK */
gprs: remove msgb->nsvc pointer and replace it with NSEI and BVCI According to TS 08.16, the BSSGP layer needs to specify NSEI and BVCI when executing the NS UNITDATA REQUEST primitive of the underlying NS layer. Rather than passing around a pointer to the 'struct gprs_nsvc', we now have NSEI and BVCI as members of 'struct obsc_msgb_cb' and set them when BSSGP hands a message down to NS. NS then does a lookup of the 'gprs_nsvc' based on the NSEI parameter.
2010-04-30 17:54:29 +00:00
return bssgp_tx_fc_bvc_ack(msgb_nsei(msg), *TLVP_VAL(tp, BSSGP_IE_TAG),
[gprs] SGSN: Expect all Identifiers to be stored at highest level We now expect the highest level (actual SGSN GMM code) to know all identifiers for every element in the protocol stack, i.e. TLLI, SAPI, BVCI and NSEI. The layer-inetrnal state is looked up based on those identifiers. The reason for this is to ensure only the highest level state needs to be persistent, while everything else can be regenerated dynamically (e.g. in a SGSN restart)
2010-05-02 09:19:37 +00:00
msgb_bvci(msg));
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
}
[gprs] Build the SGSN stand-alone and not as part of bsc_hack Instead of continuing to add more and more functionality to the bsc_hack binary, we should have the new SGSN code run as a separate executable. After this commit we now build a 'osmo_sgsn' executable, using its own osmo_sgsn.cfg config file. However, the SGSN is not yet functional, mainly due to the fact that the BSSGP and GMM code are written with the assumption that there is a msgb->trx->bts and the according 'sturct gsm_bts' data model around - which clearly is no longer the case outside of bsc_hack.
2010-05-01 14:48:27 +00:00
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
/* Receive a BSSGP PDU from a BSS on a PTP BVCI */
libgb: make sure all BSSGP functions have bssgp_ prefix We change the minority of functions employing the gprs_bssgp_ prefix to match with the majority without gprs_ in front.
2012-06-17 05:04:02 +00:00
static int bssgp_rx_ptp(struct msgb *msg, struct tlv_parsed *tp,
struct bssgp_bvc_ctx *bctx)
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
{
[gprs] Ensure msgb->l3h points to Layer3 (04.08) In the old code l3h = BSSGP, l4h = LLC, cb[gmmh] = 04.08 Now, this has been changed to cb[bssgph] = BSSGP, cb[llch] = LLC, l3h = 04.08 This way, GSM general 04.08 and GPRS 04.08 code can expect a GSM 04.08 header at msgb->l3h
2010-05-02 07:50:42 +00:00
struct bssgp_normal_hdr *bgph =
(struct bssgp_normal_hdr *) msgb_bssgph(msg);
[gprs] SGSN: Expect all Identifiers to be stored at highest level We now expect the highest level (actual SGSN GMM code) to know all identifiers for every element in the protocol stack, i.e. TLLI, SAPI, BVCI and NSEI. The layer-inetrnal state is looked up based on those identifiers. The reason for this is to ensure only the highest level state needs to be persistent, while everything else can be regenerated dynamically (e.g. in a SGSN restart)
2010-05-02 09:19:37 +00:00
uint8_t pdu_type = bgph->pdu_type;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
int rc = 0;
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
OSMO_ASSERT(pdu_type != BSSGP_PDUT_STATUS);
[GPRS] BSSGP: Refuse blocking of signalling BVC; Ignore traffic on blocked BVC
2010-05-13 19:45:23 +00:00
/* If traffic is received on a BVC that is marked as blocked, the
* received PDU shall not be accepted and a STATUS PDU (Cause value:
* BVC Blocked) shall be sent to the peer entity on the signalling BVC */
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
if (bctx->state & BVC_S_BLOCKED) {
[GPRS] BSSGP: Refuse blocking of signalling BVC; Ignore traffic on blocked BVC
2010-05-13 19:45:23 +00:00
uint16_t bvci = msgb_bvci(msg);
return bssgp_tx_status(BSSGP_CAUSE_BVCI_BLOCKED, &bvci, msg);
}
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
switch (pdu_type) {
case BSSGP_PDUT_UL_UNITDATA:
/* some LLC data from the MS */
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
rc = bssgp_rx_ul_ud(msg, tp, bctx);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
case BSSGP_PDUT_RA_CAPABILITY:
/* BSS requests RA capability or IMSI */
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx RA CAPABILITY UPDATE\n",
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
bctx->bvci);
[GPRS] BSSGP: Elaborate more on FIXMEs And fix mistake regarding FLUSH-LL / FLUSH-LL-ACK direction
2010-05-13 17:41:31 +00:00
/* FIXME: send GMM_RA_CAPABILITY_UPDATE.ind to GMM */
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
/* FIXME: send RA_CAPA_UPDATE_ACK */
break;
case BSSGP_PDUT_RADIO_STATUS:
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx RADIO STATUS\n", bctx->bvci);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
/* BSS informs us of some exception */
[GPRS] BSSGP: Elaborate more on FIXMEs And fix mistake regarding FLUSH-LL / FLUSH-LL-ACK direction
2010-05-13 17:41:31 +00:00
/* FIXME: send GMM_RADIO_STATUS.ind to GMM */
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
case BSSGP_PDUT_FLOW_CONTROL_BVC:
/* BSS informs us of available bandwidth in Gb interface */
rc = bssgp_rx_fc_bvc(msg, tp, bctx);
break;
case BSSGP_PDUT_FLOW_CONTROL_MS:
/* BSS informs us of available bandwidth to one MS */
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx Flow Control MS\n",
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
bctx->bvci);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
/* FIXME: actually implement flow control */
/* FIXME: Send FLOW_CONTROL_MS_ACK */
break;
case BSSGP_PDUT_STATUS:
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
/* This is already handled in bssgp_rcvmsg() */
bssgp: Don't reply with STATUS when receiving a PtP STATUS message Currently each incoming PtP BSSGP STATUS message is handled as 'not yet implemented' and a BSSGP STATUS message (cause BSSGP_CAUSE_PROTO_ERR_UNSPEC) is sent back to the peer. This will cause endless messages loops if both peers use this BSSGP stack implementation. This does not apply to signalling messages. This commit changes the implementation of bssgp_rx_ptp() to just do logging in this case. Sponsored-by: On-Waves ehf
2015-03-17 09:21:16 +00:00
break;
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
case BSSGP_PDUT_BVC_RESET:
rc = bssgp_rx_bvc_reset(msg, tp, bctx->bvci);
break;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
case BSSGP_PDUT_DOWNLOAD_BSS_PFC:
case BSSGP_PDUT_CREATE_BSS_PFC_ACK:
case BSSGP_PDUT_CREATE_BSS_PFC_NACK:
case BSSGP_PDUT_MODIFY_BSS_PFC:
case BSSGP_PDUT_DELETE_BSS_PFC_ACK:
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx PDU type %s not [yet] "
Improve BSSGP debug output Print string representation of Cause IE and PDU type instead of numerical value.
2016-03-17 14:42:26 +00:00
"implemented\n", bctx->bvci, bssgp_pdu_str(pdu_type));
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
rc = bssgp_tx_status(BSSGP_CAUSE_PDU_INCOMP_FEAT, NULL, msg);
break;
/* those only exist in the SGSN -> BSS direction */
case BSSGP_PDUT_DL_UNITDATA:
case BSSGP_PDUT_PAGING_PS:
case BSSGP_PDUT_PAGING_CS:
case BSSGP_PDUT_RA_CAPA_UPDATE_ACK:
case BSSGP_PDUT_FLOW_CONTROL_BVC_ACK:
case BSSGP_PDUT_FLOW_CONTROL_MS_ACK:
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u PDU type %s only exists in DL\n",
Improve BSSGP debug output Print string representation of Cause IE and PDU type instead of numerical value.
2016-03-17 14:42:26 +00:00
bctx->bvci, bssgp_pdu_str(pdu_type));
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
bssgp_tx_status(BSSGP_CAUSE_PROTO_ERR_UNSPEC, NULL, msg);
rc = -EINVAL;
break;
default:
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u PDU type %s unknown\n",
Improve BSSGP debug output Print string representation of Cause IE and PDU type instead of numerical value.
2016-03-17 14:42:26 +00:00
bctx->bvci, bssgp_pdu_str(pdu_type));
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
rc = bssgp_tx_status(BSSGP_CAUSE_PROTO_ERR_UNSPEC, NULL, msg);
break;
}
gprs_bssgp.c: Return something from non void methods. In one use the rc variable we are assigning to, in the others return 0 even if we have a FIXME there.
2010-05-23 13:12:15 +00:00
return rc;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
}
/* Receive a BSSGP PDU from a BSS on a SIGNALLING BVCI */
libgb: make sure all BSSGP functions have bssgp_ prefix We change the minority of functions employing the gprs_bssgp_ prefix to match with the majority without gprs_ in front.
2012-06-17 05:04:02 +00:00
static int bssgp_rx_sign(struct msgb *msg, struct tlv_parsed *tp,
struct bssgp_bvc_ctx *bctx)
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
{
struct bssgp_normal_hdr *bgph =
(struct bssgp_normal_hdr *) msgb_bssgph(msg);
uint8_t pdu_type = bgph->pdu_type;
int rc = 0;
uint16_t ns_bvci = msgb_bvci(msg);
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
uint16_t bvci = bctx ? bctx->bvci : ns_bvci;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
switch (bgph->pdu_type) {
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
case BSSGP_PDUT_SUSPEND:
/* MS wants to suspend */
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
rc = bssgp_rx_suspend(msg, tp);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
case BSSGP_PDUT_RESUME:
/* MS wants to resume */
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
rc = bssgp_rx_resume(msg, tp);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
[GPRS] BSSGP: Elaborate more on FIXMEs And fix mistake regarding FLUSH-LL / FLUSH-LL-ACK direction
2010-05-13 17:41:31 +00:00
case BSSGP_PDUT_FLUSH_LL_ACK:
/* BSS informs us it has performed LL FLUSH */
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP Rx BVCI=%u FLUSH LL ACK\n", bvci);
[GPRS] BSSGP: Elaborate more on FIXMEs And fix mistake regarding FLUSH-LL / FLUSH-LL-ACK direction
2010-05-13 17:41:31 +00:00
/* FIXME: send NM_FLUSH_LL.res to NM */
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
case BSSGP_PDUT_LLC_DISCARD:
/* BSS informs that some LLC PDU's have been discarded */
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
if (!bctx) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR,
gprs: Don't discard SUSPEND/RESUME in bssgp_rcvmsg Currently sending SUSPEND/RESUME messages to this function (like it is done in the osmo-sgsn) results in STATUS messages complaining about an unknown BVCI. The reason is, that these messages rely on a TLLI/RAI pair to identify the context and do not contain an explicit BVCI. This patch modifies bssgp_rcvmsg() to only complain about and unknown BVCI if one is given but a matching context is not found (except for RESET messages). The ctx argument is removed from the functions handling SUSPEND and RESUME since it will always be NULL then. Sponsored-by: On-Waves ehf
2014-09-10 10:43:28 +00:00
"BSSGP Rx LLC-DISCARD missing mandatory BVCI\n");
goto err_mand_ie;
}
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
rc = bssgp_rx_llc_disc(msg, tp, bctx);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
case BSSGP_PDUT_BVC_BLOCK:
/* BSS tells us that BVC shall be blocked */
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_BVCI, 2) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_CAUSE, 1)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP Rx BVC-BLOCK "
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
"missing mandatory IE\n");
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
goto err_mand_ie;
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
}
[GPRS] BSSGP: When we receive a BLOCK, we should not respond with UNBLOCK-ACK
2010-05-31 15:16:36 +00:00
rc = bssgp_rx_bvc_block(msg, tp);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
case BSSGP_PDUT_BVC_UNBLOCK:
/* BSS tells us that BVC shall be unblocked */
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_BVCI, 2)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP Rx BVC-UNBLOCK "
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
"missing mandatory IE\n");
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
goto err_mand_ie;
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
}
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
rc = bssgp_rx_bvc_unblock(msg, tp);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
BSSGP: handle BVC-RESET-ACK That's necessary for SGSN to properly handle BSS response to reset procedure initiated by SGSN (foe example via 'bssgp bvc nsei 101 bvci 0 reset' command). According to 3GPP TS 48.018 §8.4 "after performing the BVC Reset procedure all affected BVCs are assumed to be unblocked at the SGSN" so there's no need in any special handling. Change-Id: I90dfbd0195a8403406429ccc746299d072445f7b Related: OS#1638
2017-06-28 12:29:24 +00:00
case BSSGP_PDUT_BVC_RESET_ACK:
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP BVCI=%u Rx BVC-RESET-ACK\n", bvci);
BSSGP: handle BVC-RESET-ACK That's necessary for SGSN to properly handle BSS response to reset procedure initiated by SGSN (foe example via 'bssgp bvc nsei 101 bvci 0 reset' command). According to 3GPP TS 48.018 §8.4 "after performing the BVC Reset procedure all affected BVCs are assumed to be unblocked at the SGSN" so there's no need in any special handling. Change-Id: I90dfbd0195a8403406429ccc746299d072445f7b Related: OS#1638
2017-06-28 12:29:24 +00:00
break;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
case BSSGP_PDUT_BVC_RESET:
gprs_bssgp: add support for SGSN oriented RESET To support SGSN oriented RESET introduce a role flag to track what's running the gprs_bssgp (local side). Related: OS#3879 Change-Id: Ibcbaffa94cbdc4296a8a7c372304ac11d50d9559
2021-02-17 01:30:33 +00:00
/* SGSN or BSS tells us that BVC init is required */
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (!TLVP_PRES_LEN(tp, BSSGP_IE_BVCI, 2) ||
!TLVP_PRES_LEN(tp, BSSGP_IE_CAUSE, 1)) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "BSSGP Rx BVC-RESET "
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
"missing mandatory IE\n");
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
goto err_mand_ie;
[GPRS] BSSGP: More verbose debug log / error reporting
2010-05-31 16:07:17 +00:00
}
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
rc = bssgp_rx_bvc_reset(msg, tp, ns_bvci);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
case BSSGP_PDUT_STATUS:
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
/* This is already handled in bssgp_rcvmsg() */
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
gprs_bssgp: add handling for BSSGP RIM primitives Receive and forward RIM messages to bssgp_prim_cb() Change-Id: Idfd0a65872a2cc6089885afd8d31b0b029d85d47 Related: SYS#5103
2020-12-16 20:07:04 +00:00
case BSSGP_PDUT_RAN_INFO:
case BSSGP_PDUT_RAN_INFO_REQ:
case BSSGP_PDUT_RAN_INFO_ACK:
case BSSGP_PDUT_RAN_INFO_ERROR:
case BSSGP_PDUT_RAN_INFO_APP_ERROR:
gprs_bssgp: add utilities to send and parse BSSGP rim PDUs At the moment libosmogb offers no convinient way to send RIM PDUs. Also parsing an incoming RIM messages into destination, source routing info and RIM container is not available. Change-Id: I18134fd9938040d2facb6beee3732628b167ce8c Related: SYS#5103
2021-01-07 20:55:48 +00:00
rc = bssgp_rx_rim(msg, tp, bvci);
gprs_bssgp: add handling for BSSGP RIM primitives Receive and forward RIM messages to bssgp_prim_cb() Change-Id: Idfd0a65872a2cc6089885afd8d31b0b029d85d47 Related: SYS#5103
2020-12-16 20:07:04 +00:00
break;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
/* those only exist in the SGSN -> BSS direction */
case BSSGP_PDUT_PAGING_PS:
case BSSGP_PDUT_PAGING_CS:
case BSSGP_PDUT_SUSPEND_ACK:
case BSSGP_PDUT_SUSPEND_NACK:
case BSSGP_PDUT_RESUME_ACK:
case BSSGP_PDUT_RESUME_NACK:
[GPRS] BSSGP: Elaborate more on FIXMEs And fix mistake regarding FLUSH-LL / FLUSH-LL-ACK direction
2010-05-13 17:41:31 +00:00
case BSSGP_PDUT_FLUSH_LL:
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
case BSSGP_PDUT_BVC_BLOCK_ACK:
case BSSGP_PDUT_BVC_UNBLOCK_ACK:
case BSSGP_PDUT_SGSN_INVOKE_TRACE:
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx PDU type %s only exists in DL\n",
Improve BSSGP debug output Print string representation of Cause IE and PDU type instead of numerical value.
2016-03-17 14:42:26 +00:00
bvci, bssgp_pdu_str(pdu_type));
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
bssgp_tx_status(BSSGP_CAUSE_PROTO_ERR_UNSPEC, NULL, msg);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
rc = -EINVAL;
break;
default:
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
DEBUGP(DLBSSGP, "BSSGP BVCI=%u Rx PDU type %s unknown\n",
Improve BSSGP debug output Print string representation of Cause IE and PDU type instead of numerical value.
2016-03-17 14:42:26 +00:00
bvci, bssgp_pdu_str(pdu_type));
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
rc = bssgp_tx_status(BSSGP_CAUSE_PROTO_ERR_UNSPEC, NULL, msg);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
break;
}
return rc;
err_mand_ie:
return bssgp_tx_status(BSSGP_CAUSE_MISSING_MAND_IE, NULL, msg);
}
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
/* We expect msgb_bssgph() to point to the BSSGP header */
libgb: make sure all BSSGP functions have bssgp_ prefix We change the minority of functions employing the gprs_bssgp_ prefix to match with the majority without gprs_ in front.
2012-06-17 05:04:02 +00:00
int bssgp_rcvmsg(struct msgb *msg)
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
{
struct bssgp_normal_hdr *bgph =
(struct bssgp_normal_hdr *) msgb_bssgph(msg);
struct bssgp_ud_hdr *budh = (struct bssgp_ud_hdr *) msgb_bssgph(msg);
struct tlv_parsed tp;
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *bctx;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
uint8_t pdu_type = bgph->pdu_type;
uint16_t ns_bvci = msgb_bvci(msg);
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
uint16_t nsei = msgb_nsei(msg);
gprs: Fix bssgp_rcvmsg to handle signalling msgs with BVCI IE Currently BSSGP messages with an NS BVCI of 0 (signalling) are discarded if they aren't RESET messages. Thus valid signalling messages (e.g. BLOCK) are not handled properly, because the BVCI IE is ignored if it present. Instead a STATUS message referring to BVCI 0 (instead of the BVCI used in the BLOCK message) is returned. This patch changes the implementation to use the BVCI contained in the BVCI IE if that is present in a signalling message. It fixes BSSGP BLOCK/UNBLOCK for the osmo-sgsn. Note that signalling messages without an BVCI IE (e.g. SUSPEND/RESUME) are still rejected. Ticket: OW#1205 Sponsored-by: On-Waves ehf
2014-09-23 11:28:22 +00:00
uint16_t bvci = ns_bvci;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
int data_len;
int rc = 0;
/* Identifiers from DOWN: NSEI, BVCI (both in msg->cb) */
/* UNITDATA BSSGP headers have TLLI in front */
if (pdu_type != BSSGP_PDUT_UL_UNITDATA &&
pdu_type != BSSGP_PDUT_DL_UNITDATA) {
data_len = msgb_bssgp_len(msg) - sizeof(*bgph);
rc = bssgp_tlv_parse(&tp, bgph->data, data_len);
} else {
data_len = msgb_bssgp_len(msg) - sizeof(*budh);
rc = bssgp_tlv_parse(&tp, budh->data, data_len);
}
check bssgp_tlv_parse() return code in bssgp_rcvmsg() The return code from bssgp_tlv_parse() was not checked for a parsing error. In case of a parsing error the stored return code could have been overwritten later in this function. Explicitly check for a parsing error and log corresponding packets. Change-Id: Id3d7c52ec3df2bcf4efcee0e0b14fe22ef96964e Related: OS#3178
2018-06-25 10:20:43 +00:00
if (rc < 0) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "Failed to parse BSSGP %s message. Invalid message was: %s\n",
check bssgp_tlv_parse() return code in bssgp_rcvmsg() The return code from bssgp_tlv_parse() was not checked for a parsing error. In case of a parsing error the stored return code could have been overwritten later in this function. Explicitly check for a parsing error and log corresponding packets. Change-Id: Id3d7c52ec3df2bcf4efcee0e0b14fe22ef96964e Related: OS#3178
2018-06-25 10:20:43 +00:00
bssgp_pdu_str(pdu_type), msgb_hexdump(msg));
return error to sender upon bssgp_tlv_parse() failure Return "invalid mandatory information" error status to the sender in case bssgp_tlv_parse() failed. To avoid loops, do not respond with an error status to STATUS PDUs which failed parsing. Change-Id: If73719b75a94d6742bdefc9b6572525cb00a96ee Related: OS#3178
2018-06-25 10:20:43 +00:00
if (pdu_type != BSSGP_PDUT_STATUS)
return bssgp_tx_status(BSSGP_CAUSE_INV_MAND_INF, NULL, msg);
check bssgp_tlv_parse() return code in bssgp_rcvmsg() The return code from bssgp_tlv_parse() was not checked for a parsing error. In case of a parsing error the stored return code could have been overwritten later in this function. Explicitly check for a parsing error and log corresponding packets. Change-Id: Id3d7c52ec3df2bcf4efcee0e0b14fe22ef96964e Related: OS#3178
2018-06-25 10:20:43 +00:00
return rc;
}
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
bssgp: Use TLVP_PRES_LEN instead of TLVP_PRESENT With TLVP_PRESENT we only check if a given TLV/IE is present, but don't verify that it's length matches our expectation. This can lead to out-of-bounds reads, so let's always use TLVP_PRES_LEN. Change-Id: I56e8b31ce51602d2681e3db501c48f84bfe7e438
2020-12-03 14:53:59 +00:00
if (bvci == BVCI_SIGNALLING && TLVP_PRES_LEN(&tp, BSSGP_IE_BVCI, 2))
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
bvci = tlvp_val16be(&tp, BSSGP_IE_BVCI);
gprs: Fix bssgp_rcvmsg to handle signalling msgs with BVCI IE Currently BSSGP messages with an NS BVCI of 0 (signalling) are discarded if they aren't RESET messages. Thus valid signalling messages (e.g. BLOCK) are not handled properly, because the BVCI IE is ignored if it present. Instead a STATUS message referring to BVCI 0 (instead of the BVCI used in the BLOCK message) is returned. This patch changes the implementation to use the BVCI contained in the BVCI IE if that is present in a signalling message. It fixes BSSGP BLOCK/UNBLOCK for the osmo-sgsn. Note that signalling messages without an BVCI IE (e.g. SUSPEND/RESUME) are still rejected. Ticket: OW#1205 Sponsored-by: On-Waves ehf
2014-09-23 11:28:22 +00:00
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
/* look-up or create the BTS context for this BVC */
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
bctx = btsctx_by_bvci_nsei(bvci, nsei);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
[GPRS] BSSGP: Introduce packet/byte counters
2010-05-17 21:30:01 +00:00
if (bctx) {
logging.h: fixup: shorter names for LOGGING_FILTER_* and LOGGING_CTX_* My recent logging patch was merged to master a bit too soon. Accomodate the request for naming that matches the general "LOG" prefix instead of "LOGGING". libosmocore will not be backwards-compatible with the few commits from change-id I5c343630020f4b108099696fd96c2111614c8067 up to this one. This and following commits are backwards compatible with those before that short window. See also: * openbsc change-id Ib2ec5e4884aa90f48051ee2f832af557aa525991 * osmo-pcu change-id I4db4a668f2be07f3d55f848d38d1b490d8a7a685 Change-Id: I424fe3f12ea620338902b2bb8230544bde3f1a93
2017-02-23 17:03:28 +00:00
log_set_context(LOG_CTX_GB_BVC, bctx);
Use new stat item/ctr getter APIs Generated with spatch: """ @@ expression E1, E2; @@ - &E2->ctr[E1] + rate_ctr_group_get_ctr(E2, E1) """ """ @@ expression E1, E2, E3; @@ - E2->items[E1] + osmo_stat_item_group_get_item(E2, E1) """ Change-Id: I41297a8df68e28dfc6016330ac82b0ed5dd0ebc1
2021-06-04 16:17:12 +00:00
rate_ctr_inc(rate_ctr_group_get_ctr(bctx->ctrg, BSSGP_CTR_PKTS_IN));
rate_ctr_add(rate_ctr_group_get_ctr(bctx->ctrg, BSSGP_CTR_BYTES_IN),
[GPRS] BSSGP: Introduce packet/byte counters
2010-05-17 21:30:01 +00:00
msgb_bssgp_len(msg));
}
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
/* Always handle STATUS PDUs, even if they contain an invalid BVCI or
* are otherwise unexpected */
if (pdu_type == BSSGP_PDUT_STATUS)
/* Some exception has occurred */
return bssgp_rx_status(msg, &tp, bvci, bctx);
/* Only a RESET PDU can create a new BVC context, otherwise it must be
* registered if a BVCI is given. */
if (!bctx && bvci != BVCI_SIGNALLING &&
pdu_type != BSSGP_PDUT_BVC_RESET) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_NOTICE, "NSEI=%u/BVCI=%u Rejecting PDU type %s for unknown BVCI\n", nsei, bvci,
Improve BSSGP debug output Print string representation of Cause IE and PDU type instead of numerical value.
2016-03-17 14:42:26 +00:00
bssgp_pdu_str(pdu_type));
bssgp: Handle BSSGP STATUS messages Currently incoming BSSGP STATUS messages are just logged and no other action is taken. This makes it impossible for higher layers to react to failures which are indicated by corresponding STATUS messages unless a timeout is triggered as a result of that failure later on. This commit adds a bssgp_rx_status() function and calls it on incoming STATUS messages. That function logs a message, increments the new BSSGP_CTR_STATUS counter if the bctx context exists and invokes an NM_STATUS status indication. The latter will allow the application to handle failures immediately. Since all STATUS messages should be handled, the function is already called in bssgp_rcvmsg and the message is no longer handled in (and will not reach) bssgp_rx_sign and bssgp_rx_ptp. Ticket: OW#1414 Sponsored-by: On-Waves ehf
2015-03-17 09:21:17 +00:00
return bssgp_tx_status(BSSGP_CAUSE_UNKNOWN_BVCI, &bvci, msg);
}
[GPRS] BSSGP: Use correct values for SIGNALLING and PTM BVCI
2010-05-18 09:57:08 +00:00
if (ns_bvci == BVCI_SIGNALLING)
libgb: make sure all BSSGP functions have bssgp_ prefix We change the minority of functions employing the gprs_bssgp_ prefix to match with the majority without gprs_ in front.
2012-06-17 05:04:02 +00:00
rc = bssgp_rx_sign(msg, &tp, bctx);
[GPRS] BSSGP: Use correct values for SIGNALLING and PTM BVCI
2010-05-18 09:57:08 +00:00
else if (ns_bvci == BVCI_PTM)
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
rc = bssgp_tx_status(BSSGP_CAUSE_PDU_INCOMP_FEAT, NULL, msg);
bssgp: Ensure non-NULL bctx before calling bssgp_rx_ptp (Coverity) Currently bssgp_rx_ptp might be called with bctx being NULL, when the NS BVCI is neither BVCI_SIGNALLING nor BVCI_PTM, but the message is a BVC_RESET or it contains an BVCI IE != BVCI_SIGNALLING where the BVCI is not known. This patch ensures that bssgp_rx_ptp will only be called with a non-NULL bctx. A log message will be issued, if the bctx is NULL when this was not expected. Fixes: Coverity CID 1040674 Sponsored-by: On-Waves ehf
2015-04-07 15:52:44 +00:00
else if (bctx)
libgb: make sure all BSSGP functions have bssgp_ prefix We change the minority of functions employing the gprs_bssgp_ prefix to match with the majority without gprs_ in front.
2012-06-17 05:04:02 +00:00
rc = bssgp_rx_ptp(msg, &tp, bctx);
bssgp: Ensure non-NULL bctx before calling bssgp_rx_ptp (Coverity) Currently bssgp_rx_ptp might be called with bctx being NULL, when the NS BVCI is neither BVCI_SIGNALLING nor BVCI_PTM, but the message is a BVC_RESET or it contains an BVCI IE != BVCI_SIGNALLING where the BVCI is not known. This patch ensures that bssgp_rx_ptp will only be called with a non-NULL bctx. A log message will be issued, if the bctx is NULL when this was not expected. Fixes: Coverity CID 1040674 Sponsored-by: On-Waves ehf
2015-04-07 15:52:44 +00:00
else
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_NOTICE,
BSSGP: use variable for NSEI Handle NSEI the same way as BVCI is handled: assign it to variable instead of repetitive calls to msgb_nsei() - this simplifies log update in follow-up patches and makes code slightly easier to read. Change-Id: I919a717ca22646849d6ec7f62c677c536db0ed31
2019-03-07 12:49:34 +00:00
"NSEI=%u/BVCI=%u Cannot handle PDU type %s for unknown BVCI, NS BVCI %u\n", nsei, bvci,
bssgp_pdu_str(pdu_type), ns_bvci);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
return rc;
}
libgb: make sure all BSSGP functions have bssgp_ prefix We change the minority of functions employing the gprs_bssgp_ prefix to match with the majority without gprs_ in front.
2012-06-17 05:04:02 +00:00
int bssgp_tx_dl_ud(struct msgb *msg, uint16_t pdu_lifetime,
struct bssgp_dl_ud_par *dup)
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
{
[GPRS] BSSGP: Rename bssgp_bts_ctx to bssgp_bvc_ctx The Context really is about a BVC (BSSGP Virtual Connection). In the case we operate BSSGP on the SGSN side, this corresponds to a link to a BTS.
2010-05-17 20:59:29 +00:00
struct bssgp_bvc_ctx *bctx;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
struct bssgp_ud_hdr *budh;
[gprs] Use stdint.h types (uintXX_t instead of u_intXX_t) libosmocore already uses them, it's time (at least for new code) in openbsc to do the same.
2010-05-02 09:26:34 +00:00
uint8_t llc_pdu_tlv_hdr_len = 2;
libgb: remove dependency of BSSGP to include sgsn/gmm internal structs
2012-06-17 01:31:16 +00:00
uint8_t *llc_pdu_tlv;
[gprs] Use stdint.h types (uintXX_t instead of u_intXX_t) libosmocore already uses them, it's time (at least for new code) in openbsc to do the same.
2010-05-02 09:26:34 +00:00
uint16_t msg_len = msg->len;
[gprs] SGSN: Expect all Identifiers to be stored at highest level We now expect the highest level (actual SGSN GMM code) to know all identifiers for every element in the protocol stack, i.e. TLLI, SAPI, BVCI and NSEI. The layer-inetrnal state is looked up based on those identifiers. The reason for this is to ensure only the highest level state needs to be persistent, while everything else can be regenerated dynamically (e.g. in a SGSN restart)
2010-05-02 09:19:37 +00:00
uint16_t bvci = msgb_bvci(msg);
uint16_t nsei = msgb_nsei(msg);
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
uint16_t _pdu_lifetime = osmo_htons(pdu_lifetime); /* centi-seconds */
[GPRS] Include IMSI and DRX params in BSSGP DL-UD When we send a downlink unit-data request via BSSGP, there is a lot of information that needs to be copied from the mm context, such as the IMSI, DRX parametes, MS radio access parameters, ... This is a quite strange layering violation, since we now need to pass a pointer to the MM ctx from GMM through LLC into BSSGP :(
2010-05-31 20:12:30 +00:00
uint16_t drx_params;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity) Currently the implementation of bssgp_tx_dl_ud conditionally adds some optional IE if dup != NULL. Later on is dereferences dup to access qos_profile and fc, but this without checking dup in advance. This may lead to an segmentation violation fault. This commit changes the value range of the function to only accept dup != NULL. An assertion will fail otherwise. All other explicit checks for non-NULL are removed. Fixes: Coverity CID 1040673 Sponsored-by: On-Waves ehf
2015-04-07 15:52:43 +00:00
OSMO_ASSERT(dup != NULL);
[gprs] SGSN: Expect all Identifiers to be stored at highest level We now expect the highest level (actual SGSN GMM code) to know all identifiers for every element in the protocol stack, i.e. TLLI, SAPI, BVCI and NSEI. The layer-inetrnal state is looked up based on those identifiers. The reason for this is to ensure only the highest level state needs to be persistent, while everything else can be regenerated dynamically (e.g. in a SGSN restart)
2010-05-02 09:19:37 +00:00
/* Identifiers from UP: TLLI, BVCI, NSEI (all in msgb->cb) */
[GPRS] BSSGP: Use correct values for SIGNALLING and PTM BVCI
2010-05-18 09:57:08 +00:00
if (bvci <= BVCI_PTM ) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "Cannot send DL-UD to BVCI %u\n",
[gprs] SGSN: Expect all Identifiers to be stored at highest level We now expect the highest level (actual SGSN GMM code) to know all identifiers for every element in the protocol stack, i.e. TLLI, SAPI, BVCI and NSEI. The layer-inetrnal state is looked up based on those identifiers. The reason for this is to ensure only the highest level state needs to be persistent, while everything else can be regenerated dynamically (e.g. in a SGSN restart)
2010-05-02 09:19:37 +00:00
bvci);
bssgp: Free msgb in case of error when calling into gprs_ns_sendmsg In the OsmoSGSN we have a crash with a DEAD/BLOCKED GPRS-NS and segmented SN-UNITDATA. For the caller it is not easy to know if the passed msg buffer has been freed or not. The most easy solution is to always take the ownership and either pass it on or free it in case of an error. Adjust indirect and direct callers of gprs_ns_sendmsg. I found the following call-chains with an external msgb parameter. gprs_ns_sendmsg <- _bssgp_tx_dl_ud <- bssgp_fc_in <- bssgp_tx_dl_ud Update the test to allocate a real msgb because for the test with '1000' we will msgb_free it right away. Sponsored-by: On-Waves ehf
2014-10-10 15:24:34 +00:00
msgb_free(msg);
[gprs] SGSN: Expect all Identifiers to be stored at highest level We now expect the highest level (actual SGSN GMM code) to know all identifiers for every element in the protocol stack, i.e. TLLI, SAPI, BVCI and NSEI. The layer-inetrnal state is looked up based on those identifiers. The reason for this is to ensure only the highest level state needs to be persistent, while everything else can be regenerated dynamically (e.g. in a SGSN restart)
2010-05-02 09:19:37 +00:00
return -EINVAL;
}
bctx = btsctx_by_bvci_nsei(bvci, nsei);
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
if (!bctx) {
logging: Introduce DLBSSGP logging constant Historically, BSSGP uses a non-constant, user-configurable integer varieable for the logging sub-system. Let's replace this with a statically-allocated library logging constant. This is required if we want to use the subsystem number in e.g. static initialized for osmo_fsm.log_subsys. Change-Id: I506190aae9217c0956e4b5764d1a0c0772268e93
2020-12-07 20:43:51 +00:00
LOGP(DLBSSGP, LOGL_ERROR, "Cannot send DL-UD to unknown BVCI %u\n",
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
bvci);
bssgp: Free msgb in case of error when calling into gprs_ns_sendmsg In the OsmoSGSN we have a crash with a DEAD/BLOCKED GPRS-NS and segmented SN-UNITDATA. For the caller it is not easy to know if the passed msg buffer has been freed or not. The most easy solution is to always take the ownership and either pass it on or free it in case of an error. Adjust indirect and direct callers of gprs_ns_sendmsg. I found the following call-chains with an external msgb parameter. gprs_ns_sendmsg <- _bssgp_tx_dl_ud <- bssgp_fc_in <- bssgp_tx_dl_ud Update the test to allocate a real msgb because for the test with '1000' we will msgb_free it right away. Sponsored-by: On-Waves ehf
2014-10-10 15:24:34 +00:00
msgb_free(msg);
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
return -ENODEV;
[GPRS] BSSGP: Make implementation more robust We now actually are much more in line with what the specification says. We track the blocked/unblocked state, we don't accept signalling messages on PTP functional entities (and vice versa), and we don't simply create a BVC context with messages other than BVC-RESET.
2010-05-13 19:26:28 +00:00
}
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
if (msg->len > TVLV_MAX_ONEBYTE)
llc_pdu_tlv_hdr_len += 1;
/* prepend the tag and length of the LLC-PDU TLV */
llc_pdu_tlv = msgb_push(msg, llc_pdu_tlv_hdr_len);
llc_pdu_tlv[0] = BSSGP_IE_LLC_PDU;
if (llc_pdu_tlv_hdr_len > 2) {
llc_pdu_tlv[1] = msg_len >> 8;
llc_pdu_tlv[2] = msg_len & 0xff;
} else {
[gprs] bssgp: Fix LLC PDU length encoding in BSSGP. Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
2010-06-09 19:13:13 +00:00
llc_pdu_tlv[1] = msg_len & 0x7f;
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
llc_pdu_tlv[1] |= 0x80;
}
[GPRS] Include IMSI and DRX params in BSSGP DL-UD When we send a downlink unit-data request via BSSGP, there is a lot of information that needs to be copied from the mm context, such as the IMSI, DRX parametes, MS radio access parameters, ... This is a quite strange layering violation, since we now need to pass a pointer to the MM ctx from GMM through LLC into BSSGP :(
2010-05-31 20:12:30 +00:00
/* FIXME: optional elements: Alignment, UTRAN CCO, LSA, PFI */
bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity) Currently the implementation of bssgp_tx_dl_ud conditionally adds some optional IE if dup != NULL. Later on is dereferences dup to access qos_profile and fc, but this without checking dup in advance. This may lead to an segmentation violation fault. This commit changes the value range of the function to only accept dup != NULL. An assertion will fail otherwise. All other explicit checks for non-NULL are removed. Fixes: Coverity CID 1040673 Sponsored-by: On-Waves ehf
2015-04-07 15:52:43 +00:00
/* Old TLLI to help BSS map from old->new */
if (dup->tlli) {
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
uint32_t tlli = osmo_htonl(*dup->tlli);
bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity) Currently the implementation of bssgp_tx_dl_ud conditionally adds some optional IE if dup != NULL. Later on is dereferences dup to access qos_profile and fc, but this without checking dup in advance. This may lead to an segmentation violation fault. This commit changes the value range of the function to only accept dup != NULL. An assertion will fail otherwise. All other explicit checks for non-NULL are removed. Fixes: Coverity CID 1040673 Sponsored-by: On-Waves ehf
2015-04-07 15:52:43 +00:00
msgb_tvlv_push(msg, BSSGP_IE_TLLI, 4, (uint8_t *) &tlli);
}
[GPRS] Include IMSI and DRX params in BSSGP DL-UD When we send a downlink unit-data request via BSSGP, there is a lot of information that needs to be copied from the mm context, such as the IMSI, DRX parametes, MS radio access parameters, ... This is a quite strange layering violation, since we now need to pass a pointer to the MM ctx from GMM through LLC into BSSGP :(
2010-05-31 20:12:30 +00:00
bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity) Currently the implementation of bssgp_tx_dl_ud conditionally adds some optional IE if dup != NULL. Later on is dereferences dup to access qos_profile and fc, but this without checking dup in advance. This may lead to an segmentation violation fault. This commit changes the value range of the function to only accept dup != NULL. An assertion will fail otherwise. All other explicit checks for non-NULL are removed. Fixes: Coverity CID 1040673 Sponsored-by: On-Waves ehf
2015-04-07 15:52:43 +00:00
/* IMSI */
if (dup->imsi && strlen(dup->imsi)) {
Revert "add osmo_mobile_identity API" This reverts commit d1ceca9d48eb3d8b212f386a1ebb35d8fc612297, as it introduces regressions in both osmo-msc and osmo-nitb which have been causing failing builds for several days now. Change-Id: I4bd958d0cd2ab4b0c4725e6d114f4404d725fcf7
2020-06-16 06:44:42 +00:00
uint8_t mi[GSM48_MID_MAX_SIZE];
/* gsm48_generate_mid_from_imsi() is guaranteed to never return more than 11,
* but somehow gcc (8.2) is not smart enough to figure this out and claims that
* the memcpy in msgb_tvlv_put() below will cause and out-of-bounds access up to
* mi[131], which is wrong */
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Warray-bounds"
int imsi_len = gsm48_generate_mid_from_imsi(mi, dup->imsi);
OSMO_ASSERT(imsi_len <= GSM48_MID_MAX_SIZE);
if (imsi_len > 2)
msgb_tvlv_push(msg, BSSGP_IE_IMSI,
imsi_len-2, mi+2);
#pragma GCC diagnostic pop
bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity) Currently the implementation of bssgp_tx_dl_ud conditionally adds some optional IE if dup != NULL. Later on is dereferences dup to access qos_profile and fc, but this without checking dup in advance. This may lead to an segmentation violation fault. This commit changes the value range of the function to only accept dup != NULL. An assertion will fail otherwise. All other explicit checks for non-NULL are removed. Fixes: Coverity CID 1040673 Sponsored-by: On-Waves ehf
2015-04-07 15:52:43 +00:00
}
[GPRS] Include IMSI and DRX params in BSSGP DL-UD When we send a downlink unit-data request via BSSGP, there is a lot of information that needs to be copied from the mm context, such as the IMSI, DRX parametes, MS radio access parameters, ... This is a quite strange layering violation, since we now need to pass a pointer to the MM ctx from GMM through LLC into BSSGP :(
2010-05-31 20:12:30 +00:00
bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity) Currently the implementation of bssgp_tx_dl_ud conditionally adds some optional IE if dup != NULL. Later on is dereferences dup to access qos_profile and fc, but this without checking dup in advance. This may lead to an segmentation violation fault. This commit changes the value range of the function to only accept dup != NULL. An assertion will fail otherwise. All other explicit checks for non-NULL are removed. Fixes: Coverity CID 1040673 Sponsored-by: On-Waves ehf
2015-04-07 15:52:43 +00:00
/* DRX parameters */
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
drx_params = osmo_htons(dup->drx_parms);
bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity) Currently the implementation of bssgp_tx_dl_ud conditionally adds some optional IE if dup != NULL. Later on is dereferences dup to access qos_profile and fc, but this without checking dup in advance. This may lead to an segmentation violation fault. This commit changes the value range of the function to only accept dup != NULL. An assertion will fail otherwise. All other explicit checks for non-NULL are removed. Fixes: Coverity CID 1040673 Sponsored-by: On-Waves ehf
2015-04-07 15:52:43 +00:00
msgb_tvlv_push(msg, BSSGP_IE_DRX_PARAMS, 2,
(uint8_t *) &drx_params);
[GPRS] Include IMSI and DRX params in BSSGP DL-UD When we send a downlink unit-data request via BSSGP, there is a lot of information that needs to be copied from the mm context, such as the IMSI, DRX parametes, MS radio access parameters, ... This is a quite strange layering violation, since we now need to pass a pointer to the MM ctx from GMM through LLC into BSSGP :(
2010-05-31 20:12:30 +00:00
bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity) Currently the implementation of bssgp_tx_dl_ud conditionally adds some optional IE if dup != NULL. Later on is dereferences dup to access qos_profile and fc, but this without checking dup in advance. This may lead to an segmentation violation fault. This commit changes the value range of the function to only accept dup != NULL. An assertion will fail otherwise. All other explicit checks for non-NULL are removed. Fixes: Coverity CID 1040673 Sponsored-by: On-Waves ehf
2015-04-07 15:52:43 +00:00
/* FIXME: Priority */
libgb: remove dependency of BSSGP to include sgsn/gmm internal structs
2012-06-17 01:31:16 +00:00
bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity) Currently the implementation of bssgp_tx_dl_ud conditionally adds some optional IE if dup != NULL. Later on is dereferences dup to access qos_profile and fc, but this without checking dup in advance. This may lead to an segmentation violation fault. This commit changes the value range of the function to only accept dup != NULL. An assertion will fail otherwise. All other explicit checks for non-NULL are removed. Fixes: Coverity CID 1040673 Sponsored-by: On-Waves ehf
2015-04-07 15:52:43 +00:00
/* MS Radio Access Capability */
if (dup->ms_ra_cap.len)
msgb_tvlv_push(msg, BSSGP_IE_MS_RADIO_ACCESS_CAP,
dup->ms_ra_cap.len, dup->ms_ra_cap.v);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
/* prepend the pdu lifetime */
libgb: remove dependency of BSSGP to include sgsn/gmm internal structs
2012-06-17 01:31:16 +00:00
msgb_tvlv_push(msg, BSSGP_IE_PDU_LIFETIME, 2, (uint8_t *)&_pdu_lifetime);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
/* prepend the QoS profile, TLLI and pdu type */
budh = (struct bssgp_ud_hdr *) msgb_push(msg, sizeof(*budh));
libgb: remove dependency of BSSGP to include sgsn/gmm internal structs
2012-06-17 01:31:16 +00:00
memcpy(budh->qos_profile, dup->qos_profile, sizeof(budh->qos_profile));
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
budh->tlli = osmo_htonl(msgb_tlli(msg));
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
budh->pdu_type = BSSGP_PDUT_DL_UNITDATA;
Use new stat item/ctr getter APIs Generated with spatch: """ @@ expression E1, E2; @@ - &E2->ctr[E1] + rate_ctr_group_get_ctr(E2, E1) """ """ @@ expression E1, E2, E3; @@ - E2->items[E1] + osmo_stat_item_group_get_item(E2, E1) """ Change-Id: I41297a8df68e28dfc6016330ac82b0ed5dd0ebc1
2021-06-04 16:17:12 +00:00
rate_ctr_inc(rate_ctr_group_get_ctr(bctx->ctrg, BSSGP_CTR_PKTS_OUT));
rate_ctr_add(rate_ctr_group_get_ctr(bctx->ctrg, BSSGP_CTR_BYTES_OUT), msg->len);
[GPRS] BSSGP: Introduce packet/byte counters
2010-05-17 21:30:01 +00:00
[gprs] SGSN: Expect all Identifiers to be stored at highest level We now expect the highest level (actual SGSN GMM code) to know all identifiers for every element in the protocol stack, i.e. TLLI, SAPI, BVCI and NSEI. The layer-inetrnal state is looked up based on those identifiers. The reason for this is to ensure only the highest level state needs to be persistent, while everything else can be regenerated dynamically (e.g. in a SGSN restart)
2010-05-02 09:19:37 +00:00
/* Identifiers down: BVCI, NSEI (in msgb->cb) */
gprs: remove msgb->nsvc pointer and replace it with NSEI and BVCI According to TS 08.16, the BSSGP layer needs to specify NSEI and BVCI when executing the NS UNITDATA REQUEST primitive of the underlying NS layer. Rather than passing around a pointer to the 'struct gprs_nsvc', we now have NSEI and BVCI as members of 'struct obsc_msgb_cb' and set them when BSSGP hands a message down to NS. NS then does a lookup of the 'gprs_nsvc' based on the NSEI parameter.
2010-04-30 17:54:29 +00:00
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
/* check if we have to go through per-ms flow control or can go
* directly to the per-BSS flow control */
if (dup->fc)
BSSGP: make bvc_ctx->fc a dynamic talloc allocation this ensures that we can talloc the flow-control queue entries as siblings off the bvc_ctx.
2012-09-07 09:29:32 +00:00
return bssgp_fc_in(dup->fc, msg, msg_len, bctx->fc);
libosmogb: Port BSSGP flow control from openbsc/laforge/bssgp_fc branch This code is supposed to implement the BSSGP flow control algorithm, both for the per-BSS and for the per-MS flow control. The code currently has no test cases, they will come in a separate commit.
2012-09-06 19:57:11 +00:00
else
BSSGP: make bvc_ctx->fc a dynamic talloc allocation this ensures that we can talloc the flow-control queue entries as siblings off the bvc_ctx.
2012-09-07 09:29:32 +00:00
return bssgp_fc_in(bctx->fc, msg, msg_len, NULL);
Create new 'gprs-sgsn' branch on top of 'gprs-conf' This branch contains the partial SGSN/GGSN implementation that was originally developed as part of the gprs branch.
2010-03-14 07:45:01 +00:00
}
[GPRS] BSSGP/SGSN: Implement Gb-Interface Paging We now have a function that generates BSSGP PS and CS paging request. It is called from the libgtp code when we receive a GTP packet from the GGSN for a MM context that is in SUSPEND state. We then issue a PS paging request to the Cell with the BVCI where the last RA update was being performed. TODO: We still don't enqueue the GTP packet (and transmit it on paging complete), and we don't rate-limit the paging requests, i.e. every GTP packet will trigger another paging request. We probably also need some kind of logic that marks the phone as UNREGISTERED if it doesn't respond to paging requests for some time.
2010-06-09 14:22:28 +00:00
/* Send a single GMM-PAGING.req to a given NSEI/NS-BVCI */
libgb: make sure all BSSGP functions have bssgp_ prefix We change the minority of functions employing the gprs_bssgp_ prefix to match with the majority without gprs_ in front.
2012-06-17 05:04:02 +00:00
int bssgp_tx_paging(uint16_t nsei, uint16_t ns_bvci,
struct bssgp_paging_info *pinfo)
[GPRS] BSSGP/SGSN: Implement Gb-Interface Paging We now have a function that generates BSSGP PS and CS paging request. It is called from the libgtp code when we receive a GTP packet from the GGSN for a MM context that is in SUSPEND state. We then issue a PS paging request to the Cell with the BVCI where the last RA update was being performed. TODO: We still don't enqueue the GTP packet (and transmit it on paging complete), and we don't rate-limit the paging requests, i.e. every GTP packet will trigger another paging request. We probably also need some kind of logic that marks the phone as UNREGISTERED if it doesn't respond to paging requests for some time.
2010-06-09 14:22:28 +00:00
{
struct msgb *msg = bssgp_msgb_alloc();
struct bssgp_normal_hdr *bgph =
(struct bssgp_normal_hdr *) msgb_put(msg, sizeof(*bgph));
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
uint16_t drx_params = osmo_htons(pinfo->drx_params);
Revert "add osmo_mobile_identity API" This reverts commit d1ceca9d48eb3d8b212f386a1ebb35d8fc612297, as it introduces regressions in both osmo-msc and osmo-nitb which have been causing failing builds for several days now. Change-Id: I4bd958d0cd2ab4b0c4725e6d114f4404d725fcf7
2020-06-16 06:44:42 +00:00
uint8_t mi[GSM48_MID_MAX_SIZE];
int imsi_len = gsm48_generate_mid_from_imsi(mi, pinfo->imsi);
Add function to properly encode RAI Add gsm48_encode_ra() which takes appropriate struct as [out] parameter instead of generic buffer. Using uint8_t buffer instead of proper struct type prooved to be error-prone - see Coverity CID57877, CID57876. Old gsm48_construct_ra() is made into tiny wrapper around new function. The test output is adjusted because of the change in function return value which was constant and hence ignored anyway. Related: OS#1640 Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
2018-01-05 13:19:33 +00:00
struct gsm48_ra_id ra;
Revert "add osmo_mobile_identity API" This reverts commit d1ceca9d48eb3d8b212f386a1ebb35d8fc612297, as it introduces regressions in both osmo-msc and osmo-nitb which have been causing failing builds for several days now. Change-Id: I4bd958d0cd2ab4b0c4725e6d114f4404d725fcf7
2020-06-16 06:44:42 +00:00
if (imsi_len < 2)
return -EINVAL;
[GPRS] BSSGP/SGSN: Implement Gb-Interface Paging We now have a function that generates BSSGP PS and CS paging request. It is called from the libgtp code when we receive a GTP packet from the GGSN for a MM context that is in SUSPEND state. We then issue a PS paging request to the Cell with the BVCI where the last RA update was being performed. TODO: We still don't enqueue the GTP packet (and transmit it on paging complete), and we don't rate-limit the paging requests, i.e. every GTP packet will trigger another paging request. We probably also need some kind of logic that marks the phone as UNREGISTERED if it doesn't respond to paging requests for some time.
2010-06-09 14:22:28 +00:00
msgb_nsei(msg) = nsei;
msgb_bvci(msg) = ns_bvci;
if (pinfo->mode == BSSGP_PAGING_PS)
bgph->pdu_type = BSSGP_PDUT_PAGING_PS;
else
bgph->pdu_type = BSSGP_PDUT_PAGING_CS;
/* IMSI */
Revert "add osmo_mobile_identity API" This reverts commit d1ceca9d48eb3d8b212f386a1ebb35d8fc612297, as it introduces regressions in both osmo-msc and osmo-nitb which have been causing failing builds for several days now. Change-Id: I4bd958d0cd2ab4b0c4725e6d114f4404d725fcf7
2020-06-16 06:44:42 +00:00
/* gsm48_generate_mid_from_imsi() is guaranteed to never return more than 11,
* but somehow gcc (8.2) is not smart enough to figure this out and claims that
* the memcpy in msgb_tvlv_put() below will cause and out-of-bounds access up to
* mi[131], which is wrong */
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Warray-bounds"
OSMO_ASSERT(imsi_len <= GSM48_MID_MAX_SIZE);
msgb_tvlv_put(msg, BSSGP_IE_IMSI, imsi_len-2, mi+2);
#pragma GCC diagnostic pop
[GPRS] BSSGP/SGSN: Implement Gb-Interface Paging We now have a function that generates BSSGP PS and CS paging request. It is called from the libgtp code when we receive a GTP packet from the GGSN for a MM context that is in SUSPEND state. We then issue a PS paging request to the Cell with the BVCI where the last RA update was being performed. TODO: We still don't enqueue the GTP packet (and transmit it on paging complete), and we don't rate-limit the paging requests, i.e. every GTP packet will trigger another paging request. We probably also need some kind of logic that marks the phone as UNREGISTERED if it doesn't respond to paging requests for some time.
2010-06-09 14:22:28 +00:00
/* DRX Parameters */
msgb_tvlv_put(msg, BSSGP_IE_DRX_PARAMS, 2,
(uint8_t *) &drx_params);
/* Scope */
switch (pinfo->scope) {
case BSSGP_PAGING_BSS_AREA:
{
uint8_t null = 0;
msgb_tvlv_put(msg, BSSGP_IE_BSS_AREA_ID, 1, &null);
}
break;
case BSSGP_PAGING_LOCATION_AREA:
Add function to properly encode RAI Add gsm48_encode_ra() which takes appropriate struct as [out] parameter instead of generic buffer. Using uint8_t buffer instead of proper struct type prooved to be error-prone - see Coverity CID57877, CID57876. Old gsm48_construct_ra() is made into tiny wrapper around new function. The test output is adjusted because of the change in function return value which was constant and hence ignored anyway. Related: OS#1640 Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
2018-01-05 13:19:33 +00:00
gsm48_encode_ra(&ra, &pinfo->raid);
msgb_tvlv_put(msg, BSSGP_IE_LOCATION_AREA, 4, (const uint8_t *)&ra);
[GPRS] BSSGP/SGSN: Implement Gb-Interface Paging We now have a function that generates BSSGP PS and CS paging request. It is called from the libgtp code when we receive a GTP packet from the GGSN for a MM context that is in SUSPEND state. We then issue a PS paging request to the Cell with the BVCI where the last RA update was being performed. TODO: We still don't enqueue the GTP packet (and transmit it on paging complete), and we don't rate-limit the paging requests, i.e. every GTP packet will trigger another paging request. We probably also need some kind of logic that marks the phone as UNREGISTERED if it doesn't respond to paging requests for some time.
2010-06-09 14:22:28 +00:00
break;
case BSSGP_PAGING_ROUTEING_AREA:
Add function to properly encode RAI Add gsm48_encode_ra() which takes appropriate struct as [out] parameter instead of generic buffer. Using uint8_t buffer instead of proper struct type prooved to be error-prone - see Coverity CID57877, CID57876. Old gsm48_construct_ra() is made into tiny wrapper around new function. The test output is adjusted because of the change in function return value which was constant and hence ignored anyway. Related: OS#1640 Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
2018-01-05 13:19:33 +00:00
bssgp_msgb_ra_put(msg, &pinfo->raid);
[GPRS] BSSGP/SGSN: Implement Gb-Interface Paging We now have a function that generates BSSGP PS and CS paging request. It is called from the libgtp code when we receive a GTP packet from the GGSN for a MM context that is in SUSPEND state. We then issue a PS paging request to the Cell with the BVCI where the last RA update was being performed. TODO: We still don't enqueue the GTP packet (and transmit it on paging complete), and we don't rate-limit the paging requests, i.e. every GTP packet will trigger another paging request. We probably also need some kind of logic that marks the phone as UNREGISTERED if it doesn't respond to paging requests for some time.
2010-06-09 14:22:28 +00:00
break;
case BSSGP_PAGING_BVCI:
{
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
uint16_t bvci = osmo_htons(pinfo->bvci);
[GPRS] BSSGP/SGSN: Implement Gb-Interface Paging We now have a function that generates BSSGP PS and CS paging request. It is called from the libgtp code when we receive a GTP packet from the GGSN for a MM context that is in SUSPEND state. We then issue a PS paging request to the Cell with the BVCI where the last RA update was being performed. TODO: We still don't enqueue the GTP packet (and transmit it on paging complete), and we don't rate-limit the paging requests, i.e. every GTP packet will trigger another paging request. We probably also need some kind of logic that marks the phone as UNREGISTERED if it doesn't respond to paging requests for some time.
2010-06-09 14:22:28 +00:00
msgb_tvlv_put(msg, BSSGP_IE_BVCI, 2, (uint8_t *)&bvci);
}
break;
}
/* QoS profile mandatory for PS */
if (pinfo->mode == BSSGP_PAGING_PS)
msgb_tvlv_put(msg, BSSGP_IE_QOS_PROFILE, 3, pinfo->qos);
/* Optional (P-)TMSI */
if (pinfo->ptmsi) {
libosmogb: Convert to use new endian conversion helpers Change-Id: I5ed17702cd9487e1cab6bae39802aa11fb6a37b0
2017-05-15 10:48:30 +00:00
uint32_t ptmsi = osmo_htonl(*pinfo->ptmsi);
[GPRS] BSSGP/SGSN: Implement Gb-Interface Paging We now have a function that generates BSSGP PS and CS paging request. It is called from the libgtp code when we receive a GTP packet from the GGSN for a MM context that is in SUSPEND state. We then issue a PS paging request to the Cell with the BVCI where the last RA update was being performed. TODO: We still don't enqueue the GTP packet (and transmit it on paging complete), and we don't rate-limit the paging requests, i.e. every GTP packet will trigger another paging request. We probably also need some kind of logic that marks the phone as UNREGISTERED if it doesn't respond to paging requests for some time.
2010-06-09 14:22:28 +00:00
msgb_tvlv_put(msg, BSSGP_IE_TMSI, 4, (uint8_t *) &ptmsi);
}
Gb/BSSGP: replace hardcoded Tx into NS library by a callback Add bssgp_ns_send callback() to set the transmission path into the NS library. This allows to use the Gb implementation with the old NS and the new upcoming NS implementation. Users of the old NS implementation don't have to set the callback as the default is the old NS implementation. Only users of the new NS implementation need to set the callback and the callback data. Change-Id: I3a498e6a0d68b87fed80c64199b22395796761b4
2020-07-18 13:57:07 +00:00
return bssgp_ns_send(bssgp_ns_send_data, msg);
[GPRS] BSSGP/SGSN: Implement Gb-Interface Paging We now have a function that generates BSSGP PS and CS paging request. It is called from the libgtp code when we receive a GTP packet from the GGSN for a MM context that is in SUSPEND state. We then issue a PS paging request to the Cell with the BVCI where the last RA update was being performed. TODO: We still don't enqueue the GTP packet (and transmit it on paging complete), and we don't rate-limit the paging requests, i.e. every GTP packet will trigger another paging request. We probably also need some kind of logic that marks the phone as UNREGISTERED if it doesn't respond to paging requests for some time.
2010-06-09 14:22:28 +00:00
}
libgb: Remove dependency to openbsc/debug.h
2012-06-16 09:45:59 +00:00
libgb: make sure all BSSGP functions have bssgp_ prefix We change the minority of functions employing the gprs_bssgp_ prefix to match with the majority without gprs_ in front.
2012-06-17 05:04:02 +00:00
void bssgp_set_log_ss(int ss)
libgb: Remove dependency to openbsc/debug.h
2012-06-16 09:45:59 +00:00
{
bssgp: Remove newly added log line warning about NOOP osmo-pcu unit tests fail ue to this new log line. Let's rather simply leave a comment there, since anyway known apps will be migrating soon the new APIs. Fixes: fde19ed579c3145959301bbe75fde15509276040 Change-Id: Ib9bf528db08f7aaa4adaf7b6a320679a4f11a53d
2020-12-10 12:38:42 +00:00
/* BSSGP has moved from DGPRS to DLGPRS, please update your code if it's
* still calling this function
*/
libgb: Remove dependency to openbsc/debug.h
2012-06-16 09:45:59 +00:00
}
bssgp: introduce flush queue functions To reset the state of BSSGP allow to flush the BSSGP queues. When testing (with TTCN3) the test object should be resetted between each test. Introduce the functions: bssgp_fc_flush_queue() - flushs a single flow control object bssgp_flush_all_queues() - flushs queues of all BSSGP connections Change-Id: I29b6ad6742ddf9b0b58b4af37d9a1cf18e019325
2018-08-07 09:22:28 +00:00
/*!
* \brief Flush the queue of the bssgp_flow_control
* \param[in] The flow control object which holds the queue.
*/
void bssgp_fc_flush_queue(struct bssgp_flow_control *fc)
{
struct bssgp_fc_queue_element *element, *tmp;
llist_for_each_entry_safe(element, tmp, &fc->queue, list) {
msgb_free(element->msg);
llist_del(&element->list);
talloc_free(element);
}
}
/*!
* \brief Flush the queues of all BSSGP contexts.
*/
Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore cold that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2
2022-11-03 10:05:58 +00:00
void bssgp_flush_all_queues(void)
bssgp: introduce flush queue functions To reset the state of BSSGP allow to flush the BSSGP queues. When testing (with TTCN3) the test object should be resetted between each test. Introduce the functions: bssgp_fc_flush_queue() - flushs a single flow control object bssgp_flush_all_queues() - flushs queues of all BSSGP connections Change-Id: I29b6ad6742ddf9b0b58b4af37d9a1cf18e019325
2018-08-07 09:22:28 +00:00
{
struct bssgp_bvc_ctx *bctx;
llist_for_each_entry(bctx, &bssgp_bvc_ctxts, list) {
if (bctx->fc)
bssgp_fc_flush_queue(bctx->fc);
}
}