osmocom
/
libosmocore
mirror of https://gerrit.osmocom.org/libosmocore
11
0
Fork 1
Code Issues Releases Wiki Activity
libosmocore/tests/gsm0408/gsm0408_test.ok

267 lines
6.8 KiB
Plaintext
Raw Normal View History

GSM 04.08: Add support for parsing CSD related bearer capabilities Also adds a test case for both encoder and decoder of this IE
2012-08-24 19:27:26 +00:00
Test `CSD 9600/V.110/transparent' passed
Test `Speech, all codecs' passed
gsm0408: Avoid unaligned memory access in gsm48_generate_mid_from_tmsi The &buf[3] is unlikely to be aligned properly. Use memcpy instead of an assignment. Add a small testcase that verifies that I didn't mess up the conversion. Alignment trap: osmo-nitb (3293) PC=0x492b7094 Instr=0xe5803003 Address=0xbeb259db FSR 0x801
2013-07-03 07:56:53 +00:00
Simple TMSI encoding test....passed
Add test for gsm48_generate_mid_from_imsi() Change-Id: Ibe5c0831268c788ceecd10fd7b22ece6480da817
2018-02-15 10:27:18 +00:00
Simple IMSI encoding test....passed: [10] 17 08 99 10 07 00 00 00 64 02
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
Testing Mobile Identity conversions
- IMSI 123456789012345
-> MI-TLV-hex='17081932547698103254'
-> MI-str="123456789012345" rc=16
- IMSI 12345678901234
-> MI-TLV-hex='170811325476981032f4'
-> MI-str="12345678901234" rc=15
- IMSI 423423
-> MI-TLV-hex='1704413224f3'
-> MI-str="423423" rc=7
- unknown 0x9 423423
gsm48_generate_mid(): mask out ODD flag from mi_type For MI encoding, see 3GPP TS 24.008, 10.5.1.4 Mobile Identity. The 'odd' flag indicates whether the last BCD nibble is used. Of course that flag should be made sure to reflect the actual length. Change-Id: Id6e695ebf9f86b295eaa7e2c6228989256f37e68
2018-12-05 22:24:50 +00:00
-> MI-TLV-hex='1704413224f3'
-> MI-str="423423" rc=7
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- IMSI 4234235
-> MI-TLV-hex='170449322453'
-> MI-str="4234235" rc=8
- IMSI 4234235
-> MI-TLV-hex='170449322453'
gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases By using osmo_bcd2str(), ensure that the resulting string is always nul terminated, and always return strlen()+1 whether truncated or not. Still keep up the previous return value style, even if that isn't consistent at all. The difference between IMSI/IMEI and TMSI return values remains and is not part of this patch. Change-Id: I1b51b72a721e1cc9d69796b804ebda741ff0f36b
2018-12-05 20:32:40 +00:00
-> MI-str="423" rc=4
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- IMEI 123456789012345
-> MI-TLV-hex='17081a32547698103254'
-> MI-str="123456789012345" rc=16
- IMEI 98765432109876
-> MI-TLV-hex='170892785634129078f6'
-> MI-str="98765432109876" rc=15
- IMEI 987654321098765
-> MI-TLV-hex='17089a78563412907856'
-> MI-str="987654321098765" rc=16
- IMEI-SV 987654321098765432
-> MI-TLV-hex='170a937856341290785634f2'
-> MI-str="987654321098765432" rc=19
- IMEI-SV 987654321098765432
-> MI-TLV-hex='170a937856341290785634f2'
gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases By using osmo_bcd2str(), ensure that the resulting string is always nul terminated, and always return strlen()+1 whether truncated or not. Still keep up the previous return value style, even if that isn't consistent at all. The difference between IMSI/IMEI and TMSI return values remains and is not part of this patch. Change-Id: I1b51b72a721e1cc9d69796b804ebda741ff0f36b
2018-12-05 20:32:40 +00:00
-> MI-str="987654321098765" rc=16
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- TMSI 305419896
-> MI-TLV-hex='1705f412345678'
-> MI-str="305419896" rc=9
- TMSI 12648430
-> MI-TLV-hex='1705f400c0ffee'
-> MI-str="12648430" rc=8
- TMSI 0
-> MI-TLV-hex='1705f400000000'
-> MI-str="0" rc=1
- TMSI 305419896
-> MI-TLV-hex='1705f412345678'
-> MI-str="3054" rc=9
- NONE 123
-> MI-TLV-hex='17021832'
-> MI-str="" rc=1
- NONE 1234
-> MI-TLV-hex='17031032f4'
-> MI-str="" rc=1
- unknown 0x8 1234
gsm48_generate_mid(): mask out ODD flag from mi_type For MI encoding, see 3GPP TS 24.008, 10.5.1.4 Mobile Identity. The 'odd' flag indicates whether the last BCD nibble is used. Of course that flag should be made sure to reflect the actual length. Change-Id: Id6e695ebf9f86b295eaa7e2c6228989256f37e68
2018-12-05 22:24:50 +00:00
-> MI-TLV-hex='17031032f4'
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
-> MI-str="" rc=1
Decoding zero length Mobile Identities
- MI type: IMSI
- writing to zero-length string:
gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases By using osmo_bcd2str(), ensure that the resulting string is always nul terminated, and always return strlen()+1 whether truncated or not. Still keep up the previous return value style, even if that isn't consistent at all. The difference between IMSI/IMEI and TMSI return values remains and is not part of this patch. Change-Id: I1b51b72a721e1cc9d69796b804ebda741ff0f36b
2018-12-05 20:32:40 +00:00
rc=0
nothing written
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- writing to 1-byte-length string:
rc=1
gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases By using osmo_bcd2str(), ensure that the resulting string is always nul terminated, and always return strlen()+1 whether truncated or not. Still keep up the previous return value style, even if that isn't consistent at all. The difference between IMSI/IMEI and TMSI return values remains and is not part of this patch. Change-Id: I1b51b72a721e1cc9d69796b804ebda741ff0f36b
2018-12-05 20:32:40 +00:00
returned empty string
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- decode zero-length mi:
gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases By using osmo_bcd2str(), ensure that the resulting string is always nul terminated, and always return strlen()+1 whether truncated or not. Still keep up the previous return value style, even if that isn't consistent at all. The difference between IMSI/IMEI and TMSI return values remains and is not part of this patch. Change-Id: I1b51b72a721e1cc9d69796b804ebda741ff0f36b
2018-12-05 20:32:40 +00:00
rc=1
returned empty string
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- MI type: TMSI
- writing to zero-length string:
gsm48_mi_to_string(): guard against zero length output buffer All successful cases already return from the switch(), so simply handle all errors below it by returning an empty string (if there is enough string buffer). Change-Id: I709ac3b9efb7b4258d8660715b10312e11b9b571
2018-12-05 22:30:08 +00:00
rc=0
nothing written
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- writing to 1-byte-length string:
rc=1
returned empty string
- decode zero-length mi:
rc=1
returned empty string
- MI type: NONE
- writing to zero-length string:
gsm48_mi_to_string(): guard against zero length output buffer All successful cases already return from the switch(), so simply handle all errors below it by returning an empty string (if there is enough string buffer). Change-Id: I709ac3b9efb7b4258d8660715b10312e11b9b571
2018-12-05 22:30:08 +00:00
rc=0
nothing written
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- writing to 1-byte-length string:
rc=1
returned empty string
- decode zero-length mi:
rc=1
returned empty string
- MI type: IMSI | GSM_MI_ODD
- writing to zero-length string:
gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases By using osmo_bcd2str(), ensure that the resulting string is always nul terminated, and always return strlen()+1 whether truncated or not. Still keep up the previous return value style, even if that isn't consistent at all. The difference between IMSI/IMEI and TMSI return values remains and is not part of this patch. Change-Id: I1b51b72a721e1cc9d69796b804ebda741ff0f36b
2018-12-05 20:32:40 +00:00
rc=0
nothing written
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- writing to 1-byte-length string:
rc=1
gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases By using osmo_bcd2str(), ensure that the resulting string is always nul terminated, and always return strlen()+1 whether truncated or not. Still keep up the previous return value style, even if that isn't consistent at all. The difference between IMSI/IMEI and TMSI return values remains and is not part of this patch. Change-Id: I1b51b72a721e1cc9d69796b804ebda741ff0f36b
2018-12-05 20:32:40 +00:00
returned empty string
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- decode zero-length mi:
gsm48_mi_to_string: use osmo_bcd2str(), fix some corner cases By using osmo_bcd2str(), ensure that the resulting string is always nul terminated, and always return strlen()+1 whether truncated or not. Still keep up the previous return value style, even if that isn't consistent at all. The difference between IMSI/IMEI and TMSI return values remains and is not part of this patch. Change-Id: I1b51b72a721e1cc9d69796b804ebda741ff0f36b
2018-12-05 20:32:40 +00:00
rc=1
returned empty string
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- MI type: TMSI | GSM_MI_ODD
- writing to zero-length string:
gsm48_mi_to_string(): guard against zero length output buffer All successful cases already return from the switch(), so simply handle all errors below it by returning an empty string (if there is enough string buffer). Change-Id: I709ac3b9efb7b4258d8660715b10312e11b9b571
2018-12-05 22:30:08 +00:00
rc=0
nothing written
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- writing to 1-byte-length string:
rc=1
returned empty string
- decode zero-length mi:
rc=1
returned empty string
- MI type: NONE | GSM_MI_ODD
- writing to zero-length string:
gsm48_mi_to_string(): guard against zero length output buffer All successful cases already return from the switch(), so simply handle all errors below it by returning an empty string (if there is enough string buffer). Change-Id: I709ac3b9efb7b4258d8660715b10312e11b9b571
2018-12-05 22:30:08 +00:00
rc=0
nothing written
gsm0408_test: test encoding and decoding Mobile Identity One would think by now we would solidly encode and decode Mobile Identities. Well, guess again. - rc is sometimes the amount of bytes written, sometimes actual strlen(). - on string truncation, rc is sometimes strlen() (assuming nul terminated), and sometimes snprintf()-style would-be strlen(). - returned string, when truncated by not enough buffer size, is sometimes nul terminated, sometimes not. - gsm48_mi_to_string() happily reads a byte from zero-length input buffer. - gsm48_mi_to_string() happily writes to zero length output buffer. - gsm48_mi_to_string() returns nonempty string for empty input. - encoding a MI type that still has the GSM_MI_ODD flag set results in encoding an even-length MI as odd-length (hence appending a stray 'F'). I am going to tweak the implementation of gsm48 mobile identity encoding / decoding, so first pinpoint the current behavior in a unit test, and show how perforated even such a seemingly trivial API can be. Change-Id: Iaae3af87f82f1a8f2e6273984c011b2813038cf7
2018-12-05 20:32:21 +00:00
- writing to 1-byte-length string:
rc=1
returned empty string
- decode zero-length mi:
rc=1
returned empty string
Add function to properly encode RAI Add gsm48_encode_ra() which takes appropriate struct as [out] parameter instead of generic buffer. Using uint8_t buffer instead of proper struct type prooved to be error-prone - see Coverity CID57877, CID57876. Old gsm48_construct_ra() is made into tiny wrapper around new function. The test output is adjusted because of the change in function return value which was constant and hence ignored anyway. Related: OS#1640 Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
2018-01-05 13:19:33 +00:00
Constructed RA:
gsm0408_test: include BCD and leading zeros in test output (Preparation for adding 3-digit MNC) Change-Id: I7f8ae05fa3e4a6fc004212757b05ca8a14c9ef45
2018-02-20 14:13:18 +00:00
077-121-666-5
MCC+MNC in BCD: 70 17 21
gsm0408_test: check for new mnc_3_digits flag Note that on the input side, the 3-digits flag may be left false when the MNC is >99 anyway. On the decoded side, the flag is set accurately. Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c
2018-02-20 14:12:23 +00:00
077-121-666-5 (3-digit MNC)
libosmogsm: add Routing Area Identifier test Ensure that gsm48_parse_ra() and gsm48_construct_ra() behave properly. Change-Id: I27117fe728407dd10886459e89ba4ff9d5e53e6b
2017-08-30 17:17:50 +00:00
RA test...passed
Add function to properly encode RAI Add gsm48_encode_ra() which takes appropriate struct as [out] parameter instead of generic buffer. Using uint8_t buffer instead of proper struct type prooved to be error-prone - see Coverity CID57877, CID57876. Old gsm48_construct_ra() is made into tiny wrapper around new function. The test output is adjusted because of the change in function return value which was constant and hence ignored anyway. Related: OS#1640 Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74
2018-01-05 13:19:33 +00:00
Constructed RA:
gsm0408_test: include BCD and leading zeros in test output (Preparation for adding 3-digit MNC) Change-Id: I7f8ae05fa3e4a6fc004212757b05ca8a14c9ef45
2018-02-20 14:13:18 +00:00
084-98-11-89
MCC+MNC in BCD: 80 f4 89
084-98-11-89
libosmogsm: add Routing Area Identifier test Ensure that gsm48_parse_ra() and gsm48_construct_ra() behave properly. Change-Id: I27117fe728407dd10886459e89ba4ff9d5e53e6b
2017-08-30 17:17:50 +00:00
RA test...passed
gsm0408_test: RA test: include min/max value cases (Preparation for adding 3-digit MNC) Change-Id: Ifbc167de0cc039858112677b8d0cd14a2c8af086
2018-02-20 14:14:03 +00:00
Constructed RA:
000-00-0-0
MCC+MNC in BCD: 00 f0 00
000-00-0-0
RA test...passed
Constructed RA:
gsm0408_test: add test cases for MNC with leading zeros Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
2018-02-20 21:20:42 +00:00
000-000-0-0 (3-digit MNC)
MCC+MNC in BCD: 00 00 00
000-000-0-0 (3-digit MNC)
RA test...passed
Constructed RA:
gsm0408_test: RA test: include min/max value cases (Preparation for adding 3-digit MNC) Change-Id: Ifbc167de0cc039858112677b8d0cd14a2c8af086
2018-02-20 14:14:03 +00:00
999-999-65535-255
MCC+MNC in BCD: 99 99 99
gsm0408_test: check for new mnc_3_digits flag Note that on the input side, the 3-digits flag may be left false when the MNC is >99 anyway. On the decoded side, the flag is set accurately. Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c
2018-02-20 14:12:23 +00:00
999-999-65535-255 (3-digit MNC)
gsm0408_test: RA test: include min/max value cases (Preparation for adding 3-digit MNC) Change-Id: Ifbc167de0cc039858112677b8d0cd14a2c8af086
2018-02-20 14:14:03 +00:00
RA test...passed
gsm0408_test: add test cases for MNC with leading zeros Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
2018-02-20 21:20:42 +00:00
Constructed RA:
001-02-23-42
MCC+MNC in BCD: 00 f1 20
001-02-23-42
RA test...passed
Constructed RA:
001-002-23-42 (3-digit MNC)
MCC+MNC in BCD: 00 21 00
001-002-23-42 (3-digit MNC)
RA test...passed
Constructed RA:
012-34-56-78
MCC+MNC in BCD: 10 f2 43
012-34-56-78
RA test...passed
Constructed RA:
012-034-23-42 (3-digit MNC)
MCC+MNC in BCD: 10 42 30
012-034-23-42 (3-digit MNC)
RA test...passed
Constructed RA:
123-456-23-42
MCC+MNC in BCD: 21 63 54
123-456-23-42 (3-digit MNC)
RA test...passed
Constructed RA:
123-456-23-42 (3-digit MNC)
MCC+MNC in BCD: 21 63 54
123-456-23-42 (3-digit MNC)
RA test...passed
gsm0408_test: also test gsm48_generate_lai() and gsm48_decode_lai() Change-Id: Idd6cee090464bc92b654332904a9a08edf16e5c9
2018-02-20 20:48:07 +00:00
- gsm48_generate_lai() from 077-121-666-0
Encoded 70 17 21 02 9a
gsm48_decode_lai() gives 077-121-666-0
passed
gsm0408_test: test new gsm48_{decode,generate}_lai2() functions Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
2018-02-20 21:19:56 +00:00
- gsm48_generate_lai2() from 077-121-666
Encoded 70 17 21 02 9a
gsm48_decode_lai2() gives 077-121-666 (3-digit MNC)
passed
gsm0408_test: also test gsm48_generate_lai() and gsm48_decode_lai() Change-Id: Idd6cee090464bc92b654332904a9a08edf16e5c9
2018-02-20 20:48:07 +00:00
- gsm48_generate_lai() from 084-98-11-0
Encoded 80 f4 89 00 0b
gsm48_decode_lai() gives 084-98-11-0
passed
gsm0408_test: test new gsm48_{decode,generate}_lai2() functions Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
2018-02-20 21:19:56 +00:00
- gsm48_generate_lai2() from 084-98-11
Encoded 80 f4 89 00 0b
gsm48_decode_lai2() gives 084-98-11
passed
gsm0408_test: also test gsm48_generate_lai() and gsm48_decode_lai() Change-Id: Idd6cee090464bc92b654332904a9a08edf16e5c9
2018-02-20 20:48:07 +00:00
- gsm48_generate_lai() from 000-00-0-0
Encoded 00 f0 00 00 00
gsm48_decode_lai() gives 000-00-0-0
passed
gsm0408_test: test new gsm48_{decode,generate}_lai2() functions Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
2018-02-20 21:19:56 +00:00
- gsm48_generate_lai2() from 000-00-0
Encoded 00 f0 00 00 00
gsm48_decode_lai2() gives 000-00-0
passed
gsm0408_test: add test cases for MNC with leading zeros Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
2018-02-20 21:20:42 +00:00
- gsm48_generate_lai() from 000-000-0-0 (3-digit MNC)
Encoded 00 f0 00 00 00
gsm48_decode_lai() gives 000-00-0-0
passed
- gsm48_generate_lai2() from 000-000-0 (3-digit MNC)
Encoded 00 00 00 00 00
gsm48_decode_lai2() gives 000-000-0 (3-digit MNC)
passed
gsm0408_test: also test gsm48_generate_lai() and gsm48_decode_lai() Change-Id: Idd6cee090464bc92b654332904a9a08edf16e5c9
2018-02-20 20:48:07 +00:00
- gsm48_generate_lai() from 999-999-65535-0
Encoded 99 99 99 ff ff
gsm48_decode_lai() gives 999-999-65535-0
passed
gsm0408_test: test new gsm48_{decode,generate}_lai2() functions Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
2018-02-20 21:19:56 +00:00
- gsm48_generate_lai2() from 999-999-65535
Encoded 99 99 99 ff ff
gsm48_decode_lai2() gives 999-999-65535 (3-digit MNC)
passed
gsm0408_test: add test cases for MNC with leading zeros Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
2018-02-20 21:20:42 +00:00
- gsm48_generate_lai() from 001-02-23-0
Encoded 00 f1 20 00 17
gsm48_decode_lai() gives 001-02-23-0
passed
- gsm48_generate_lai2() from 001-02-23
Encoded 00 f1 20 00 17
gsm48_decode_lai2() gives 001-02-23
passed
- gsm48_generate_lai() from 001-002-23-0 (3-digit MNC)
Encoded 00 f1 20 00 17
gsm48_decode_lai() gives 001-02-23-0
passed
- gsm48_generate_lai2() from 001-002-23 (3-digit MNC)
Encoded 00 21 00 00 17
gsm48_decode_lai2() gives 001-002-23 (3-digit MNC)
passed
- gsm48_generate_lai() from 012-34-56-0
Encoded 10 f2 43 00 38
gsm48_decode_lai() gives 012-34-56-0
passed
- gsm48_generate_lai2() from 012-34-56
Encoded 10 f2 43 00 38
gsm48_decode_lai2() gives 012-34-56
passed
- gsm48_generate_lai() from 012-034-23-0 (3-digit MNC)
Encoded 10 f2 43 00 17
gsm48_decode_lai() gives 012-34-23-0
passed
- gsm48_generate_lai2() from 012-034-23 (3-digit MNC)
Encoded 10 42 30 00 17
gsm48_decode_lai2() gives 012-034-23 (3-digit MNC)
passed
- gsm48_generate_lai() from 123-456-23-0
Encoded 21 63 54 00 17
gsm48_decode_lai() gives 123-456-23-0
passed
- gsm48_generate_lai2() from 123-456-23
Encoded 21 63 54 00 17
gsm48_decode_lai2() gives 123-456-23 (3-digit MNC)
passed
- gsm48_generate_lai() from 123-456-23-0 (3-digit MNC)
Encoded 21 63 54 00 17
gsm48_decode_lai() gives 123-456-23-0
passed
- gsm48_generate_lai2() from 123-456-23 (3-digit MNC)
Encoded 21 63 54 00 17
gsm48_decode_lai2() gives 123-456-23 (3-digit MNC)
passed