osmocom
/
libosmo-sccp
mirror of https://gerrit.osmocom.org/libosmo-sccp
11
0
Fork 0
Code Issues Releases Wiki Activity

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 1000074 \u003c1000074@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
Gerrit User 1000010 2024-02-14 13:59:50 +00:00 committed by Gerrit Code Review
parent 3f64bbafa0
commit d87c3c5295
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
dacf17334861dd8d9531c4030742084b58d2aad4
View File

@ -102,6 +102,24 @@
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "f127ec47_c4e95365",
"filename": "src/osmo_ss7_vty.c",
"patchSetId": 3
},
"lineNbr": 65,
"author": {
"id": 1000010
},
"writtenOn": "2024-02-14T13:59:50Z",
"side": 1,
"message": "Yes, it looks weird, but at least it works this way. I first did it exactly as you suggested (this indeed looks more logical), but was hitting an assert due to certain limitations of the libosmovty\u0027s parser (see https://gerrit.osmocom.org/c/libosmocore/+/35961).\n\nOther than looking weird in the code / VTY syntax, both variants work identically.",
"parentUuid": "7fca15e0_a8d182d7",
"revId": "dacf17334861dd8d9531c4030742084b58d2aad4",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {