osmocom
/
libosmo-sccp
mirror of https://gerrit.osmocom.org/libosmo-sccp
14
0
Fork 0
Code Issues Releases Wiki Activity

error log: sccp_scoc.c: log failure to create/resolve conn_id 

Tweak the FIXMEs to clarify that we're lacking a reply to the SCCP user besides
log output.

Change-Id: Ib235ff8e264aaf0c2e9794f464a3ba7b54816f3d
This commit is contained in:
Neels Hofmeyr 2017-12-25 00:45:24 +01:00
parent 16676cf05a
commit 8254cf4f2a
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/sccp_scoc.c
View File

@ -1623,7 +1623,9 @@ int osmo_sccp_user_sap_down(struct osmo_sccp_user *scu, struct osmo_prim_hdr *op
/* Allocate new connection structure */
conn = conn_create_id(inst, prim->u.connect.conn_id);
if (!conn) {
/* FIXME: inform user */
/* FIXME: inform SCCP user with proper reply */
LOGP(DLSCCP, LOGL_ERROR, "Cannot create conn-id for primitive %s\n",
osmo_scu_prim_name(&prim->oph));
goto out;
}
conn->user = scu;
@ -1635,7 +1637,9 @@ int osmo_sccp_user_sap_down(struct osmo_sccp_user *scu, struct osmo_prim_hdr *op
/* Resolve existing connection structure */
conn = conn_find_by_id(inst, scu_prim_conn_id(prim));
if (!conn) {
/* FIXME: inform user */
/* FIXME: inform SCCP user with proper reply */
LOGP(DLSCCP, LOGL_ERROR, "Received unknown conn-id %u for primitive %s\n",
scu_prim_conn_id(prim), osmo_scu_prim_name(&prim->oph));
goto out;
}
break;